Refactoring Linux changes to separate function and fixinf indentation

Author: Sudhakara Reddy Evuri

src/ResourceManager/Compute/Commands.Compute.Test/ScenarioTests/VirtualMachineExtensionTests.ps1

@@ -874,7 +874,7 @@ function Test-AzureDiskEncryptionExtension
         $user2 = "Bar12";
         $password2 = 'FoO@123' + $rgname;
 		$aadClientID = '97f847ef-9e1e-4c7c-9ae7-1c0f7c78f761';
-		$aadClientSecret = 'e8335678-2063-4620-afa3-5ba815e27fd3';
+		$aadClientSecret = '';
 		$diskEncryptionKeyVaultUrl  = 'https://sureddvaultsc2.vault.azure.net'
 		$diskEncryptionKeyVaultId = '/subscriptions/0ee9d577-9bc4-4a32-a4e8-c29981025378/resourceGroups/sureddrgsc2/providers/Microsoft.KeyVault/vaults/sureddvaultsc2';
 		$volumeType = 'All';

src/ResourceManager/Compute/Commands.Compute/Extension/AzureDiskEncryption/SetAzureDiskEncryptionExtension.cs

@@ -151,6 +151,8 @@ public class SetAzureDiskEncryptionExtensionCommand : VirtualMachineExtensionBas
         [ValidateNotNullOrEmpty]
         public SwitchParameter Force { get; set; }
 
+        private string currentOSType = null;
+
         private void ValidateInputParameters()
         {
             if (false == Uri.IsWellFormedUriString(DiskEncryptionKeyVaultId, UriKind.Absolute))
@@ -192,24 +194,24 @@ private string GetExtensionStatusMessage()
                                                       ErrorCategory.InvalidResult,
                                                       null));
             }
-            bool publisherMismatch = false;
+            bool publisherMatch = false;
             if (string.Equals(currentOSType, "Linux", StringComparison.InvariantCultureIgnoreCase))
             {
                 if (returnedExtension.Publisher.Equals(AzureDiskEncryptionExtensionContext.LinuxExtensionDefaultPublisher, StringComparison.InvariantCultureIgnoreCase) &&
-                                  returnedExtension.ExtensionType.Equals(AzureDiskEncryptionExtensionContext.LinuxExtensionDefaultName, StringComparison.InvariantCultureIgnoreCase))
+                    returnedExtension.ExtensionType.Equals(AzureDiskEncryptionExtensionContext.LinuxExtensionDefaultName, StringComparison.InvariantCultureIgnoreCase))
                 {
-                    publisherMismatch = true;
+                    publisherMatch = true;
                 }
             }
-            else if(string.Equals(currentOSType,"Windows",StringComparison.InvariantCultureIgnoreCase))
+            else if (string.Equals(currentOSType, "Windows", StringComparison.InvariantCultureIgnoreCase))
             {
                 if (returnedExtension.Publisher.Equals(AzureDiskEncryptionExtensionContext.ExtensionDefaultPublisher, StringComparison.InvariantCultureIgnoreCase) &&
-                               returnedExtension.ExtensionType.Equals(AzureDiskEncryptionExtensionContext.ExtensionDefaultName, StringComparison.InvariantCultureIgnoreCase))
+                    returnedExtension.ExtensionType.Equals(AzureDiskEncryptionExtensionContext.ExtensionDefaultName, StringComparison.InvariantCultureIgnoreCase))
                 {
-                    publisherMismatch = true;
+                    publisherMatch = true;
                 }
             }
-            if (publisherMismatch)
+            if (publisherMatch)
             {
                 AzureDiskEncryptionExtensionContext context = new AzureDiskEncryptionExtensionContext(returnedExtension);
                 if ((context == null) ||
@@ -305,13 +307,11 @@ private string GetExtensionProtectedSettings()
             return JsonConvert.SerializeObject(protectedSettings);
         }
 
-        private VirtualMachineExtension GetVmExtensionParameters()
+        private VirtualMachineExtension GetVmExtensionParameters(VirtualMachine vmParameters)
         {
             string SettingString = GetExtensionPublicSettings();
             string ProtectedSettingString = GetExtensionProtectedSettings();
 
-
-            VirtualMachine vmParameters = (this.ComputeClient.ComputeManagementClient.VirtualMachines.Get(this.ResourceGroupName, this.VMName)).VirtualMachine;
             if (vmParameters == null)
             {
                 ThrowTerminatingError(new ErrorRecord(new ApplicationException(string.Format(CultureInfo.CurrentUICulture, "Set-AzureDiskEncryptionExtension can enable encryption only on a VM that was already created ")),
@@ -353,7 +353,29 @@ private VirtualMachineExtension GetVmExtensionParameters()
             return vmExtensionParameters;
         }
 
-        private string currentOSType = null;
+        private void CreateVMBackupForLinx()
+        {
+            try
+            {
+                AzureVMBackupExtensionUtil azureBackupExtensionUtil = new AzureVMBackupExtensionUtil();
+                AzureVMBackupConfig vmConfig = new AzureVMBackupConfig();
+                vmConfig.ResourceGroupName = ResourceGroupName;
+                vmConfig.VMName = VMName;
+                vmConfig.VirtualMachineExtensionType = VirtualMachineExtensionType;
+                string tag = string.Format("{0}{1}", "AzureEnc", Guid.NewGuid().ToString());
+                // this would create shapshot only for Linux box. and we should wait for the snapshot found.
+                azureBackupExtensionUtil.CreateSnapshotForDisks(vmConfig, tag, this);
+
+                WriteInformation(new InformationRecord(string.Format("one snapshot for disks are created with tag,{0}", tag), string.Empty));
+            }
+            catch (AzureVMBackupException e)
+            {
+                ThrowTerminatingError(new ErrorRecord(new ApplicationException(string.Format(CultureInfo.CurrentUICulture, e.ToString())),
+                                                      "InvalidResult",
+                                                      ErrorCategory.InvalidResult,
+                                                      null));
+            }
+        }
 
         protected override void ProcessRecord()
         {
@@ -368,37 +390,16 @@ protected override void ProcessRecord()
 
                     currentOSType = virtualMachineResponse.StorageProfile.OSDisk.OperatingSystemType;
 
-                    if(string.Equals(currentOSType,"Linux",StringComparison.InvariantCultureIgnoreCase))
+                    if (string.Equals(currentOSType, "Linux", StringComparison.InvariantCultureIgnoreCase))
                     {
-                        try
-                        {
-                            AzureVMBackupExtensionUtil azureBackupExtensionUtil = new AzureVMBackupExtensionUtil();
-                            AzureVMBackupConfig vmConfig = new AzureVMBackupConfig();
-                            vmConfig.ResourceGroupName = ResourceGroupName;
-                            vmConfig.VMName = VMName;
-                            vmConfig.VirtualMachineExtensionType = VirtualMachineExtensionType;
-                            string tag = string.Format("{0}{1}", "AzureEnc", Guid.NewGuid().ToString());
-                            // this would create shapshot only for Linux box. and we should wait for the snapshot found.
-                            azureBackupExtensionUtil.CreateSnapshotForDisks(vmConfig, tag, this);
-                            
-                            WriteInformation(new InformationRecord(string.Format("one snapshot for disks are created with tag,{0}",tag), string.Empty));
-                        }
-                        catch (AzureVMBackupException e)
-                        {
-                            ThrowTerminatingError(new ErrorRecord(new ApplicationException(string.Format(CultureInfo.CurrentUICulture, e.ToString())),
-                                                      "InvalidResult",
-                                                      ErrorCategory.InvalidResult,
-                                                      null));
-                        }
+                        CreateVMBackupForLinx();
                     }
 
-                    VirtualMachineExtension parameters = GetVmExtensionParameters();
+                    VirtualMachineExtension parameters = GetVmExtensionParameters(virtualMachineResponse);
 
                     this.VirtualMachineExtensionClient.CreateOrUpdate(this.ResourceGroupName,
-                                                                               this.VMName,
-                                                                               parameters);
-
-                    
+                                                                      this.VMName,
+                                                                      parameters);
 
                     var op = UpdateVmEncryptionSettings();
                     WriteObject(Mapper.Map<PSComputeLongRunningOperation>(op));