Get Item Bug Fixes and Test Records

Author: dragonfly91

src/ResourceManager/RecoveryServices.Backup/Commands.RecoveryServices.Backup.Providers/Providers/IaasVmPsBackupProvider.cs

@@ -447,24 +447,40 @@ public List<AzureRmRecoveryServicesBackupItemBase> ListProtectedItems()
                 return containerUri.Contains(container.Name);
             }).ToList();
 
-            List<AzureRmRecoveryServicesBackupItemBase> itemModels = ConversionHelpers.GetItemModelList(protectedItems, container);
+            List<ProtectedItemResponse> protectedItemGetResponses = new List<ProtectedItemResponse>();
 
             // 2. Filter by item's friendly name
             if (!string.IsNullOrEmpty(name))
             {
-                itemModels = itemModels.Where(itemModel =>
+                protectedItems = protectedItems.Where(protectedItem =>
                 {
-                    return ((AzureRmRecoveryServicesBackupIaasVmItem)itemModel).Name == name;
+                    Dictionary<UriEnums, string> dictionary = HelperUtils.ParseUri(protectedItem.Id);
+                    string protectedItemUri = HelperUtils.GetProtectedItemUri(dictionary, protectedItem.Id);
+                    return protectedItemUri.Contains(name);
                 }).ToList();
 
                 GetProtectedItemQueryParam getItemQueryParams = new GetProtectedItemQueryParam();
                 getItemQueryParams.Expand = "extendedinfo";
 
+                for (int i = 0; i < protectedItems.Count; i++)
+                {
+                    Dictionary<UriEnums, string> dictionary = HelperUtils.ParseUri(protectedItems[i].Id);
+                    string containerUri = HelperUtils.GetContainerUri(dictionary, protectedItems[i].Id);
+                    string protectedItemUri = HelperUtils.GetProtectedItemUri(dictionary, protectedItems[i].Id);
+
+                    var getResponse = HydraAdapter.GetProtectedItem(containerUri, protectedItemUri, getItemQueryParams);
+                    protectedItemGetResponses.Add(getResponse);
+                }
+            }
+
+            List<AzureRmRecoveryServicesBackupItemBase> itemModels = ConversionHelpers.GetItemModelList(protectedItems, container);
+
+            if (!string.IsNullOrEmpty(name))
+            {
                 for (int i = 0; i < itemModels.Count; i++)
                 {
-                    var getResponse = HydraAdapter.GetProtectedItem(container.Name, itemModels[i].Name, getItemQueryParams);
                     AzureRmRecoveryServicesBackupIaasVmItemExtendedInfo extendedInfo = new AzureRmRecoveryServicesBackupIaasVmItemExtendedInfo();
-                    var hydraExtendedInfo = ((AzureIaaSVMProtectedItem)getResponse.Item.Properties).ExtendedInfo;
+                    var hydraExtendedInfo = ((AzureIaaSVMProtectedItem)protectedItemGetResponses[i].Item.Properties).ExtendedInfo;
                     if (hydraExtendedInfo.OldestRecoveryPoint.HasValue)
                     {
                         extendedInfo.OldestRecoveryPoint = hydraExtendedInfo.OldestRecoveryPoint;

src/ResourceManager/RecoveryServices.Backup/Commands.RecoveryServices.Backup.Test/ScenarioTests/IaasVm/ItemTests.ps1

@@ -14,13 +14,13 @@
 
 function Test-GetItemScenario
 {
-	$vault = Get-AzureRmRecoveryServicesVault -ResourceGroupName "pstestrg" -Name "pstestrsvault";
+	$vault = Get-AzureRmRecoveryServicesVault -ResourceGroupName "RsvTestRG" -Name "PsTestRsVault";
 	Set-AzureRmRecoveryServicesVaultContext -Vault $vault;
 
-	$namedContainer = Get-AzureRmRecoveryServicesContainer -ContainerType "AzureVM" -Status "Registered" -Name "pstestv2vm1";
-	Assert-AreEqual $namedContainer.FriendlyName "pstestv2vm1";
+	$namedContainer = Get-AzureRmRecoveryServicesBackupContainer -ContainerType "AzureVM" -Status "Registered";
+	Assert-AreEqual $namedContainer[2].FriendlyName "mkheranirmvm1";
 
-	$item = Get-AzureRmRecoveryServices=Item -Container $namedContainer -WorkloadType "AzureVM";
+	$item = Get-AzureRmRecoveryServicesBackupItem -Container $namedContainer[2] -WorkloadType "AzureVM" -Name "mkheranirmvm1";
 	echo $item.Name;
 }