enabling disabled tests (Azure#3229)

* enabling disabled tests

* updating test category as CheckinTests. Fixed the cmdlet directory path to be included while running static analysis on test cmdlet assembly

Author: shahabhijeet

tools/StaticAnalysis/StaticAnalysis.Test/SignatureVerifierTests.cs

@@ -9,6 +9,7 @@ namespace StaticAnalysis.Test
     using Xunit;
     using System.Linq;
     using StaticAnalysis.ProblemIds;
+    using System.Reflection;
 
     /// <summary>
     /// Add a way to send filterDirectory, FiltercmdLets delegates to the analyze method.
@@ -20,30 +21,31 @@ namespace StaticAnalysis.Test
     /// </summary>
     public class SignatureVerifierTests
     {
-        string testCmdletDirPath, exceptionsDirPath;
+        string _testCmdletDirPath, _exceptionsDirPath;
         SignatureVerifier.SignatureVerifier cmdletSignatureVerifier;
         AnalysisLogger analysisLogger;
 
         public SignatureVerifierTests()
         {
-            testCmdletDirPath = System.Environment.CurrentDirectory;
-            exceptionsDirPath = Path.Combine(testCmdletDirPath, "Exceptions");
+            _testCmdletDirPath = Path.GetDirectoryName(new Uri(Assembly.GetExecutingAssembly().CodeBase).AbsolutePath);
+            _exceptionsDirPath = Path.Combine(_testCmdletDirPath, "Exceptions");
 
-            analysisLogger = new AnalysisLogger(testCmdletDirPath, exceptionsDirPath);
+            analysisLogger = new AnalysisLogger(_testCmdletDirPath, _exceptionsDirPath);
             cmdletSignatureVerifier = new StaticAnalysis.SignatureVerifier.SignatureVerifier();
             cmdletSignatureVerifier.Logger = analysisLogger;
         }
 
         #region Verb Cmdlets and SupportsShouldProcess
         /// <summary>
         /// 
-        /// </summary>
-        [Fact(Skip = "See Azure PowerShell issue #2987 - https://github.com/Azure/azure-powershell/issues/2987")]
+        /// </summary>        
+        [Fact]
+        [Trait(Category.AcceptanceType, Category.CheckIn)]
         public void AddVerbWithoutSupportsShouldProcessParameter()
         {
             cmdletSignatureVerifier.Analyze(
-                new List<string> { Environment.CurrentDirectory },
-                ((dirList) => { return new List<string> { Environment.CurrentDirectory }; }),
+                new List<string> { _testCmdletDirPath},
+                ((dirList) => { return new List<string> { _testCmdletDirPath}; }),
                 (cmdletName) => cmdletName.Equals("Add-AddVerbWithoutSupportsShouldProcessParameter", StringComparison.OrdinalIgnoreCase));
 
             AnalysisReport testReport = cmdletSignatureVerifier.GetAnalysisReport();
@@ -53,11 +55,12 @@ public void AddVerbWithoutSupportsShouldProcessParameter()
         }
 
         [Fact]
+        [Trait(Category.AcceptanceType, Category.CheckIn)]
         public void AddVerbWithSupportsShouldProcessParameter()
         {   
             cmdletSignatureVerifier.Analyze(
-                new List<string> { Environment.CurrentDirectory },
-                ((dirList) => { return new List<string> { Environment.CurrentDirectory }; }),
+                new List<string> { _testCmdletDirPath},
+                ((dirList) => { return new List<string> { _testCmdletDirPath}; }),
                 (cmdletName) => cmdletName.Equals("Add-AddVerbWithSupportsShouldProcessParameter", StringComparison.OrdinalIgnoreCase));
 
             AnalysisReport testReport = cmdletSignatureVerifier.GetAnalysisReport();
@@ -67,26 +70,31 @@ public void AddVerbWithSupportsShouldProcessParameter()
         #endregion
 
         #region ForceSwitch and SupportsShouldProcess
-
-        [Fact(Skip = "See Azure PowerShell issue #2987 - https://github.com/Azure/azure-powershell/issues/2987")]
+                
+        [Fact]
+        [Trait(Category.AcceptanceType, Category.CheckIn)]
         public void ForceParameterWithoutSupportsShouldProcess()
         {
             cmdletSignatureVerifier.Analyze(
-                new List<string> { Environment.CurrentDirectory },
-                ((dirList) => { return new List<string> { Environment.CurrentDirectory }; }),
+                new List<string> { _testCmdletDirPath },
+                ((dirList) => { return new List<string> { _testCmdletDirPath}; }),
                 (cmdletName) => cmdletName.Equals("Test-ForceParameterWithoutSupportsShouldProcess", StringComparison.OrdinalIgnoreCase));
 
+            analysisLogger.Info("Foo");
+
+
             AnalysisReport testReport = cmdletSignatureVerifier.GetAnalysisReport();
             Assert.True(testReport.ProblemIdList.Count == 1);
             Assert.True(testReport.ProblemIdList.Where<int>((problemId) => problemId.Equals(SignatureProblemId.ForceWithoutShouldProcessAttribute)).SingleOrDefault<int>().Equals(SignatureProblemId.ForceWithoutShouldProcessAttribute));
         }
 
         [Fact]
+        [Trait(Category.AcceptanceType, Category.CheckIn)]
         public void ForceParameterWithSupportsShouldProcess()
         {
             cmdletSignatureVerifier.Analyze(
-                new List<string> { Environment.CurrentDirectory },
-                ((dirList) => { return new List<string> { Environment.CurrentDirectory }; }),
+                new List<string> { _testCmdletDirPath },
+                ((dirList) => { return new List<string> { _testCmdletDirPath}; }),
                 (cmdletName) => cmdletName.Equals("Test-ForceParameterWithSupportsShouldProcess", StringComparison.OrdinalIgnoreCase));
 
             AnalysisReport testReport = cmdletSignatureVerifier.GetAnalysisReport();
@@ -97,23 +105,25 @@ public void ForceParameterWithSupportsShouldProcess()
 
         #region ConfirmImpact and SupportsShouldProcess
         [Fact]
+        [Trait(Category.AcceptanceType, Category.CheckIn)]
         public void ConfirmImpactWithSupportsShouldProcess()
         {
             cmdletSignatureVerifier.Analyze(
-                new List<string> { Environment.CurrentDirectory },
-                ((dirList) => { return new List<string> { Environment.CurrentDirectory }; }),
+                new List<string> { _testCmdletDirPath },
+                ((dirList) => { return new List<string> { _testCmdletDirPath}; }),
                 (cmdletName) => cmdletName.Equals("Test-ConfirmImpactWithSupportsShouldProcess", StringComparison.OrdinalIgnoreCase));
 
             AnalysisReport testReport = cmdletSignatureVerifier.GetAnalysisReport();
             Assert.True(testReport.ProblemIdList.Count == 0);
         }
-
-        [Fact(Skip = "See Azure PowerShell issue #2987 - https://github.com/Azure/azure-powershell/issues/2987")]
+        
+        [Fact]
+        [Trait(Category.AcceptanceType, Category.CheckIn)]
         public void ConfirmImpactWithoutSupportsShouldProcess()
         {
             cmdletSignatureVerifier.Analyze(
-                new List<string> { Environment.CurrentDirectory },
-                ((dirList) => { return new List<string> { Environment.CurrentDirectory }; }),
+                new List<string> { _testCmdletDirPath },
+                ((dirList) => { return new List<string> { _testCmdletDirPath}; }),
                 (cmdletName) => cmdletName.Equals("Test-ConfirmImpactWithoutSupportsShouldProcess", StringComparison.OrdinalIgnoreCase));
 
             AnalysisReport testReport = cmdletSignatureVerifier.GetAnalysisReport();
@@ -125,23 +135,25 @@ public void ConfirmImpactWithoutSupportsShouldProcess()
 
         #region IsShouldContinueVerb and ForceSwitch
         [Fact]
+        [Trait(Category.AcceptanceType, Category.CheckIn)]
         public void ShouldContinueVerbWithForceSwitch()
         {
             cmdletSignatureVerifier.Analyze(
-                new List<string> { Environment.CurrentDirectory },
-                ((dirList) => { return new List<string> { Environment.CurrentDirectory }; }),
+                new List<string> { _testCmdletDirPath },
+                ((dirList) => { return new List<string> { _testCmdletDirPath}; }),
                 (cmdletName) => cmdletName.Equals("Copy-ShouldContinueVerbWithForceSwitch", StringComparison.OrdinalIgnoreCase));
 
             AnalysisReport testReport = cmdletSignatureVerifier.GetAnalysisReport();
             Assert.True(testReport.ProblemIdList.Count == 0);
         }
-
-        [Fact(Skip = "See Azure PowerShell issue #2987 - https://github.com/Azure/azure-powershell/issues/2987")]
+                
+        [Fact]
+        [Trait(Category.AcceptanceType, Category.CheckIn)]
         public void ShouldContinueVerbWithoutForceSwitch()
         {
             cmdletSignatureVerifier.Analyze(
-                new List<string> { Environment.CurrentDirectory },
-                ((dirList) => { return new List<string> { Environment.CurrentDirectory }; }),
+                new List<string> { _testCmdletDirPath },
+                ((dirList) => { return new List<string> { _testCmdletDirPath}; }),
                 (cmdletName) => cmdletName.Equals("Export-ShouldContinueVerbWithoutForceSwitch", StringComparison.OrdinalIgnoreCase));
 
             AnalysisReport testReport = cmdletSignatureVerifier.GetAnalysisReport();