Remove provisioning state from getdeployment

Author: vivsriaus

src/ResourceManager/Resources/Commands.Resources/Models.ResourceGroups/ResourceClient.ResourceManager.cs

@@ -457,23 +457,14 @@ public virtual List<PSResourceGroupDeployment> FilterResourceGroupDeployments(Fi
             List<PSResourceGroupDeployment> deployments = new List<PSResourceGroupDeployment>();
             string resourceGroup = options.ResourceGroupName;
             string name = options.DeploymentName;
-            List<string> excludedProvisioningStates = options.ExcludedProvisioningStates ?? new List<string>();
-            List<string> provisioningStates = options.ProvisioningStates ?? new List<string>();
 
             if (!string.IsNullOrEmpty(resourceGroup) && !string.IsNullOrEmpty(name))
             {
                 deployments.Add(ResourceManagementClient.Deployments.Get(resourceGroup, name).ToPSResourceGroupDeployment(options.ResourceGroupName));
             }
             else if (!string.IsNullOrEmpty(resourceGroup))
             {
-                DeploymentListParameters parameters = new DeploymentListParameters();
-
-                if (provisioningStates.Count == 1)
-                {
-                    parameters.ProvisioningState = provisioningStates.First();
-                }
-
-                DeploymentListResult result = ResourceManagementClient.Deployments.List(resourceGroup, parameters);
+                DeploymentListResult result = ResourceManagementClient.Deployments.List(resourceGroup, null);
 
                 deployments.AddRange(result.Deployments.Select(d => d.ToPSResourceGroupDeployment(options.ResourceGroupName)));
 
@@ -484,20 +475,7 @@ public virtual List<PSResourceGroupDeployment> FilterResourceGroupDeployments(Fi
                 }
             }
 
-            if (provisioningStates.Count > 1)
-            {
-                return deployments.Where(d => provisioningStates
-                    .Any(s => s.Equals(d.ProvisioningState, StringComparison.OrdinalIgnoreCase))).ToList();
-            }
-            else if (provisioningStates.Count == 0 && excludedProvisioningStates.Count > 0)
-            {
-                return deployments.Where(d => excludedProvisioningStates
-                    .All(s => !s.Equals(d.ProvisioningState, StringComparison.OrdinalIgnoreCase))).ToList();
-            }
-            else
-            {
-                return deployments;
-            }
+            return deployments;
         }
 
         /// <summary>

src/ResourceManager/Resources/Commands.Resources/ResourceGroupDeployments/GetAzureResourceGroupDeploymentCommand.cs

@@ -44,10 +44,6 @@ public class GetAzureResourceGroupDeploymentCommand : ResourcesBaseCmdlet
         [ValidateNotNullOrEmpty]
         public string Name { get; set; }
 
-        [Parameter(Mandatory = false, HelpMessage = "The provisioning state of the resource group deployment.")]
-        [ValidateNotNullOrEmpty]
-        public string ProvisioningState { get; set; }
-
         [Alias("DeploymentId", "ResourceId")]
         [Parameter(ParameterSetName = GetAzureResourceGroupDeploymentCommand.DeploymentIdParameterSet, Mandatory = true, HelpMessage = "The fully qualified resource Id of the deployment. example: /subscriptions/{subId}/resourceGroups/{rgName}/providers/Microsoft.Resources/deployments/{deploymentName}")]
         [ValidateNotNullOrEmpty]
@@ -58,15 +54,9 @@ protected override void ProcessRecord()
             FilterResourceGroupDeploymentOptions options = new FilterResourceGroupDeploymentOptions()
             {
                 ResourceGroupName = ResourceGroupName ?? ResourceIdUtility.GetResourceGroupName(Id),
-                DeploymentName = Name ?? (string.IsNullOrEmpty(Id) ? null : ResourceIdUtility.GetResourceName(Id)),
-                ProvisioningStates = string.IsNullOrEmpty(ProvisioningState) ? new List<string>() : 
-                    new List<string>() { ProvisioningState }
+                DeploymentName = Name ?? (string.IsNullOrEmpty(Id) ? null : ResourceIdUtility.GetResourceName(Id))
             };
 
-            if(!string.IsNullOrEmpty(ProvisioningState))
-            {
-                WriteWarning("The ProvisioningState parameter is being deprecated and will be removed in a future release.");
-            }
             WriteObject(ResourcesClient.FilterResourceGroupDeployments(options), true);
         }
     }