Skip to content

Commit 6ea2093

Browse files
committed
Merge pull request #261 from MabOneSdk/pragrawa-dev1
Bug Fix for get-item
2 parents 9a3b8ed + 1880294 commit 6ea2093

File tree

2 files changed

+11
-10
lines changed
  • src/ResourceManager/RecoveryServices.Backup

2 files changed

+11
-10
lines changed

src/ResourceManager/RecoveryServices.Backup/Commands.RecoveryServices.Backup.Providers/Providers/IaasVmPsBackupProvider.cs

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -439,15 +439,16 @@ public List<AzureRmRecoveryServicesBackupItemBase> ListProtectedItems()
439439
}
440440
} while (skipToken != null);
441441

442-
List<AzureRmRecoveryServicesBackupItemBase> itemModels = ConversionHelpers.GetItemModelList(protectedItems, container);
443-
444442
// 1. Filter by container
445-
itemModels = itemModels.Where(itemModel =>
443+
protectedItems = protectedItems.Where(protectedItem =>
446444
{
447-
// return itemModel.ContainerName == container.Name;
448-
return container.Name.Contains(itemModel.ContainerName);
445+
Dictionary<UriEnums, string> dictionary = HelperUtils.ParseUri(protectedItem.Id);
446+
string containerUri = HelperUtils.GetContainerUri(dictionary, protectedItem.Id);
447+
return containerUri.Contains(container.Name);
449448
}).ToList();
450449

450+
List<AzureRmRecoveryServicesBackupItemBase> itemModels = ConversionHelpers.GetItemModelList(protectedItems, container);
451+
451452
// 2. Filter by item's friendly name
452453
if (!string.IsNullOrEmpty(name))
453454
{

src/ResourceManager/RecoveryServices.Backup/Commands.RecoveryServices.Backup.Test/ScenarioTests/IaasVm/ItemTests.ps1

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ function Test-GetItemScenario
1717
$vault = Get-AzureRmRecoveryServicesVault -ResourceGroupName "phaniktRSV" -Name "phaniktRs1";
1818
Set-AzureRmRecoveryServicesVaultContext -Vault $vault;
1919

20-
$namedContainer = Get-AzureRmRecoveryServicesContainer -ContainerType "AzureVM" -Status "Registered" -Name "mylinux1";
20+
$namedContainer = Get-AzureRmRecoveryServicesBackupContainer -ContainerType "AzureVM" -Status "Registered" -Name "mylinux1";
2121
Assert-AreEqual $namedContainer.FriendlyName "mylinux1";
2222

2323
$item = Get-AzureRmRecoveryServicesBackupItem -Container $namedContainer -WorkloadType "AzureVM";
@@ -29,7 +29,7 @@ function Test-EnableAzureVMProtectionScenario
2929
$vault = Get-AzureRmRecoveryServicesVault -ResourceGroupName "phaniktRSV" -Name "phaniktRs1";
3030
Set-AzureRmRecoveryServicesVaultContext -Vault $vault;
3131

32-
$policy = Get-AzureRmRecoveryServicesProtectionPolicy -Name "pwtest1"
32+
$policy = Get-AzureRmRecoveryServicesBackupProtectionPolicy -Name "pwtest1"
3333

3434
$job = Enable-AzureRmRecoveryServicesBackupProtection -Name "mylinux1" -ResourceGroupName "mylinux1" -WorkloadType "AzureVM" -Policy $policy;
3535
Assert-AreEqual $job.Status "Completed";
@@ -56,7 +56,7 @@ function Test-GetAzureVMRecoveryPointsScenario
5656
$vault = Get-AzureRmRecoveryServicesVault -ResourceGroupName "phaniktRSV" -Name "phaniktRs1";
5757
Set-AzureRmRecoveryServicesVaultContext -Vault $vault;
5858

59-
$namedContainer = Get-AzureRmRecoveryServicesContainer -ContainerType "AzureVM" -Status "Registered" -Name "mylinux1";
59+
$namedContainer = Get-AzureRmRecoveryServicesBackupContainer -ContainerType "AzureVM" -Status "Registered" -Name "mylinux1";
6060
Assert-AreEqual $namedContainer.FriendlyName "mylinux1";
6161

6262
$item = Get-AzureRmRecoveryServicesBackupItem -Container $namedContainer -WorkloadType "AzureVM";
@@ -72,7 +72,7 @@ function Test-RestoreAzureVMRItemScenario
7272
$vault = Get-AzureRmRecoveryServicesVault -ResourceGroupName "phaniktRSV" -Name "phaniktRs1";
7373
Set-AzureRmRecoveryServicesVaultContext -Vault $vault;
7474

75-
$namedContainer = Get-AzureRmRecoveryServicesContainer -ContainerType "AzureVM" -Status "Registered" -Name "mylinux1";
75+
$namedContainer = Get-AzureRmRecoveryServicesBackupContainer -ContainerType "AzureVM" -Status "Registered" -Name "mylinux1";
7676
Assert-AreEqual $namedContainer.FriendlyName "mylinux1";
7777

7878
$item = Get-AzureRmRecoveryServicesBackupItem -Container $namedContainer -WorkloadType "AzureVM";
@@ -90,7 +90,7 @@ function Test-BackupItemScenario
9090
$vault = Get-AzureRmRecoveryServicesVault -ResourceGroupName "pstestrg" -Name "pstestrsvault";
9191
Set-AzureRmRecoveryServicesVaultContext -Vault $vault;
9292

93-
$namedContainer = Get-AzureRmRecoveryServicesContainer -ContainerType "AzureVM" -Status "Registered" -Name "pstestv2vm1";
93+
$namedContainer = Get-AzureRmRecoveryServicesBackupContainer -ContainerType "AzureVM" -Status "Registered" -Name "pstestv2vm1";
9494
Assert-AreEqual $namedContainer.FriendlyName "pstestv2vm1";
9595

9696
$item = Get-AzureRmRecoveryServicesBackupItem -Container $namedContainer -WorkloadType "AzureVM";

0 commit comments

Comments
 (0)