Merge pull request #361 from ajinkyapotdarvjti/net440fix

Nullify default NetworkSecurityRules if absent

Author: markcowl

src/ResourceManager/Network/Commands.Network/NetworkSecurityGroup/NetworkSecurityGroupBaseCmdlet.cs

@@ -18,6 +18,8 @@
 using Microsoft.Azure.Commands.ResourceManager.Common.Tags;
 using Microsoft.Azure.Management.Network;
 using System.Net;
+using System.Collections;
+using System.Collections.Generic;
 using Microsoft.Azure.Management.Network.Models;
 
 namespace Microsoft.Azure.Commands.Network
@@ -67,24 +69,35 @@ public PSNetworkSecurityGroup GetNetworkSecurityGroup(string resourceGroupName,
 		// Temporary - to be removed
 		public void NullifyApplicationSecurityGroupsIfAbsent(NetworkSecurityGroup nsg)
 		{
-			if (nsg ==null || nsg.SecurityRules == null)
+			if (nsg == null)
 			{
 				return;
 			}
 
-			foreach (var rule in nsg.SecurityRules)
-			{
-				if (rule.SourceApplicationSecurityGroups != null && rule.SourceApplicationSecurityGroups.Count == 0)
-				{
-					rule.SourceApplicationSecurityGroups = null;
-				}
-
-				if (rule.DestinationApplicationSecurityGroups != null && rule.DestinationApplicationSecurityGroups.Count == 0)
-				{
-					rule.DestinationApplicationSecurityGroups = null;
-				}
-			}
-		}
+            this.NullifyApplicationSecurityRulesIfAbsent(nsg.DefaultSecurityRules);
+            this.NullifyApplicationSecurityRulesIfAbsent(nsg.SecurityRules);
+        }
+
+        public void NullifyApplicationSecurityRulesIfAbsent(IList<SecurityRule> rules)
+        {
+            if (rules == null)
+            {
+                return;
+            }
+
+            foreach (var rule in rules)
+            {
+                if (rule.SourceApplicationSecurityGroups != null && rule.SourceApplicationSecurityGroups.Count == 0)
+                {
+                    rule.SourceApplicationSecurityGroups = null;
+                }
+
+                if (rule.DestinationApplicationSecurityGroups != null && rule.DestinationApplicationSecurityGroups.Count == 0)
+                {
+                    rule.DestinationApplicationSecurityGroups = null;
+                }
+            }
+        }
 
         public PSNetworkSecurityGroup ToPsNetworkSecurityGroup(NetworkSecurityGroup nsg)
         {