PR comment

Author: mkherani

src/ResourceManager/RecoveryServices.Backup/Commands.RecoveryServices.Backup.HydraAdapter/BMSAPIs/RecoveryPointsAPIs.cs

@@ -23,13 +23,7 @@ namespace Microsoft.Azure.Commands.RecoveryServices.Backup.Cmdlets.HydraAdapterN
 {
     public partial class HydraAdapter
     {
-        /// <summary>
-        /// Fetch the details of given Recovery point
-        /// </summary>
-        /// <param name="containerName"></param>
-        /// <param name="protectedItemName"></param>
-        /// <param name="recoveryPointId"></param>
-        /// <returns></returns>
+        
         public RecoveryPointResponse GetRecoveryPointDetails(string containerName, string protectedItemName, string recoveryPointId)
         {
             string resourceGroupName = BmsAdapter.GetResourceGroupName();
@@ -41,15 +35,7 @@ public RecoveryPointResponse GetRecoveryPointDetails(string containerName, strin
             return response;
         }
 
-        /// <summary>
-        /// Fetch the Recovery points of protectedItem which satisfy specified query
-        /// </summary>
-        /// <param name="resourceGroupName"></param>
-        /// <param name="resourceName"></param>
-        /// <param name="containerName"></param>
-        /// <param name="protectedItemName"></param>
-        /// <param name="queryFilter"></param>
-        /// <returns></returns>
+        
         public RecoveryPointListResponse GetRecoveryPoints(string containerName, string protectedItemName, RecoveryPointQueryParameters queryFilter)
         {
             string resourceGroupName = BmsAdapter.GetResourceGroupName();

src/ResourceManager/RecoveryServices.Backup/Commands.RecoveryServices.Backup.HydraAdapter/BMSAPIs/RestoreDiskAPIs.cs

@@ -11,15 +11,7 @@ namespace Microsoft.Azure.Commands.RecoveryServices.Backup.Cmdlets.HydraAdapterN
 {
     public partial class HydraAdapter
     {
-        /// <summary>
-        /// Restore the given Recovery point of protectedItem to given storage account
-        /// </summary>
-        /// <param name="resourceGroupName"></param>
-        /// <param name="resourceName"></param>
-        /// <param name="containerName"></param>
-        /// <param name="protectedItemName"></param>
-        /// <param name="recoveryPointId"></param>
-        /// <returns></returns>
+        
         public BaseRecoveryServicesJobResponse RestoreDisk(AzureRmRecoveryServicesBackupIaasVmRecoveryPoint rp, string storageAccountId, 
             string storageAccountLocation, string storageAccountType)
         {

src/ResourceManager/RecoveryServices.Backup/Commands.RecoveryServices.Backup/CmdletParameterHelpMessages.cs

@@ -74,6 +74,7 @@ internal static class Item
             public const string Container = "Container where the item resides";
             public const string RemoveProtectionOption = "If this option is used, all the backup data for this item will also be deleted and restoring data will not be possible.";
             public const string ExpiryDate = "Retention period for the recovery points created by this backup operaiton";
+            public const string ForceOption = "Force disables backup protection (prevents confirmation dialog). This parameter is optional.";
         }
 
         internal static class RecoveryPoint

src/ResourceManager/RecoveryServices.Backup/Commands.RecoveryServices.Backup/Cmdlets/Item/DisableAzureRmRecoveryServicesProtection.cs

@@ -44,7 +44,7 @@ public SwitchParameter RemoveRecoveryPoints
             set { DeleteBackupData = value; }
         }
 
-        [Parameter(Mandatory = false, HelpMessage = "Don't ask for confirmation.")]
+        [Parameter(Mandatory = false, HelpMessage = ParamHelpMsg.Item.ForceOption)]
         public SwitchParameter Force { get; set; }
 
         private bool DeleteBackupData;

src/ResourceManager/RecoveryServices.Backup/Commands.RecoveryServices.Backup/Cmdlets/Restore/RestoreAzureRMRecoveryServicesBackupItem.cs

@@ -94,47 +94,5 @@ public override void ExecuteCmdlet()
                 HandleCreatedJob(jobResponse, Resources.RestoreOperation);
             });
         }
-
-        /// <summary>
-        /// This code is not getting used. Will delete it once things will be closed.
-        /// </summary>
-        /// <param name="storageAccountName"></param>
-        /// <param name="id"></param>
-        /// <param name="location"></param>
-        /// <param name="resourceType"></param>
-        internal void GetStorageResource(string storageAccountName, out string id, out string location, out string resourceType)
-        {
-            using (System.Management.Automation.PowerShell ps = System.Management.Automation.PowerShell.Create())
-            {
-                //Get-AzureRmResource | Where-Object { ($_.Name -eq "<StorageAccName>") -and ($_.ResourceType -eq "Microsoft.Storage/storageAccounts" -or $_.ResourceType -eq "Microsoft.ClassicStorage/storageAccounts")}
-                ps.AddCommand("Get-AzureRmResource");
-                ps.AddCommand("where-object");
-                string filterString = String.Format(@"($_.Name -eq ""{0}"") -and ($_.ResourceType -eq ""Microsoft.Storage/storageAccounts"" -or $_.ResourceType -eq ""Microsoft.ClassicStorage/storageAccounts"")");
-                ScriptBlock filter = ScriptBlock.Create(filterString);
-
-                ps.AddParameter("FilterScript", filter);                
-                var result = ps.Invoke();
-
-                if (ps.HadErrors)
-                {
-                    WriteVerbose(string.Format("Error in Get-AzureRmResource"));
-                    throw new Exception(ps.HadErrors.ToString());
-                }
-
-                if(result.Count == 0)
-                {
-                    WriteVerbose(string.Format("Storage Account not fount"));
-                    throw new ArgumentException(Resources.RestoreAzureStorageNotFound);
-                }
-                else if (result.Count > 1)
-                {
-                    WriteVerbose(string.Format("Found more than one StorageAccount with same name. Some thing went wrong"));
-                    throw new Exception(Resources.RestoreDiskMoreThanOneAccFound);
-                }
-                id = result[0].Members["ResourceId"].Value.ToString();
-                location = result[0].Members["Location"].Value.ToString();
-                resourceType = result[0].Members["ResourceType"].Value.ToString();
-            }
-        }
     }
 }