remove nic param in GetEffective cmdlets

Author: DeepakRajendranMsft

src/ResourceManager/Compute/Commands.Compute.Test/ScenarioTests/VirtualMachineNetworkInterfaceTests.ps1

@@ -583,15 +583,7 @@ function Test-EffectiveRoutesAndNsg
 		Assert-NotNull $effectiveRoute[0].Source
 
         # Get Effective NSG by name
-        $effectiveNsgs = Get-AzureRmEffectiveNetworkSecurityGroup -ResourceGroupName $rgname -NetworkInterfaceName $getnic.Name
-
-		# Get Effective route by object
-        $effectiveRoute = Get-AzureRmEffectiveRouteTable -NetworkInterface $getnic
-		Assert-NotNull $effectiveRoute[0].Source
-
-        # Get Effective NSG by object
-        $effectiveNsgs = Get-AzureRmEffectiveNetworkSecurityGroup -NetworkInterface $getnic
-        
+        $effectiveNsgs = Get-AzureRmEffectiveNetworkSecurityGroup -ResourceGroupName $rgname -NetworkInterfaceName $getnic.Name       
     }
     finally
     {

src/ResourceManager/Network/Commands.Network/NetworkInterface/EffectiveResources/GetAzureEffectiveNetworkSecurityGroupCommand.cs

@@ -26,23 +26,13 @@ public class GetAzureEffectiveNetworkSecurityGroupCommand : NetworkInterfaceBase
         [Parameter(
            Mandatory = true,
            ValueFromPipelineByPropertyName = true,
-           ParameterSetName = "GetByResourceObject",
-           HelpMessage = "The network interface.")]
-        [ValidateNotNullOrEmpty]
-        public PSNetworkInterface NetworkInterface { get; set; }
-
-        [Parameter(
-           Mandatory = true,
-           ValueFromPipelineByPropertyName = true,
-           ParameterSetName = "GetByResourceName",
            HelpMessage = "The network interface name.")]
         [ValidateNotNullOrEmpty]
         public string NetworkInterfaceName { get; set; }
 
         [Parameter(
             Mandatory = false,
             ValueFromPipelineByPropertyName = true,
-            ParameterSetName = "GetByResourceName",
             HelpMessage = "The resource group name.")]
         [ValidateNotNullOrEmpty]
         public string ResourceGroupName { get; set; }
@@ -51,12 +41,6 @@ public override void Execute()
         {
             base.Execute();
 
-            if (ParameterSetName.Contains("GetByResourceObject"))
-            {
-                this.NetworkInterfaceName = this.NetworkInterface.Name;
-                this.ResourceGroupName = this.NetworkInterface.ResourceGroupName;
-            }
-
             var getEffectiveNsgs = this.NetworkInterfaceClient.ListEffectiveNetworkSecurityGroups(this.ResourceGroupName, this.NetworkInterfaceName);
 
             var psEffectiveNsgs = Mapper.Map<List<PSEffectiveNetworkSecurityGroup>>(getEffectiveNsgs.Value);

src/ResourceManager/Network/Commands.Network/NetworkInterface/EffectiveResources/GetAzureEffectiveRouteTableCommand.cs

@@ -26,23 +26,13 @@ public class GetAzureEffectiveRouteTableCommand : NetworkInterfaceBaseCmdlet
         [Parameter(
            Mandatory = true,
            ValueFromPipelineByPropertyName = true,
-           ParameterSetName = "GetByResourceObject",
-           HelpMessage = "The network interface.")]
-        [ValidateNotNullOrEmpty]
-        public PSNetworkInterface NetworkInterface { get; set; }
-
-        [Parameter(
-           Mandatory = true,
-           ValueFromPipelineByPropertyName = true,
-           ParameterSetName = "GetByResourceName",
            HelpMessage = "The network interface name.")]
         [ValidateNotNullOrEmpty]
         public string NetworkInterfaceName { get; set; }
 
         [Parameter(
             Mandatory = false,
             ValueFromPipelineByPropertyName = true,
-            ParameterSetName = "GetByResourceName",
             HelpMessage = "The resource group name.")]
         [ValidateNotNullOrEmpty]
         public string ResourceGroupName { get; set; }
@@ -51,12 +41,6 @@ public override void Execute()
         {
             base.Execute();
 
-            if (ParameterSetName.Contains("GetByResourceObject"))
-            {
-                this.NetworkInterfaceName = this.NetworkInterface.Name;
-                this.ResourceGroupName = this.NetworkInterface.ResourceGroupName;
-            }
-
             var getEffectiveRouteTable = this.NetworkInterfaceClient.GetEffectiveRouteTable(this.ResourceGroupName, this.NetworkInterfaceName);
 
             var psEffectiveRouteTable = Mapper.Map<List<PSEffectiveRoute>>(getEffectiveRouteTable.Value);