Skip to content

Commit 8b6c206

Browse files
committed
minor fix as per PR comments
1 parent 13edbe5 commit 8b6c206

File tree

2 files changed

+12
-5
lines changed

2 files changed

+12
-5
lines changed

src/ResourceManager/RecoveryServices/Commands.RecoveryServices/Common/PSRecoveryServicesVaultExtendedInfoClient.cs

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -128,8 +128,9 @@ public ASRVaultCreds GenerateVaultCredential(X509Certificate2 managementCert, AR
128128
/// <summary>
129129
/// Upload cert to idmgmt
130130
/// </summary>
131-
/// <param name="managementCert"></param>
132-
/// <returns></returns>
131+
/// <param name="managementCert">certificate to be uploaded</param>
132+
/// <param name="vault">vault object</param>
133+
/// <returns>Upload Certificate Response</returns>
133134
public UploadCertificateResponse UploadCertificate(X509Certificate2 managementCert, ARSVault vault)
134135
{
135136
var certificateArgs = new CertificateArgs();

src/ResourceManager/RecoveryServices/Commands.RecoveryServices/Vault/GetAzureRMRecoveryServicesVaultSettingsFile.cs

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -32,8 +32,8 @@ namespace Microsoft.Azure.Commands.RecoveryServices
3232
/// Retrieves Azure Recovery Services Vault Settings File.
3333
/// </summary>
3434
[Cmdlet(VerbsCommon.Get, "AzureRmRecoveryServicesVaultSettingsFile")]
35-
[OutputType(typeof(VaultSettingsFilePath), typeof(string))]
36-
public partial class GetAzureRmRecoveryServicesVaultSettingsFile : RecoveryServicesCmdletBase
35+
[OutputType(typeof(VaultSettingsFilePath))]
36+
public class GetAzureRmRecoveryServicesVaultSettingsFile : RecoveryServicesCmdletBase
3737
{
3838
/// <summary>
3939
/// Expiry in hours for generated certificate.
@@ -192,6 +192,9 @@ private string GenerateFileName()
192192
}
193193

194194
#region Backup Vault Credentials
195+
/// <summary>
196+
/// Get vault credentials for backup vault type.
197+
/// </summary>
195198
public void GetAzureRMRecoveryServicesVaultBackupCredentials()
196199
{
197200
string targetLocation = string.IsNullOrEmpty(this.Path) ? Utilities.GetDefaultPath() : this.Path;
@@ -253,7 +256,6 @@ public void GetAzureRMRecoveryServicesVaultBackupCredentials()
253256
/// Upload certificate
254257
/// </summary>
255258
/// <param name="cert">management certificate</param>
256-
/// <param name="subscriptionId">subscription Id</param>
257259
/// <returns>acs namespace of the uploaded cert</returns>
258260
private AcsNamespace UploadCert(X509Certificate2 cert)
259261
{
@@ -309,6 +311,10 @@ private string GenerateVaultCredsForBackup(X509Certificate2 cert, string subscri
309311
}
310312
}
311313

314+
/// <summary>
315+
/// Get Agent Links
316+
/// </summary>
317+
/// <returns>Agent links in string format</returns>
312318
private static string GetAgentLinks()
313319
{
314320
return "WABUpdateKBLink,http://go.microsoft.com/fwlink/p/?LinkId=229525;" +

0 commit comments

Comments
 (0)