No public access to Info.

Author: sergey-shandar

experiments/Azure.Experiments/Azure.Experiments/AzureObject.cs

@@ -24,23 +24,29 @@ public abstract class AzureObject
         /// object and its dependencies.
         /// </summary>
         /// <returns></returns>
-        public abstract string GetInfoLocation();
+        public abstract Task<string> GetInfoLocationAsync();
 
         /// <summary>
         /// The function should be called only after GetInfo is called for the 
         /// object and its dependencies.
         /// </summary>
         /// <returns></returns>
-        public DependencyLocation GetDependencyLocation()
+        public async Task<DependencyLocation> GetDependencyLocationAsync()
         {
-            var location = GetInfoLocation();
-            return location != null
-                ? new DependencyLocation(location, Priority)
-                : Dependencies
-                    .Select(d => GetDependencyLocation())
-                    .Aggregate(
-                        DependencyLocation.None,
-                        (a, b) => a.Priority > b.Priority ? a : b);
+            if (DependencyLocation == null)
+            {
+                var location = await GetInfoLocationAsync();
+                if (location != null)
+                {
+                    return new DependencyLocation(location, Priority);
+                }
+                var taskList = Dependencies.Select(d => GetDependencyLocationAsync());
+                var dlList = await Task.WhenAll(taskList);
+                DependencyLocation = dlList.Aggregate(
+                    DependencyLocation.None,
+                    (a, b) => a.Priority > b.Priority ? a : b);
+            }
+            return DependencyLocation;
         }
 
         protected AzureObject(string name, IEnumerable<AzureObject> dependencies)
@@ -51,16 +57,18 @@ protected AzureObject(string name, IEnumerable<AzureObject> dependencies)
                 ? dependencies.Max(d => d.Priority) + 1 
                 : 1;
         }
+
+        private DependencyLocation DependencyLocation { get; set; }
     }
 
     public abstract class AzureObject<T, P> : AzureObject
         where T: class
         where P: struct, IInfoPolicy<T>
     {
-        public T Info { get; private set; }
+        private T Info { get; set; }
 
-        public override string GetInfoLocation()
-            => Info == null ? null : new P().GetLocation(Info);
+        public override async Task<string> GetInfoLocationAsync()
+            => await GetOrNullAsync() == null ? null : new P().GetLocation(Info);
 
         public async Task<T> GetOrNullAsync()
         {
@@ -98,8 +106,7 @@ public async Task<T> GetOrCreateAsync(string location)
 
         public async Task<T> GetOrCreateAsync()
         {
-            await GetOrNullAsync();
-            var dl = GetDependencyLocation();
+            var dl = await GetDependencyLocationAsync();
             var location = dl.Location ?? "eastus";
             return await GetOrCreateAsync(location);
         }

experiments/Azure.Experiments/Azure.Experiments/Compute/VirtualMachineObject.cs

@@ -27,18 +27,20 @@ public VirtualMachineObject(
             Ni = ni;
         }
 
-        protected override Task<VirtualMachine> CreateAsync(string location)
-            => Client.CreateOrUpdateAsync(
+        protected override async Task<VirtualMachine> CreateAsync(string location)
+        {
+            var ni = await Ni.GetOrNullAsync();
+            return await Client.CreateOrUpdateAsync(
                 ResourceGroupName,
                 Name,
                 new VirtualMachine
                 {
                     Location = "eastus",
                     OsProfile = new OSProfile
-                    {           
+                    {
                         ComputerName = Name,
                         WindowsConfiguration = new WindowsConfiguration
-                        {                            
+                        {
                         },
                         AdminUsername = AdminUsername,
                         AdminPassword = AdminPassword,
@@ -47,7 +49,7 @@ protected override Task<VirtualMachine> CreateAsync(string location)
                     {
                         NetworkInterfaces = new NetworkInterfaceReference[]
                         {
-                            new NetworkInterfaceReference(Ni.Info.Id)
+                            new NetworkInterfaceReference(ni.Id)
                         }
                     },
                     HardwareProfile = new HardwareProfile
@@ -63,8 +65,9 @@ protected override Task<VirtualMachine> CreateAsync(string location)
                             Sku = "2016-Datacenter",
                             Version = "latest"
                         }
-                    },                    
+                    },
                 });
+        }
 
         protected override Task<VirtualMachine> GetOrThrowAsync()
             => Client.GetAsync(ResourceGroupName, Name);

experiments/Azure.Experiments/Azure.Experiments/Network/NetworkInterfaceObject.cs

@@ -22,22 +22,26 @@ public NetworkInterfaceObject(
         }
 
         protected override async Task<NetworkInterface> CreateAsync(string location)
-            => await Client.CreateOrUpdateAsync(
+        {
+            var subnet = await Subnet.GetOrNullAsync();
+            var pia = await Pia.GetOrNullAsync();
+            return await Client.CreateOrUpdateAsync(
                 ResourceGroupName,
-                Name, 
+                Name,
                 new NetworkInterface
                 {
                     Location = location,
-                    IpConfigurations = new[] 
+                    IpConfigurations = new[]
                     {
                         new NetworkInterfaceIPConfiguration
                         {
                             Name = Name,
-                            Subnet = Subnet.Info,
-                            PublicIPAddress = Pia.Info,
+                            Subnet = subnet,
+                            PublicIPAddress = pia,
                         }
-                    }                    
+                    }
                 });
+        }
 
         protected override Task<NetworkInterface> GetOrThrowAsync()
             => Client.GetAsync(ResourceGroupName, Name);

experiments/Azure.Experiments/Azure.Experiments/Network/SubnetObject.cs

@@ -20,7 +20,7 @@ public SubnetObject(
         protected override async Task<Subnet> CreateAsync(string location)
         {
             // The Virtual Network should be created at this point.
-            var vn = Vn.Info;
+            var vn = await Vn.GetOrNullAsync();
             vn.Subnets.Add(new Subnet { Name = Name, AddressPrefix = AddressPrefix });
             vn = await Vn.Client.CreateOrUpdateAsync(
                 Vn.ResourceGroupName, Vn.Name, vn);