Skip to content

Commit 9f1d5bd

Browse files
committed
IconName & SmallIconName
1 parent 7c62529 commit 9f1d5bd

File tree

4 files changed

+36
-14
lines changed

4 files changed

+36
-14
lines changed

src/ServiceManagement/Compute/Commands.ServiceManagement.Test/FunctionalTests/VMTemplateTests.cs

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -558,7 +558,7 @@ public void UpdateVMImageDataDiskAndOsDiskTest()
558558
UpdateAzureVMImageDetails(vmImageName);
559559

560560
string disk1Name,disk2Name;
561-
UpdateVMImageOsAndDataDiskAnderifyChanges( diskConfig,out disk1Name,out disk2Name);
561+
UpdateVMImageOsAndDataDiskAnderifyChanges(diskConfig, out disk1Name, out disk2Name);
562562

563563
//Update VMImage using DiskConfig set prepared manually.
564564
UpdateVmImageUsingDiskConfigSetAndVerifyChanges(diskConfig, disk1Name, disk2Name);
@@ -709,7 +709,7 @@ private void UpdateAzureVMImageDetails(string imageName)
709709
Utilities.ExecuteAndLog(() =>
710710
{
711711
vmPowershellCmdlets.UpdateAzureVMImage(imageName, imageName, imageContext.ImageFamily, imageContext.ShowInGui.Value, imageContext.RecommendedVMSize, imageContext.Description, imageContext.Eula,
712-
imageContext.PrivacyUri, imageContext.PublishedDate, imageContext.Language, imageContext.IconUri, imageContext.SmallIconUri);
712+
imageContext.PrivacyUri, imageContext.PublishedDate, imageContext.Language, imageContext.IconName, imageContext.SmallIconName);
713713
}, "Update Azure VM Image details");
714714

715715
VerifyVMImageProperties(imageContext);
@@ -728,6 +728,7 @@ private void VerifyVMImageProperties(VMImageContext imageContext)
728728
Utilities.LogAssert(() => Assert.AreEqual(imageContext.Eula, vmImageContext.Eula), "Eula");
729729
Utilities.LogAssert(() => Assert.AreEqual(imageContext.Description, vmImageContext.Description), "Description");
730730
Utilities.LogAssert(() => Assert.AreEqual(imageContext.IconUri, vmImageContext.IconUri), "IconUri");
731+
Utilities.LogAssert(() => Assert.AreEqual(imageContext.IconName, vmImageContext.IconName), "IconName");
731732
Utilities.LogAssert(() => Assert.AreEqual(imageContext.ImageFamily, vmImageContext.ImageFamily), "ImageFamily");
732733
Utilities.LogAssert(() => Assert.AreEqual(imageContext.ImageName, vmImageContext.ImageName), "ImageName");
733734
Utilities.LogAssert(() => Assert.AreEqual(imageContext.Label, vmImageContext.Label), "Label");
@@ -737,6 +738,7 @@ private void VerifyVMImageProperties(VMImageContext imageContext)
737738
Utilities.LogAssert(() => Assert.AreEqual(imageContext.RecommendedVMSize, vmImageContext.RecommendedVMSize), "RecommendedVMSize");
738739
Utilities.LogAssert(() => Assert.AreEqual(imageContext.ShowInGui, vmImageContext.ShowInGui), "ShowInGui");
739740
Utilities.LogAssert(() => Assert.AreEqual(imageContext.SmallIconUri, vmImageContext.SmallIconUri), "SmallIconUri");
741+
Utilities.LogAssert(() => Assert.AreEqual(imageContext.SmallIconName, vmImageContext.SmallIconName), "SmallIconName");
740742
}, "Verify VM image details");
741743
}
742744

src/ServiceManagement/Compute/Commands.ServiceManagement/IaaS/DiskRepository/AddAzureVMImage.cs

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -75,11 +75,13 @@ public class AddAzureVMImage : ServiceManagementBaseCmdlet
7575
[Parameter(Position = 9, ValueFromPipelineByPropertyName = true, HelpMessage = " Specifies the size to use for the virtual machine that is created from the OS image.")]
7676
public string RecommendedVMSize { get; set; }
7777

78+
[Alias("IconUri")]
7879
[Parameter(Position = 10, ValueFromPipelineByPropertyName = true, HelpMessage = "Icon Uri.")]
79-
public string IconUri { get; set; }
80+
public string IconName { get; set; }
8081

82+
[Alias("SmallIconUri")]
8183
[Parameter(Position = 11, ValueFromPipelineByPropertyName = true, HelpMessage = "Small Icon Uri.")]
82-
public string SmallIconUri { get; set; }
84+
public string SmallIconName { get; set; }
8385

8486
[Parameter(Position = 12, ValueFromPipelineByPropertyName = true, HelpMessage = "To show in GUI.")]
8587
public SwitchParameter ShowInGui { get; set; }
@@ -116,8 +118,8 @@ protected override void OnProcessRecord()
116118
PublishedDate = this.PublishedDate,
117119
PrivacyUri = this.PrivacyUri,
118120
RecommendedVMSize = this.RecommendedVMSize,
119-
IconUri = this.IconUri,
120-
SmallIconUri = this.SmallIconUri,
121+
IconUri = this.IconName,
122+
SmallIconUri = this.SmallIconName,
121123
ShowInGui = this.ShowInGui
122124
};
123125

@@ -140,8 +142,8 @@ protected override void OnProcessRecord()
140142
PublishedDate = this.PublishedDate,
141143
PrivacyUri = this.PrivacyUri,
142144
RecommendedVMSize = this.RecommendedVMSize,
143-
IconUri = this.IconUri,
144-
SmallIconUri = this.SmallIconUri,
145+
IconUri = this.IconName,
146+
SmallIconUri = this.SmallIconName,
145147
ShowInGui = this.ShowInGui
146148
};
147149

src/ServiceManagement/Compute/Commands.ServiceManagement/IaaS/DiskRepository/UpdateAzureVMImage.cs

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -70,13 +70,15 @@ public class UpdateAzureVMImage : ServiceManagementBaseCmdlet
7070
[ValidateNotNullOrEmpty]
7171
public string Language { get; set; }
7272

73+
[Alias("IconUri")]
7374
[Parameter(Position = 10, ValueFromPipelineByPropertyName = true, HelpMessage = "IconUri.")]
7475
[ValidateNotNullOrEmpty]
75-
public string IconUri { get; set; }
76+
public string IconName { get; set; }
7677

78+
[Alias("SmallIconUri")]
7779
[Parameter(Position = 11, ValueFromPipelineByPropertyName = true, HelpMessage = "SmallIconUri.")]
7880
[ValidateNotNullOrEmpty]
79-
public string SmallIconUri { get; set; }
81+
public string SmallIconName { get; set; }
8082

8183
[Parameter(Position = 12, ValueFromPipelineByPropertyName = true, HelpMessage = "DontShowInGui.")]
8284
public SwitchParameter DontShowInGui { get; set; }
@@ -106,8 +108,8 @@ protected override void OnProcessRecord()
106108
PrivacyUri = this.PrivacyUri,
107109
RecommendedVMSize = this.RecommendedVMSize,
108110
Language = this.Language,
109-
IconUri = this.IconUri,
110-
SmallIconUri = this.SmallIconUri,
111+
IconUri = this.IconName,
112+
SmallIconUri = this.SmallIconName,
111113
ShowInGui = this.DontShowInGui.IsPresent ? (bool?)false : null
112114
};
113115

@@ -139,8 +141,8 @@ protected override void OnProcessRecord()
139141
Name = d.Name
140142
}).ToList(),
141143
Language = this.Language,
142-
IconUri = this.IconUri,
143-
SmallIconUri = this.SmallIconUri,
144+
IconUri = this.IconName,
145+
SmallIconUri = this.SmallIconName,
144146
ShowInGui = this.DontShowInGui.IsPresent ? (bool?)false : null
145147
};
146148

src/ServiceManagement/Compute/Commands.ServiceManagement/Model/OSImageContext.cs

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,5 +39,21 @@ public class OSImageContext : ManagementOperationContext
3939
public virtual string PublisherName { get; set; }
4040
public virtual string IOType { get; set; }
4141
public virtual bool? ShowInGui { get; set; }
42+
43+
public virtual string IconName
44+
{
45+
get
46+
{
47+
return IconUri;
48+
}
49+
}
50+
51+
public virtual string SmallIconName
52+
{
53+
get
54+
{
55+
return SmallIconUri;
56+
}
57+
}
4258
}
4359
}

0 commit comments

Comments
 (0)