Skip to content

Commit a097f1f

Browse files
author
dragonfly91
committed
[RS Backup] Fixing 7349803 (documentation fixes) for DPM, MAB and common files in Models Layer
1 parent c8891f8 commit a097f1f

File tree

3 files changed

+70
-17
lines changed

3 files changed

+70
-17
lines changed

src/ResourceManager/RecoveryServices.Backup/Commands.RecoveryServices.Backup.Models/BaseObjects.cs

Lines changed: 64 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -20,10 +20,13 @@
2020
namespace Microsoft.Azure.Commands.RecoveryServices.Backup.Cmdlets.Models
2121
{
2222
/// <summary>
23-
/// Base class for objects.
23+
/// Base class for all the PowerShell model objects.
2424
/// </summary>
2525
public class ObjectBase
2626
{
27+
/// <summary>
28+
/// Method to validate the object properties.
29+
/// </summary>
2730
public virtual void Validate() { }
2831
}
2932

@@ -33,7 +36,7 @@ public virtual void Validate() { }
3336
public class ManagementContext : ObjectBase
3437
{
3538
/// <summary>
36-
/// BackupManagementType
39+
/// Type of the backup management agent.
3740
/// </summary>
3841
public BackupManagementType BackupManagementType { get; set; }
3942

@@ -50,6 +53,9 @@ public ManagementContext(string backupManagementType)
5053
/// </summary>
5154
public class ContainerContext : ManagementContext
5255
{
56+
/// <summary>
57+
/// Type of the container that maybe managed by the recovery services vault.
58+
/// </summary>
5359
public ContainerType ContainerType { get; set; }
5460

5561
public ContainerContext() { }
@@ -72,6 +78,9 @@ public ContainerContext(string backupManagementType)
7278
/// </summary>
7379
public class BackupEngineContext : ManagementContext
7480
{
81+
/// <summary>
82+
/// Type of the backup engine.
83+
/// </summary>
7584
public string BackupEngineType { get; set; }
7685

7786
public BackupEngineContext() { }
@@ -89,7 +98,7 @@ public BackupEngineContext(string backupEngineType, string backupManagementType)
8998
public class ContainerBase : ContainerContext
9099
{
91100
/// <summary>
92-
/// Container Name
101+
/// Name of the container
93102
/// </summary>
94103
public string Name { get; set; }
95104

@@ -107,7 +116,7 @@ public ContainerBase(ServiceClientModel.ProtectionContainerResource protectionCo
107116
public class BackupEngineBase : BackupEngineContext
108117
{
109118
/// <summary>
110-
/// Container Name
119+
/// Name of the backup engine
111120
/// </summary>
112121
public string Name { get; set; }
113122

@@ -165,7 +174,7 @@ public class ItemBase : ItemContext
165174
public string Id { get; set; }
166175

167176
/// <summary>
168-
/// Last Recovery Point for the item
177+
/// Latest Recovery Point for the item
169178
/// </summary>
170179
public DateTime? LatestRecoveryPoint { get; set; }
171180

@@ -195,28 +204,27 @@ public class RecoveryPointBase : ItemContext
195204
private global::Microsoft.Azure.Management.RecoveryServices.Backup.Models.RecoveryPointResource rp;
196205

197206
/// <summary>
198-
///
207+
/// ID of the recovery point
199208
/// </summary>
200209
public string RecoveryPointId { get; set; }
201210

202211
/// <summary>
203-
///
212+
/// Name of the item represented by this recovery point
204213
/// </summary>
205214
public string ItemName { get; set; }
206215

207216
/// <summary>
208-
///
217+
/// Fully qualified ARM ID of this recovery point
209218
/// </summary>
210219
public string Id { get; set; }
211220

212221
/// <summary>
213-
///Type of recovery point (appConsistent\CrashConsistent etc)
222+
/// Type of recovery point (appConsistent\CrashConsistent etc)
214223
/// </summary>
215-
///
216224
public String RecoveryPointType { get; set; }
217225

218226
/// <summary>
219-
/// Time of RecoveryPoint
227+
/// Time when this recovery point was created
220228
/// </summary>
221229
public DateTime RecoveryPointTime { get; set; }
222230

@@ -231,10 +239,19 @@ public RecoveryPointBase()
231239
/// </summary>
232240
public class PolicyBase : ManagementContext
233241
{
242+
/// <summary>
243+
/// Name of the policy
244+
/// </summary>
234245
public string Name { get; set; }
235246

247+
/// <summary>
248+
/// Workload type of the item associated with this policy
249+
/// </summary>
236250
public WorkloadType WorkloadType { get; set; }
237251

252+
/// <summary>
253+
/// Fully qualified ARM ID of this policy
254+
/// </summary>
238255
public string Id { get; set; }
239256

240257
public override void Validate()
@@ -272,20 +289,44 @@ public class SchedulePolicyBase : ObjectBase
272289
/// </summary>
273290
public class JobBase : ManagementContext
274291
{
292+
/// <summary>
293+
/// Activity ID of this job
294+
/// </summary>
275295
public string ActivityId { get; set; }
276296

297+
/// <summary>
298+
/// ID of this job
299+
/// </summary>
277300
public string JobId { get; set; }
278301

302+
/// <summary>
303+
/// Operation represented by this job
304+
/// </summary>
279305
public string Operation { get; set; }
280306

307+
/// <summary>
308+
/// Status of this job
309+
/// </summary>
281310
public string Status { get; set; }
282311

312+
/// <summary>
313+
/// Name of the workload handled by this job
314+
/// </summary>
283315
public string WorkloadName { get; set; }
284316

317+
/// <summary>
318+
/// Time at which this job started
319+
/// </summary>
285320
public DateTime StartTime { get; set; }
286321

322+
/// <summary>
323+
/// Time at which this job was terminated
324+
/// </summary>
287325
public DateTime? EndTime { get; set; }
288326

327+
/// <summary>
328+
/// Time taken by this job to run
329+
/// </summary>
289330
public TimeSpan Duration { get; set; }
290331
}
291332

@@ -294,8 +335,14 @@ public class JobBase : ManagementContext
294335
/// </summary>
295336
public class JobErrorInfoBase
296337
{
338+
/// <summary>
339+
/// Description of the error in the backend service
340+
/// </summary>
297341
public string ErrorMessage { get; set; }
298342

343+
/// <summary>
344+
/// List of recommendations to the user, provided by the backend service for this error
345+
/// </summary>
299346
public List<string> Recommendations { get; set; }
300347
}
301348

@@ -304,8 +351,14 @@ public class JobErrorInfoBase
304351
/// </summary>
305352
public class JobSubTaskBase
306353
{
354+
/// <summary>
355+
/// Name of the sub task
356+
/// </summary>
307357
public string Name { get; set; }
308358

359+
/// <summary>
360+
/// Status of the sub task
361+
/// </summary>
309362
public string Status { get; set; }
310363
}
311364
}

src/ResourceManager/RecoveryServices.Backup/Commands.RecoveryServices.Backup.Models/DpmModels/DpmBackupEngine.cs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
namespace Microsoft.Azure.Commands.RecoveryServices.Backup.Cmdlets.Models
2323
{
2424
/// <summary>
25-
/// DPM specific backup engine class.
25+
/// Data Protection Manager (DPM) Backup Engine
2626
/// </summary>
2727
public class DpmBackupEngine : BackupEngineBase
2828
{
@@ -32,7 +32,7 @@ public class DpmBackupEngine : BackupEngineBase
3232
public string FriendlyName { get; set; }
3333

3434
/// <summary>
35-
/// Registration Status
35+
/// Status of registration of the DPM server with the Recovery Services vault
3636
/// </summary>
3737
public string Status { get; set; }
3838

@@ -46,7 +46,7 @@ public DpmBackupEngine(ServiceClientModel.BackupEngineResource backupEngine)
4646
}
4747

4848
/// <summary>
49-
/// Azure backup specific backup server engine class.
49+
/// Azure Backup Server Backup Engine
5050
/// </summary>
5151
public class AzureBackupServerEngine : BackupEngineBase
5252
{
@@ -56,7 +56,7 @@ public class AzureBackupServerEngine : BackupEngineBase
5656
public string FriendlyName { get; set; }
5757

5858
/// <summary>
59-
/// Registration Status
59+
/// Status of registration of the Azure Backup Server with the Recovery Services vault
6060
/// </summary>
6161
public string Status { get; set; }
6262

src/ResourceManager/RecoveryServices.Backup/Commands.RecoveryServices.Backup.Models/MabModels/MabContainer.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
namespace Microsoft.Azure.Commands.RecoveryServices.Backup.Cmdlets.Models
2323
{
2424
/// <summary>
25-
/// MAB specific container class.
25+
/// Microsoft Azure Backup (MAB) Container
2626
/// </summary>
2727
public class MabContainer : ContainerBase
2828
{
@@ -32,7 +32,7 @@ public class MabContainer : ContainerBase
3232
public string FriendlyName { get; set; }
3333

3434
/// <summary>
35-
/// Registration Status
35+
/// Status of registration of the MAB container with the Recovery Services vault
3636
/// </summary>
3737
public ContainerRegistrationStatus Status { get; set; }
3838

0 commit comments

Comments
 (0)