Add skip condition to LogQosEvent

xindzhan · xindzhan · commit a5f177241e15 · 2015-09-04T14:58:48.000-07:00
diff --git a/src/Common/Commands.Common/AzurePSCmdlet.cs b/src/Common/Commands.Common/AzurePSCmdlet.cs
@@ -537,8 +537,14 @@ protected void InitializeQosEvent()
         protected void LogQosEvent(bool waitForMetricSending = false)
         {
             QosEvent.FinishQosEvent();
+            //TODO change to debug
             WriteVerbose(QosEvent.ToString());
 
+            if (!IsUsageMetricEnabled && (!IsErrorMetricEnabled || QosEvent.IsSuccess))
+            {
+                return;
+            }
+
             try
             {
                 MetricHelper.LogQoSEvent(QosEvent, IsUsageMetricEnabled, IsErrorMetricEnabled);

Original file line number	Diff line number	Diff line change
`@@ -537,8 +537,14 @@ protected void InitializeQosEvent()`
`537`	`537`	`protected void LogQosEvent(bool waitForMetricSending = false)`
`538`	`538`	`{`
`539`	`539`	`QosEvent.FinishQosEvent();`
	`540`	`+ //TODO change to debug`
`540`	`541`	`WriteVerbose(QosEvent.ToString());`
`541`	`542`
	`543`	`+ if (!IsUsageMetricEnabled && (!IsErrorMetricEnabled \|\| QosEvent.IsSuccess))`
	`544`	`+ {`
	`545`	`+ return;`
	`546`	`+ }`
	`547`	`+`
`542`	`548`	`try`
`543`	`549`	`{`
`544`	`550`	`MetricHelper.LogQoSEvent(QosEvent, IsUsageMetricEnabled, IsErrorMetricEnabled);`