Enable BGInfo Extension by default

Author: hyonholee

src/ResourceManager/Compute/Commands.Compute/Commands.Compute.csproj

@@ -220,6 +220,7 @@
     <Compile Include="Extension\AzureVMBackup\AzureVMBackupConfig.cs" />
     <Compile Include="Extension\AzureVMBackup\RemoveAzureVMBackup.cs" />
     <Compile Include="Extension\AzureVMBackup\SetAzureVMBackupExtension.cs" />
+    <Compile Include="Extension\BGInfo\VirtualMachineBGInfoExtensionContext.cs" />
     <Compile Include="Extension\CustomScript\GetAzureVMCustomScriptExtensionCommand.cs" />
     <Compile Include="Extension\CustomScript\CustomScriptExtensionPrivateSettings.cs" />
     <Compile Include="Extension\CustomScript\CustomScriptExtensionPublicSettings.cs" />

src/ResourceManager/Compute/Commands.Compute/Extension/BGInfo/VirtualMachineBGInfoExtensionContext.cs

@@ -0,0 +1,23 @@
+// ----------------------------------------------------------------------------------
+//
+// Copyright Microsoft Corporation
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+// http://www.apache.org/licenses/LICENSE-2.0
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+// ----------------------------------------------------------------------------------
+
+namespace Microsoft.Azure.Commands.Compute.Models
+{
+    public class VirtualMachineBGInfoExtensionContext : PSVirtualMachineExtension
+    {
+        public const string ExtensionDefaultPublisher = "Microsoft.Compute";
+        public const string ExtensionDefaultName = "BGInfo";
+        public const string ExtensionDefaultVersion = "2.*";
+    }
+}

src/ResourceManager/Compute/Commands.Compute/Extension/CustomScript/GetAzureVMCustomScriptExtensionCommand.cs

@@ -70,7 +70,7 @@ protected override void ProcessRecord()
 
             ExecuteClientAction(() =>
             {
-                if (Status)
+                if (Status.IsPresent)
                 {
                     var result = this.VirtualMachineExtensionClient.GetWithInstanceView(this.ResourceGroupName, this.VMName, this.Name);
                     var returnedExtension = result.ToPSVirtualMachineExtension(this.ResourceGroupName);

src/ResourceManager/Compute/Commands.Compute/Extension/CustomScript/VirtualMachineCustomScriptExtensionContext.cs

@@ -22,7 +22,6 @@ public class VirtualMachineCustomScriptExtensionContext : PSVirtualMachineExtens
         public const string ExtensionDefaultName = "CustomScriptExtension";
         public const string ExtensionDefaultVersion = "1.4";
 
-
         public string CommandToExecute { get; set; }
         public string[] Uri { get; set; }
 

src/ResourceManager/Compute/Commands.Compute/Extension/RemoveAzureVMExtensionCommand.cs

@@ -60,7 +60,8 @@ protected override void ProcessRecord()
 
             ExecuteClientAction(() =>
             {
-                if (this.Force.IsPresent || this.ShouldContinue(Microsoft.Azure.Commands.Compute.Properties.Resources.VirtualMachineExtensionRemovalConfirmation, Microsoft.Azure.Commands.Compute.Properties.Resources.VirtualMachineExtensionRemovalCaption))
+                if (this.Force.IsPresent
+                    || this.ShouldContinue(Properties.Resources.VirtualMachineExtensionRemovalConfirmation, Properties.Resources.VirtualMachineExtensionRemovalCaption))
                 {
                     var op = this.VirtualMachineExtensionClient.Delete(this.ResourceGroupName, this.VMName, this.Name);
                     var result = Mapper.Map<PSComputeLongRunningOperation>(op);

src/ResourceManager/Compute/Commands.Compute/Extension/VMAccess/VirtualMachineAccessExtensionContext.cs

@@ -20,7 +20,6 @@ namespace Microsoft.Azure.Commands.Compute.Models
 {
     public class VirtualMachineAccessExtensionContext : PSVirtualMachineExtension
     {
-
         public const string ExtensionDefaultPublisher = "Microsoft.Compute";
         public const string ExtensionDefaultName = "VMAccessAgent";
         public const string ExtensionDefaultVersion = "2.0";

src/ResourceManager/Compute/Commands.Compute/Models/PSVirtualMachineExtension.cs

@@ -80,15 +80,15 @@ public static PSVirtualMachineExtension ToPSVirtualMachineExtension(this Virtual
                 Name = ext.Name,
                 Location = ext.Location,
                 Etag = null, // TODO: Update CRP library for this field
-                Publisher = ext == null ? null : ext.Publisher,
-                ExtensionType = ext == null ? null : ext.ExtensionType,
-                TypeHandlerVersion = ext == null ? null : ext.TypeHandlerVersion,
+                Publisher = ext.Publisher,
+                ExtensionType = ext.ExtensionType,
+                TypeHandlerVersion = ext.TypeHandlerVersion,
                 Id = ext.Id,
-                PublicSettings = ext == null ? null : ext.Settings,
-                ProtectedSettings = ext == null ? null : ext.ProtectedSettings,
-                ProvisioningState = ext == null ? null : ext.ProvisioningState,
-                Statuses = ext == null || ext.InstanceView == null ? null : ext.InstanceView.Statuses,
-                SubStatuses = ext == null || ext.InstanceView == null ? null : ext.InstanceView.SubStatuses,
+                PublicSettings = ext.Settings,
+                ProtectedSettings = ext.ProtectedSettings,
+                ProvisioningState = ext.ProvisioningState,
+                Statuses = ext.InstanceView == null ? null : ext.InstanceView.Statuses,
+                SubStatuses = ext.InstanceView == null ? null : ext.InstanceView.SubStatuses,
             };
 
             return result;

src/ResourceManager/Compute/Commands.Compute/VirtualMachine/Operation/NewAzureVMCommand.cs

@@ -48,6 +48,11 @@ public class NewAzureVMCommand : VirtualMachineBaseCmdlet
         [Parameter(ValueFromPipelineByPropertyName = true)]
         public Hashtable[] Tags { get; set; }
 
+        [Parameter(
+            Position = 3,
+            HelpMessage = "Disable BG Info Extension")]
+        public SwitchParameter DisableBginfoExtension { get; set; }
+
         protected override void ProcessRecord()
         {
             base.ProcessRecord();
@@ -87,10 +92,110 @@ protected override void ProcessRecord()
 
                 var op = this.VirtualMachineClient.CreateOrUpdate(this.ResourceGroupName, parameters);
                 var result = Mapper.Map<PSComputeLongRunningOperation>(op);
+
+                if (!(this.DisableBginfoExtension.IsPresent || IsLinuxOs()))
+                {
+
+                    var currentBginfoVersion = GetBginfoExtension();
+
+                    if (!string.IsNullOrEmpty(currentBginfoVersion))
+                    {
+                        var extensionParameters = new VirtualMachineExtension
+                        {
+                            Location = this.Location,
+                            Name = VirtualMachineBGInfoExtensionContext.ExtensionDefaultName,
+                            Type = VirtualMachineExtensionType,
+                            Publisher = VirtualMachineBGInfoExtensionContext.ExtensionDefaultPublisher,
+                            ExtensionType = VirtualMachineBGInfoExtensionContext.ExtensionDefaultName,
+                            TypeHandlerVersion = currentBginfoVersion,
+                            AutoUpgradeMinorVersion = true
+                        };
+
+                        ComputeClient.ComputeManagementClient.VirtualMachineExtensions.CreateOrUpdate(
+                            this.ResourceGroupName, this.VM.Name, extensionParameters);
+                    }
+                }
                 WriteObject(result);
             });
         }
 
+        private string GetBginfoExtension()
+        {
+            var canonicalizedLocation = this.Location.Canonicalize();
+
+            var publishers =
+                ComputeClient.ComputeManagementClient.VirtualMachineImages.ListPublishers(new VirtualMachineImageListPublishersParameters
+                {
+                    Location = canonicalizedLocation
+                });
+
+            var publisher = publishers.Resources.FirstOrDefault(e => e.Name.Equals(VirtualMachineBGInfoExtensionContext.ExtensionDefaultPublisher));
+
+            if (publisher == null || !publisher.Name.Equals(VirtualMachineBGInfoExtensionContext.ExtensionDefaultPublisher))
+            {
+                return null;
+            }
+
+            var virtualMachineImageClient = ComputeClient.ComputeManagementClient.VirtualMachineExtensionImages;
+
+
+            var imageTypes =
+                virtualMachineImageClient.ListTypes(new VirtualMachineExtensionImageListTypesParameters
+                {
+                    Location = canonicalizedLocation,
+                    PublisherName = VirtualMachineBGInfoExtensionContext.ExtensionDefaultPublisher
+                });
+
+            var extensionType = imageTypes.Resources.FirstOrDefault(
+                e => e.Name.Equals(VirtualMachineBGInfoExtensionContext.ExtensionDefaultName));
+
+            if (extensionType == null || !extensionType.Name.Equals(VirtualMachineBGInfoExtensionContext.ExtensionDefaultName))
+            {
+                return null;
+            }
+
+            var bginfoVersions =
+                virtualMachineImageClient.ListVersions(new VirtualMachineExtensionImageGetParameters
+                {
+                    Location = canonicalizedLocation,
+                    PublisherName = VirtualMachineBGInfoExtensionContext.ExtensionDefaultPublisher,
+                    Type = VirtualMachineBGInfoExtensionContext.ExtensionDefaultName
+                });
+
+            if (bginfoVersions != null
+                && bginfoVersions.Resources != null
+                && bginfoVersions.Resources.Count > 0)
+            {
+                return bginfoVersions.Resources.Max(ver =>
+                {
+                    Version result;
+                    return (Version.TryParse(ver.Name, out result))
+                        ? string.Format("{0}.{1}", result.Major, result.Minor)
+                        : VirtualMachineBGInfoExtensionContext.ExtensionDefaultVersion;
+                });
+            }
+
+            return null;
+        }
+
+        private bool IsLinuxOs()
+        {
+            if (this.VM == null)
+            {
+                return false;
+            }
+
+            if ((this.VM.StorageProfile != null)
+                && (this.VM.StorageProfile.OSDisk != null)
+                && (this.VM.StorageProfile.OSDisk.OperatingSystemType != null))
+            {
+                return (this.VM.StorageProfile.OSDisk.OperatingSystemType.Equals(OperatingSystemTypes.Linux));
+            }
+
+            return ((this.VM.OSProfile != null)
+                    && (this.VM.OSProfile.LinuxConfiguration != null));
+        }
+
         private Uri GetOrCreateStorageAccountForBootDiagnostics()
         {                        
             var storageAccountName = GetStorageAccountNameFromStorageProfile();