Fix error handling in device jobs related cmdlets

Author: rajsing

src/ServiceManagement/StorSimple/Commands.StorSimple/Cmdlets/DeviceJobs/GetAzureStorSimpleJob.cs

@@ -103,10 +103,7 @@ public override void ExecuteCmdlet()
             try
             {
                 // Make sure params were supplied appropriately.
-                if (!ProcessParameters())
-                {
-                    return;
-                }
+                ProcessParameters();
 
                 // Make call to get device jobs.
                 var response = StorSimpleClient.GetDeviceJobs(deviceId, Type, Status, InstanceId, fromDateTimeIsoString, toDateTimeIsoString, (int)Skip, (int)First);
@@ -115,9 +112,7 @@ public override void ExecuteCmdlet()
                 {
                     if (response == null || response.DeviceJobList.Count < 1)
                     {
-                        WriteVerbose(string.Format(Resources.NoDeviceJobFoundWithGivenIdMessage, InstanceId));
-                        WriteObject(null);
-                        return;
+                        throw new ArgumentException(string.Format(Resources.NoDeviceJobFoundWithGivenIdMessage, InstanceId));
                     }
                     WriteObject(response.DeviceJobList.First());
                     return;
@@ -174,13 +169,9 @@ private bool ProcessParameters()
                 deviceId = StorSimpleClient.GetDeviceId(DeviceName);
                 if (deviceId == null)
                 {
-                    WriteVerbose(string.Format(Resources.NoDeviceFoundWithGivenNameInResourceMessage,StorSimpleContext.ResourceName, DeviceName));
-                    WriteObject(null);
-                    return false;
+                    throw new ArgumentException(string.Format(Resources.NoDeviceFoundWithGivenNameInResourceMessage,StorSimpleContext.ResourceName, DeviceName));
                 }
             }
-
-            return true;
         }
     }
 }

src/ServiceManagement/StorSimple/Commands.StorSimple/Cmdlets/DeviceJobs/StopAzureStorSimpleJob.cs

@@ -57,17 +57,13 @@ public override void ExecuteCmdlet()
                       var deviceJobDetails = StorSimpleClient.GetDeviceJobById(InstanceId);
                       if (deviceJobDetails == null)
                       {
-                          WriteVerbose(string.Format(Resources.NoDeviceJobFoundWithGivenIdMessage, InstanceId));
-                          WriteObject(null);
-                          return;
+                          throw new ArgumentException(string.Format(Resources.NoDeviceJobFoundWithGivenIdMessage, InstanceId))
                       }
 
                       // Make sure the job is running and cancellable, else fail.
                       if (!(deviceJobDetails.IsJobCancellable && deviceJobDetails.Status == "Running"))
                       {
-                          WriteVerbose(string.Format(Resources.JobNotRunningOrCancellable, InstanceId));
-                          WriteObject(null);
-                          return;
+                          throw new ArgumentException(string.Format(Resources.JobNotRunningOrCancellable, InstanceId));
                       }
 
                       // issue call to cancel the job.