Fix Ext ID

Author: huangpf

src/ServiceManagement/Compute/Commands.ServiceManagement/Extensions/Common/ExtensionRole.cs

@@ -14,6 +14,7 @@
 
 using System;
 using System.Text;
+using System.Text.RegularExpressions;
 
 namespace Microsoft.WindowsAzure.Commands.ServiceManagement.Extensions
 {
@@ -28,6 +29,21 @@ public class ExtensionRole
         public ExtensionRoleType RoleType { get; private set; }
         public bool Default { get; private set; }
 
+        private static string RemoveDisallowedCharacters(string roleName)
+        {
+            // Remove characters that are not allowed in the extension id
+            var disallowedCharactersRegex = new Regex(@"[^A-Za-z0-9\-]");
+            var match = disallowedCharactersRegex.Match(roleName);
+
+            while (match.Success)
+            {
+                roleName = roleName.Remove(match.Index, match.Length);
+                match = disallowedCharactersRegex.Match(roleName);
+            }
+
+            return roleName;
+        }
+
         public ExtensionRole()
         {
             RoleName = string.Empty;
@@ -48,9 +64,7 @@ public ExtensionRole(string roleName)
             else
             {
                 PrefixName = RoleName = roleName.Trim();
-                PrefixName = PrefixName.Replace(".", string.Empty);
-                PrefixName = PrefixName.Replace(" ", string.Empty);
-                PrefixName = PrefixName.Replace("_", string.Empty);
+                PrefixName = RemoveDisallowedCharacters(PrefixName);
                 RoleType = ExtensionRoleType.NamedRoles;
                 Default = false;
             }
@@ -63,9 +77,7 @@ public override string ToString()
 
         public string GetExtensionId(string extensionName, string slot, int index)
         {
-            var normalizedExtName = extensionName.Replace(".", string.Empty);
-            normalizedExtName = normalizedExtName.Replace(" ", string.Empty);
-            normalizedExtName = normalizedExtName.Replace("_", string.Empty);
+            var normalizedExtName = RemoveDisallowedCharacters(extensionName);
 
             var suffix = new StringBuilder();
             suffix.AppendFormat(ExtensionIdSuffixTemplate, normalizedExtName, slot, index);