Merge pull request #283 from AuxMon/ActivityLogAlerts

Adding new Activity Log Alerts cmdlets and updating/improving the test in general.

Author: markcowl

src/ResourceManager/Insights/AzureRM.Insights.psd1

@@ -83,7 +83,11 @@ CmdletsToExport = 'Get-AzureRmUsage', 'Get-AzureRmMetricDefinition',
                'Add-AzureRmMetricAlertRule', 'Add-AzureRmLogAlertRule', 
                'Add-AzureRmWebtestAlertRule', 'Get-AzureRmAlertHistory', 
                'Get-AzureRmAlertRule', 'New-AzureRmAlertRuleEmail', 
-               'New-AzureRmAlertRuleWebhook', 'Remove-AzureRmAlertRule'
+               'New-AzureRmAlertRuleWebhook', 'Remove-AzureRmAlertRule',
+               'Set-AzureRmActivityLogAlert', 'Get-AzureRmActivityLogAlert',
+               'New-AzureRmActionGroup', 'New-AzureRmActivityLogAlertCondition',
+               'Enable-AzureRmActivityLogAlert', 'Disable-AzureRmActivityLogAlert',
+               'Remove-AzureRmActivityLogAlert'
 
 # Variables to export from this module
 # VariablesToExport = @()

src/ResourceManager/Insights/ChangeLog.md

@@ -18,6 +18,23 @@
         - Additional information about change #1
 -->
 ## Current Release
+    * New cmdlet Disable-AzureRmActivityLogAlert
+        - A new cmdlet to disable an existing activity log alert.
+        - Optionally the Tags are settable with this cmdlet too.
+    * New cmdlet Enable-AzureRmActivityLogAlert
+        - A new cmdlet to enable an existing activity log alert.
+        - Optionally the Tags are settable with this cmdlet too.
+    * New cmdlet Get-AzureRmActivityLogAlert
+        - A new cmdlet to retrieve one or more activity log alerts.
+        - The alerts can be retrieved by name, resource group, or subscription.
+    * New cmdlet New-AzureRmActionGroup
+        - A new cmdlet to create an ActionGroup object in memory (no request involved.)
+    * New cmdlet New-AzureRmActivityLogAlertCondition
+        - A new cmdlet to create an activity log alert leaf condition object in memory (no request involved.)
+    * New cmdlet Set-AzureRmActivityLogAlert
+        - A new cmdlet to create or update an activity log alert.
+    * New cmdlet Remove-AzureRmActivityLogAlert
+        - A new cmdlet to remove one activity log alert.
 
 ## Version 3.3.1
 

src/ResourceManager/Insights/Commands.Insights.Test/ActivityLogAlerts/ActivityLogAlertsUtilities.cs

@@ -0,0 +1,60 @@
+// ----------------------------------------------------------------------------------
+//
+// Copyright Microsoft Corporation
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+// http://www.apache.org/licenses/LICENSE-2.0
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+// ----------------------------------------------------------------------------------
+
+using System.Collections.Generic;
+using Microsoft.Azure.Management.Monitor.Management.Models;
+
+namespace Microsoft.Azure.Commands.Insights.Test.ActivityLogAlerts
+{
+    public static class ActivityLogAlertsUtilities
+    {
+        public static ActivityLogAlertActionGroup CreateActionGroup(string id, Dictionary<string, string> webhooks)
+        {
+            return new ActivityLogAlertActionGroup
+            {
+                ActionGroupId = id,
+                WebhookProperties = webhooks
+            };
+        }
+
+        public static ActivityLogAlertLeafCondition CreateLeafCondition(string field, string equals)
+        {
+            return new ActivityLogAlertLeafCondition
+            {
+                Field = field,
+                Equals = equals
+            };
+        }
+
+        public static ActivityLogAlertResource CreateActivityLogAlertResource(string location, string name)
+        {
+            return new ActivityLogAlertResource(
+                location: location,
+                name: name,
+                condition: new ActivityLogAlertAllOfCondition(
+                    new List<ActivityLogAlertLeafCondition>
+                    {
+                        CreateLeafCondition("field", "equals")
+                    }),
+                scopes: new List<string> { "scope1" },
+                actions: new ActivityLogAlertActionList(
+                    new List<ActivityLogAlertActionGroup>
+                    {
+                        CreateActionGroup(
+                            id: "actionGrp1",
+                            webhooks: new Dictionary<string, string>())
+                    }));
+        }
+    }
+}

src/ResourceManager/Insights/Commands.Insights.Test/ActivityLogAlerts/DisableAzureRmActivityLogAlertTests.cs

@@ -0,0 +1,121 @@
+// ----------------------------------------------------------------------------------
+//
+// Copyright Microsoft Corporation
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+// http://www.apache.org/licenses/LICENSE-2.0
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+// ----------------------------------------------------------------------------------
+
+using System.Collections.Generic;
+using Microsoft.Rest.Azure;
+using Microsoft.WindowsAzure.Commands.ScenarioTest;
+using Moq;
+using System.Management.Automation;
+using System.Threading;
+using System.Threading.Tasks;
+using Xunit;
+using Microsoft.Azure.Commands.ScenarioTest;
+using Microsoft.Azure.Commands.Insights.ActivityLogAlert;
+using Microsoft.Azure.Management.Monitor.Management;
+using Microsoft.Azure.Management.Monitor.Management.Models;
+
+namespace Microsoft.Azure.Commands.Insights.Test.ActivityLogAlerts
+{
+    public class DisableAzureRmActivityLogAlertTests
+    {
+        private readonly DisableAzureRmActivityLogAlertCommand cmdlet;
+        private readonly Mock<MonitorManagementClient> monitorClientMock;
+        private readonly Mock<IActivityLogAlertsOperations> insightsOperationsMock;
+        private Mock<ICommandRuntime> commandRuntimeMock;
+        private AzureOperationResponse<ActivityLogAlertResource> response;
+        private string resourceGroup;
+        private string name;
+        private ActivityLogAlertPatchBody body;
+
+        public DisableAzureRmActivityLogAlertTests(Xunit.Abstractions.ITestOutputHelper output)
+        {
+            ServiceManagemenet.Common.Models.XunitTracingInterceptor.AddToContext(new ServiceManagemenet.Common.Models.XunitTracingInterceptor(output));
+            TestExecutionHelpers.SetUpSessionAndProfile();
+            insightsOperationsMock = new Mock<IActivityLogAlertsOperations>();
+            monitorClientMock = new Mock<MonitorManagementClient>();
+            commandRuntimeMock = new Mock<ICommandRuntime>();
+            cmdlet = new DisableAzureRmActivityLogAlertCommand()
+            {
+                CommandRuntime = commandRuntimeMock.Object,
+                MonitorManagementClient = monitorClientMock.Object
+            };
+
+            response = new AzureOperationResponse<ActivityLogAlertResource>()
+            {
+                Body = ActivityLogAlertsUtilities.CreateActivityLogAlertResource(location: "westus", name: "alert1")
+            };
+
+            insightsOperationsMock.Setup(f => f.UpdateWithHttpMessagesAsync(It.IsAny<string>(), It.IsAny<string>(), It.IsAny<ActivityLogAlertPatchBody>(), It.IsAny<Dictionary<string, List<string>>>(), It.IsAny<CancellationToken>()))
+                .Returns(Task.FromResult<AzureOperationResponse<ActivityLogAlertResource>>(response))
+                .Callback((string r, string n, ActivityLogAlertPatchBody b, Dictionary<string, List<string>> headers, CancellationToken t) =>
+                {
+                    this.resourceGroup = r;
+                    this.name = n;
+                    this.body = b;
+                });
+
+            monitorClientMock.SetupGet(f => f.ActivityLogAlerts).Returns(this.insightsOperationsMock.Object);
+
+            // Setup Confirmation
+            commandRuntimeMock.Setup(f => f.ShouldProcess(It.IsAny<string>())).Returns(true);
+            commandRuntimeMock.Setup(f => f.ShouldProcess(It.IsAny<string>(), It.IsAny<string>())).Returns(true);
+            commandRuntimeMock.Setup(f => f.ShouldProcess(It.IsAny<string>(), It.IsAny<string>(), It.IsAny<string>())).Returns(true);
+            commandRuntimeMock.Setup(f => f.ShouldContinue(It.IsAny<string>(), It.IsAny<string>())).Returns(true);
+        }
+
+        [Fact]
+        [Trait(Category.AcceptanceType, Category.CheckIn)]
+        public void DisableActivityLogAlertCommandParametersProcessing()
+        {
+            cmdlet.ResourceGroupName = Utilities.ResourceGroup;
+            cmdlet.Name = "alert1";
+            cmdlet.ExecuteCmdlet();
+
+            Assert.Equal(Utilities.ResourceGroup, this.resourceGroup);
+            Assert.Equal("alert1", this.name);
+            Assert.NotNull(this.body);
+            Assert.False(this.body.Enabled);
+            Assert.Null(this.body.Tags);
+
+            cmdlet.ExecuteCmdlet();
+
+            Assert.NotNull(this.body);
+            Assert.False(this.body.Enabled);
+            Assert.Null(this.body.Tags);
+
+            ActivityLogAlertResource resource = new ActivityLogAlertResource(location: "Global", scopes: null, condition: null, name: "andy0307rule", actions: null, id: "//subscriptions/07c0b09d-9f69-4e6e-8d05-f59f67299cb2/resourceGroups/Default-ActivityLogAlerts/providers/microsoft.insights/activityLogAlerts/andy0307rule")
+            {
+                Enabled = true
+            };
+
+            cmdlet.InputObject = new OutputClasses.PSActivityLogAlertResource(resource);
+            cmdlet.ExecuteCmdlet();
+
+            Assert.NotNull(this.body);
+            Assert.Equal("Default-ActivityLogAlerts", this.resourceGroup);
+            Assert.Equal("andy0307rule", this.name);
+            Assert.False(this.body.Enabled);
+            Assert.Null(this.body.Tags);
+
+            cmdlet.InputObject = null;
+            cmdlet.ResourceId = "/subscriptions/07c0b09d-9f69-4e6e-8d05-f59f67299cb2/resourceGroups/Default-ActivityLogAlerts/providers/microsoft.insights/activityLogAlerts/andy0307rule";
+            cmdlet.ExecuteCmdlet();
+            Assert.NotNull(this.body);
+            Assert.Equal("Default-ActivityLogAlerts", this.resourceGroup);
+            Assert.Equal("andy0307rule", this.name);
+            Assert.False(this.body.Enabled);
+            Assert.Null(this.body.Tags);
+        }
+    }
+}

src/ResourceManager/Insights/Commands.Insights.Test/ActivityLogAlerts/EnableAzureRmActivityLogAlertTests.cs

@@ -0,0 +1,121 @@
+// ----------------------------------------------------------------------------------
+//
+// Copyright Microsoft Corporation
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+// http://www.apache.org/licenses/LICENSE-2.0
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+// ----------------------------------------------------------------------------------
+
+using System.Collections.Generic;
+using Microsoft.Rest.Azure;
+using Microsoft.WindowsAzure.Commands.ScenarioTest;
+using Moq;
+using System.Management.Automation;
+using System.Threading;
+using System.Threading.Tasks;
+using Xunit;
+using Microsoft.Azure.Commands.ScenarioTest;
+using Microsoft.Azure.Commands.Insights.ActivityLogAlert;
+using Microsoft.Azure.Management.Monitor.Management;
+using Microsoft.Azure.Management.Monitor.Management.Models;
+
+namespace Microsoft.Azure.Commands.Insights.Test.ActivityLogAlerts
+{
+    public class EnableAzureRmActivityLogAlertTests
+    {
+        private readonly EnableAzureRmActivityLogAlertCommand cmdlet;
+        private readonly Mock<MonitorManagementClient> monitorClientMock;
+        private readonly Mock<IActivityLogAlertsOperations> insightsOperationsMock;
+        private Mock<ICommandRuntime> commandRuntimeMock;
+        private AzureOperationResponse<ActivityLogAlertResource> response;
+        private string resourceGroup;
+        private string name;
+        private ActivityLogAlertPatchBody body;
+
+        public EnableAzureRmActivityLogAlertTests(Xunit.Abstractions.ITestOutputHelper output)
+        {
+            ServiceManagemenet.Common.Models.XunitTracingInterceptor.AddToContext(new ServiceManagemenet.Common.Models.XunitTracingInterceptor(output));
+            TestExecutionHelpers.SetUpSessionAndProfile();
+            insightsOperationsMock = new Mock<IActivityLogAlertsOperations>();
+            monitorClientMock = new Mock<MonitorManagementClient>();
+            commandRuntimeMock = new Mock<ICommandRuntime>();
+            cmdlet = new EnableAzureRmActivityLogAlertCommand()
+            {
+                CommandRuntime = commandRuntimeMock.Object,
+                MonitorManagementClient = monitorClientMock.Object
+            };
+
+            response = new AzureOperationResponse<ActivityLogAlertResource>()
+            {
+                Body = ActivityLogAlertsUtilities.CreateActivityLogAlertResource(location: "westus", name: "alert1")
+            };
+
+            insightsOperationsMock.Setup(f => f.UpdateWithHttpMessagesAsync(It.IsAny<string>(), It.IsAny<string>(), It.IsAny<ActivityLogAlertPatchBody>(), It.IsAny<Dictionary<string, List<string>>>(), It.IsAny<CancellationToken>()))
+                .Returns(Task.FromResult<AzureOperationResponse<ActivityLogAlertResource>>(response))
+                .Callback((string r, string n, ActivityLogAlertPatchBody b, Dictionary<string, List<string>> headers, CancellationToken t) =>
+                {
+                    this.resourceGroup = r;
+                    this.name = n;
+                    this.body = b;
+                });
+
+            monitorClientMock.SetupGet(f => f.ActivityLogAlerts).Returns(this.insightsOperationsMock.Object);
+
+            // Setup Confirmation
+            commandRuntimeMock.Setup(f => f.ShouldProcess(It.IsAny<string>())).Returns(true);
+            commandRuntimeMock.Setup(f => f.ShouldProcess(It.IsAny<string>(), It.IsAny<string>())).Returns(true);
+            commandRuntimeMock.Setup(f => f.ShouldProcess(It.IsAny<string>(), It.IsAny<string>(), It.IsAny<string>())).Returns(true);
+            commandRuntimeMock.Setup(f => f.ShouldContinue(It.IsAny<string>(), It.IsAny<string>())).Returns(true);
+        }
+
+        [Fact]
+        [Trait(Category.AcceptanceType, Category.CheckIn)]
+        public void EnableActivityLogAlertCommandParametersProcessing()
+        {
+            cmdlet.ResourceGroupName = Utilities.ResourceGroup;
+            cmdlet.Name = "alert1";
+            cmdlet.ExecuteCmdlet();
+
+            Assert.Equal(Utilities.ResourceGroup, this.resourceGroup);
+            Assert.Equal("alert1", this.name);
+            Assert.NotNull(this.body);
+            Assert.True(this.body.Enabled);
+            Assert.Null(this.body.Tags);
+
+            cmdlet.ExecuteCmdlet();
+
+            Assert.NotNull(this.body);
+            Assert.True(this.body.Enabled);
+            Assert.Null(this.body.Tags);
+
+            ActivityLogAlertResource resource = new ActivityLogAlertResource(location: "Global", scopes: null, condition: null, name: "andy0307rule", actions: null, id: "//subscriptions/07c0b09d-9f69-4e6e-8d05-f59f67299cb2/resourceGroups/Default-ActivityLogAlerts/providers/microsoft.insights/activityLogAlerts/andy0307rule")
+            {
+                Enabled = false
+            };
+
+            cmdlet.InputObject = new OutputClasses.PSActivityLogAlertResource(resource);
+            cmdlet.ExecuteCmdlet();
+
+            Assert.NotNull(this.body);
+            Assert.Equal("Default-ActivityLogAlerts", this.resourceGroup);
+            Assert.Equal("andy0307rule", this.name);
+            Assert.True(this.body.Enabled);
+            Assert.Null(this.body.Tags);
+
+            cmdlet.InputObject = null;
+            cmdlet.ResourceId = "/subscriptions/07c0b09d-9f69-4e6e-8d05-f59f67299cb2/resourceGroups/Default-ActivityLogAlerts/providers/microsoft.insights/activityLogAlerts/andy0307rule";
+            cmdlet.ExecuteCmdlet();
+            Assert.NotNull(this.body);
+            Assert.Equal("Default-ActivityLogAlerts", this.resourceGroup);
+            Assert.Equal("andy0307rule", this.name);
+            Assert.True(this.body.Enabled);
+            Assert.Null(this.body.Tags);
+        }
+    }
+}