Skip to content

Commit d914c71

Browse files
committed
[Insights] Addressing more feedback from review before Ignite
1 parent 09d4f74 commit d914c71

File tree

8 files changed

+472
-39
lines changed

8 files changed

+472
-39
lines changed

src/ResourceManager/Insights/Commands.Insights.Test/ActivityLogAlerts/NewAzureRmActionGroupTests.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ public NewAzureRmActionGroupTests(Xunit.Abstractions.ITestOutputHelper output)
3636
};
3737
}
3838

39-
[Fact]
39+
[Fact(Skip = "This is not testing anything")]
4040
[Trait(Category.AcceptanceType, Category.CheckIn)]
4141
public void NewActionGroupCommandParametersProcessing()
4242
{

src/ResourceManager/Insights/Commands.Insights.Test/ActivityLogAlerts/NewAzureRmActivityLogAlertConditionTests.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ public NewAzureRmActivityLogAlertConditionTests(Xunit.Abstractions.ITestOutputHe
3636
};
3737
}
3838

39-
[Fact]
39+
[Fact(Skip = "This is not testing anything")]
4040
[Trait(Category.AcceptanceType, Category.CheckIn)]
4141
public void NewAzureRmActivityLogAlertConditionCommandParametersProcessing()
4242
{

src/ResourceManager/Insights/Commands.Insights.Test/Autoscale/NewAzureRmAutoscaleProfileTests.cs

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,12 @@ public class NewAzureRmAutoscaleProfileTests
3434

3535
public NewAzureRmAutoscaleProfileTests(Xunit.Abstractions.ITestOutputHelper output = null)
3636
{
37-
ServiceManagemenet.Common.Models.XunitTracingInterceptor.AddToContext(new ServiceManagemenet.Common.Models.XunitTracingInterceptor(output));
3837
TestExecutionHelpers.SetUpSessionAndProfile();
38+
if (output != null)
39+
{
40+
ServiceManagemenet.Common.Models.XunitTracingInterceptor.AddToContext(new ServiceManagemenet.Common.Models.XunitTracingInterceptor(output));
41+
}
42+
3943
commandRuntimeMock = new Mock<ICommandRuntime>();
4044
Cmdlet = new NewAzureRmAutoscaleProfileCommand()
4145
{

src/ResourceManager/Insights/Commands.Insights.Test/ScenarioTests/ActivityLogAlertsTests.ps1

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -167,7 +167,13 @@ function Test-SetGetListUpdateRemoveActivityLogAlert
167167
}
168168
"BadRequest"
169169

170-
# Write-Verbose " ****** Removing the ActivityLogAlert using pileline"
170+
Write-Verbose " ****** NOP: setting an activity log alert using the value from the pipe (InputObject)"
171+
Get-AzureRmActivityLogAlert -ResourceGroup $resourceGroupName -Name $alertName | Set-AzureRmActivityLogAlert
172+
173+
Write-Verbose " ****** Disabling an activity log alert using the value of ResourceId plus another parameter"
174+
Set-AzureRmActivityLogAlert -ResourceId '/subscriptions/07c0b09d-9f69-4e6e-8d05-f59f67299cb2/resourceGroups/Default-ActivityLogAlerts/providers/microsoft.insights/activityLogAlerts/andy0307rule' -DisableAlert
175+
176+
Write-Verbose " ****** Removing the ActivityLogAlert using pileline"
171177
Get-AzureRmActivityLogAlert -ResourceGroup $resourceGroupName -Name $alertName | Remove-AzureRmActivityLogAlert
172178

173179
Write-Verbose " ****** Removing (again) the ActivityLogAlert"

src/ResourceManager/Insights/Commands.Insights.Test/SessionRecords/Microsoft.Azure.Commands.Insights.Test.ScenarioTests.ActivityLogAlertsTests/TestSetGetListUpdateRemoveActivityLogAlert.json

Lines changed: 258 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -438,6 +438,264 @@
438438
},
439439
"StatusCode": 200
440440
},
441+
{
442+
"RequestUri": "/subscriptions/07c0b09d-9f69-4e6e-8d05-f59f67299cb2/resourceGroups/Default-ActivityLogAlerts/providers/microsoft.insights/activityLogAlerts/andy0307rule?api-version=2017-04-01",
443+
"EncodedRequestUri": "L3N1YnNjcmlwdGlvbnMvMDdjMGIwOWQtOWY2OS00ZTZlLThkMDUtZjU5ZjY3Mjk5Y2IyL3Jlc291cmNlR3JvdXBzL0RlZmF1bHQtQWN0aXZpdHlMb2dBbGVydHMvcHJvdmlkZXJzL21pY3Jvc29mdC5pbnNpZ2h0cy9hY3Rpdml0eUxvZ0FsZXJ0cy9hbmR5MDMwN3J1bGU/YXBpLXZlcnNpb249MjAxNy0wNC0wMQ==",
444+
"RequestMethod": "PUT",
445+
"RequestBody": "{\r\n \"properties\": {\r\n \"scopes\": [\r\n \"/subscriptions/07c0b09d-9f69-4e6e-8d05-f59f67299cb2\"\r\n ],\r\n \"enabled\": true,\r\n \"condition\": {\r\n \"allOf\": [\r\n {\r\n \"field\": \"category\",\r\n \"equals\": \"Administrative\"\r\n },\r\n {\r\n \"field\": \"resourceGroup\",\r\n \"equals\": \"andy0307\"\r\n }\r\n ]\r\n },\r\n \"actions\": {\r\n \"actionGroups\": [\r\n {\r\n \"actionGroupId\": \"/subscriptions/07c0b09d-9f69-4e6e-8d05-f59f67299cb2/resourceGroups/Default-ActivityLogAlerts/providers/microsoft.insights/actionGroups/andygroup-donotuse\",\r\n \"webhookProperties\": {}\r\n }\r\n ]\r\n }\r\n },\r\n \"location\": \"Global\",\r\n \"tags\": {}\r\n}",
446+
"RequestHeaders": {
447+
"Content-Type": [
448+
"application/json; charset=utf-8"
449+
],
450+
"Content-Length": [
451+
"716"
452+
],
453+
"x-ms-client-request-id": [
454+
"75f3a21d-7166-4016-a72f-0b731fd681ff"
455+
],
456+
"accept-language": [
457+
"en-US"
458+
],
459+
"User-Agent": [
460+
"FxVersion/4.7.2053.0",
461+
"OSName/WindowsServer2012R2Standard",
462+
"OSVersion/6.3.9600",
463+
"Microsoft.Azure.Management.Monitor.Management.MonitorManagementClient/0.17.0.0"
464+
]
465+
},
466+
"ResponseBody": "{\r\n \"id\": \"/subscriptions/07c0b09d-9f69-4e6e-8d05-f59f67299cb2/resourceGroups/Default-ActivityLogAlerts/providers/microsoft.insights/activityLogAlerts/andy0307rule\",\r\n \"type\": \"Microsoft.Insights/ActivityLogAlerts\",\r\n \"name\": \"andy0307rule\",\r\n \"location\": \"Global\",\r\n \"kind\": null,\r\n \"tags\": {},\r\n \"properties\": {\r\n \"scopes\": [\r\n \"/subscriptions/07c0b09d-9f69-4e6e-8d05-f59f67299cb2\"\r\n ],\r\n \"condition\": {\r\n \"allOf\": [\r\n {\r\n \"field\": \"category\",\r\n \"equals\": \"Administrative\",\r\n \"containsAny\": null\r\n },\r\n {\r\n \"field\": \"resourceGroup\",\r\n \"equals\": \"andy0307\",\r\n \"containsAny\": null\r\n }\r\n ]\r\n },\r\n \"actions\": {\r\n \"actionGroups\": [\r\n {\r\n \"actionGroupId\": \"/subscriptions/07c0b09d-9f69-4e6e-8d05-f59f67299cb2/resourceGroups/Default-ActivityLogAlerts/providers/microsoft.insights/actionGroups/andygroup-donotuse\",\r\n \"webhookProperties\": {}\r\n }\r\n ]\r\n },\r\n \"enabled\": true,\r\n \"description\": null\r\n },\r\n \"identity\": null\r\n}",
467+
"ResponseHeaders": {
468+
"Content-Length": [
469+
"782"
470+
],
471+
"Content-Type": [
472+
"application/json; charset=utf-8"
473+
],
474+
"Expires": [
475+
"-1"
476+
],
477+
"Pragma": [
478+
"no-cache"
479+
],
480+
"x-ms-request-id": [
481+
"eastus_84aca4bd4a774ee8a450a9e493962dba_636384224383422853"
482+
],
483+
"x-ms-ratelimit-remaining-subscription-writes": [
484+
"1199"
485+
],
486+
"x-ms-correlation-request-id": [
487+
"bd056590-74c5-4c13-aac2-686980f81d21"
488+
],
489+
"x-ms-routing-request-id": [
490+
"WESTUS2:20170815T193359Z:bd056590-74c5-4c13-aac2-686980f81d21"
491+
],
492+
"Strict-Transport-Security": [
493+
"max-age=31536000; includeSubDomains"
494+
],
495+
"Cache-Control": [
496+
"no-cache"
497+
],
498+
"Date": [
499+
"Tue, 15 Aug 2017 19:33:58 GMT"
500+
],
501+
"Server": [
502+
"Microsoft-IIS/8.5"
503+
]
504+
},
505+
"StatusCode": 201
506+
},
507+
{
508+
"RequestUri": "/subscriptions/07c0b09d-9f69-4e6e-8d05-f59f67299cb2/resourceGroups/Default-ActivityLogAlerts/providers/microsoft.insights/activityLogAlerts/andy0307rule?api-version=2017-04-01",
509+
"EncodedRequestUri": "L3N1YnNjcmlwdGlvbnMvMDdjMGIwOWQtOWY2OS00ZTZlLThkMDUtZjU5ZjY3Mjk5Y2IyL3Jlc291cmNlR3JvdXBzL0RlZmF1bHQtQWN0aXZpdHlMb2dBbGVydHMvcHJvdmlkZXJzL21pY3Jvc29mdC5pbnNpZ2h0cy9hY3Rpdml0eUxvZ0FsZXJ0cy9hbmR5MDMwN3J1bGU/YXBpLXZlcnNpb249MjAxNy0wNC0wMQ==",
510+
"RequestMethod": "GET",
511+
"RequestBody": "",
512+
"RequestHeaders": {
513+
"x-ms-client-request-id": [
514+
"4f63b495-66f4-4dc1-84b1-476743189f42"
515+
],
516+
"accept-language": [
517+
"en-US"
518+
],
519+
"User-Agent": [
520+
"FxVersion/4.7.2053.0",
521+
"OSName/WindowsServer2012R2Standard",
522+
"OSVersion/6.3.9600",
523+
"Microsoft.Azure.Management.Monitor.Management.MonitorManagementClient/0.17.0.0"
524+
]
525+
},
526+
"ResponseBody": "{\r\n \"id\": \"/subscriptions/07c0b09d-9f69-4e6e-8d05-f59f67299cb2/resourceGroups/Default-ActivityLogAlerts/providers/microsoft.insights/activityLogAlerts/andy0307rule\",\r\n \"type\": \"Microsoft.Insights/ActivityLogAlerts\",\r\n \"name\": \"andy0307rule\",\r\n \"location\": \"Global\",\r\n \"kind\": null,\r\n \"tags\": {},\r\n \"properties\": {\r\n \"scopes\": [\r\n \"/subscriptions/07c0b09d-9f69-4e6e-8d05-f59f67299cb2\"\r\n ],\r\n \"condition\": {\r\n \"allOf\": [\r\n {\r\n \"field\": \"category\",\r\n \"equals\": \"Administrative\",\r\n \"containsAny\": null\r\n },\r\n {\r\n \"field\": \"resourceGroup\",\r\n \"equals\": \"andy0307\",\r\n \"containsAny\": null\r\n }\r\n ]\r\n },\r\n \"actions\": {\r\n \"actionGroups\": [\r\n {\r\n \"actionGroupId\": \"/subscriptions/07c0b09d-9f69-4e6e-8d05-f59f67299cb2/resourceGroups/Default-ActivityLogAlerts/providers/microsoft.insights/actionGroups/andygroup-donotuse\",\r\n \"webhookProperties\": {}\r\n }\r\n ]\r\n },\r\n \"enabled\": true,\r\n \"description\": null\r\n },\r\n \"identity\": null\r\n}",
527+
"ResponseHeaders": {
528+
"Content-Length": [
529+
"782"
530+
],
531+
"Content-Type": [
532+
"application/json; charset=utf-8"
533+
],
534+
"Expires": [
535+
"-1"
536+
],
537+
"Pragma": [
538+
"no-cache"
539+
],
540+
"Vary": [
541+
"Accept-Encoding"
542+
],
543+
"x-ms-request-id": [
544+
"eastus_f0215981a6b14510b440c68b0d849c51_636384224392643820"
545+
],
546+
"x-ms-ratelimit-remaining-subscription-reads": [
547+
"14981"
548+
],
549+
"x-ms-correlation-request-id": [
550+
"9b147585-e6f4-4075-bd23-24dc86349a87"
551+
],
552+
"x-ms-routing-request-id": [
553+
"WESTUS2:20170815T193359Z:9b147585-e6f4-4075-bd23-24dc86349a87"
554+
],
555+
"Strict-Transport-Security": [
556+
"max-age=31536000; includeSubDomains"
557+
],
558+
"Cache-Control": [
559+
"no-cache"
560+
],
561+
"Date": [
562+
"Tue, 15 Aug 2017 19:33:58 GMT"
563+
],
564+
"Server": [
565+
"Microsoft-IIS/8.5"
566+
]
567+
},
568+
"StatusCode": 200
569+
},
570+
{
571+
"RequestUri": "/subscriptions/07c0b09d-9f69-4e6e-8d05-f59f67299cb2/resourceGroups/Default-ActivityLogAlerts/providers/microsoft.insights/activityLogAlerts/andy0307rule?api-version=2017-04-01",
572+
"EncodedRequestUri": "L3N1YnNjcmlwdGlvbnMvMDdjMGIwOWQtOWY2OS00ZTZlLThkMDUtZjU5ZjY3Mjk5Y2IyL3Jlc291cmNlR3JvdXBzL0RlZmF1bHQtQWN0aXZpdHlMb2dBbGVydHMvcHJvdmlkZXJzL21pY3Jvc29mdC5pbnNpZ2h0cy9hY3Rpdml0eUxvZ0FsZXJ0cy9hbmR5MDMwN3J1bGU/YXBpLXZlcnNpb249MjAxNy0wNC0wMQ==",
573+
"RequestMethod": "PUT",
574+
"RequestBody": "{\r\n \"properties\": {\r\n \"scopes\": [\r\n \"/subscriptions/07c0b09d-9f69-4e6e-8d05-f59f67299cb2\"\r\n ],\r\n \"enabled\": false,\r\n \"condition\": {\r\n \"allOf\": [\r\n {\r\n \"field\": \"category\",\r\n \"equals\": \"Administrative\"\r\n },\r\n {\r\n \"field\": \"resourceGroup\",\r\n \"equals\": \"andy0307\"\r\n }\r\n ]\r\n },\r\n \"actions\": {\r\n \"actionGroups\": [\r\n {\r\n \"actionGroupId\": \"/subscriptions/07c0b09d-9f69-4e6e-8d05-f59f67299cb2/resourceGroups/Default-ActivityLogAlerts/providers/microsoft.insights/actionGroups/andygroup-donotuse\",\r\n \"webhookProperties\": {}\r\n }\r\n ]\r\n }\r\n },\r\n \"location\": \"Global\",\r\n \"tags\": {}\r\n}",
575+
"RequestHeaders": {
576+
"Content-Type": [
577+
"application/json; charset=utf-8"
578+
],
579+
"Content-Length": [
580+
"716"
581+
],
582+
"x-ms-client-request-id": [
583+
"75f3a21d-7166-4016-a72f-0b731fd681ff"
584+
],
585+
"accept-language": [
586+
"en-US"
587+
],
588+
"User-Agent": [
589+
"FxVersion/4.7.2053.0",
590+
"OSName/WindowsServer2012R2Standard",
591+
"OSVersion/6.3.9600",
592+
"Microsoft.Azure.Management.Monitor.Management.MonitorManagementClient/0.17.0.0"
593+
]
594+
},
595+
"ResponseBody": "{\r\n \"id\": \"/subscriptions/07c0b09d-9f69-4e6e-8d05-f59f67299cb2/resourceGroups/Default-ActivityLogAlerts/providers/microsoft.insights/activityLogAlerts/andy0307rule\",\r\n \"type\": \"Microsoft.Insights/ActivityLogAlerts\",\r\n \"name\": \"andy0307rule\",\r\n \"location\": \"Global\",\r\n \"kind\": null,\r\n \"tags\": {},\r\n \"properties\": {\r\n \"scopes\": [\r\n \"/subscriptions/07c0b09d-9f69-4e6e-8d05-f59f67299cb2\"\r\n ],\r\n \"condition\": {\r\n \"allOf\": [\r\n {\r\n \"field\": \"category\",\r\n \"equals\": \"Administrative\",\r\n \"containsAny\": null\r\n },\r\n {\r\n \"field\": \"resourceGroup\",\r\n \"equals\": \"andy0307\",\r\n \"containsAny\": null\r\n }\r\n ]\r\n },\r\n \"actions\": {\r\n \"actionGroups\": [\r\n {\r\n \"actionGroupId\": \"/subscriptions/07c0b09d-9f69-4e6e-8d05-f59f67299cb2/resourceGroups/Default-ActivityLogAlerts/providers/microsoft.insights/actionGroups/andygroup-donotuse\",\r\n \"webhookProperties\": {}\r\n }\r\n ]\r\n },\r\n \"enabled\": false,\r\n \"description\": null\r\n },\r\n \"identity\": null\r\n}",
596+
"ResponseHeaders": {
597+
"Content-Length": [
598+
"782"
599+
],
600+
"Content-Type": [
601+
"application/json; charset=utf-8"
602+
],
603+
"Expires": [
604+
"-1"
605+
],
606+
"Pragma": [
607+
"no-cache"
608+
],
609+
"x-ms-request-id": [
610+
"eastus_84aca4bd4a774ee8a450a9e493962dba_636384224383422853"
611+
],
612+
"x-ms-ratelimit-remaining-subscription-writes": [
613+
"1199"
614+
],
615+
"x-ms-correlation-request-id": [
616+
"bd056590-74c5-4c13-aac2-686980f81d21"
617+
],
618+
"x-ms-routing-request-id": [
619+
"WESTUS2:20170815T193359Z:bd056590-74c5-4c13-aac2-686980f81d21"
620+
],
621+
"Strict-Transport-Security": [
622+
"max-age=31536000; includeSubDomains"
623+
],
624+
"Cache-Control": [
625+
"no-cache"
626+
],
627+
"Date": [
628+
"Tue, 15 Aug 2017 19:33:58 GMT"
629+
],
630+
"Server": [
631+
"Microsoft-IIS/8.5"
632+
]
633+
},
634+
"StatusCode": 201
635+
},
636+
{
637+
"RequestUri": "/subscriptions/07c0b09d-9f69-4e6e-8d05-f59f67299cb2/resourceGroups/Default-ActivityLogAlerts/providers/microsoft.insights/activityLogAlerts/andy0307rule?api-version=2017-04-01",
638+
"EncodedRequestUri": "L3N1YnNjcmlwdGlvbnMvMDdjMGIwOWQtOWY2OS00ZTZlLThkMDUtZjU5ZjY3Mjk5Y2IyL3Jlc291cmNlR3JvdXBzL0RlZmF1bHQtQWN0aXZpdHlMb2dBbGVydHMvcHJvdmlkZXJzL21pY3Jvc29mdC5pbnNpZ2h0cy9hY3Rpdml0eUxvZ0FsZXJ0cy9hbmR5MDMwN3J1bGU/YXBpLXZlcnNpb249MjAxNy0wNC0wMQ==",
639+
"RequestMethod": "GET",
640+
"RequestBody": "",
641+
"RequestHeaders": {
642+
"x-ms-client-request-id": [
643+
"4f63b495-66f4-4dc1-84b1-476743189f42"
644+
],
645+
"accept-language": [
646+
"en-US"
647+
],
648+
"User-Agent": [
649+
"FxVersion/4.7.2053.0",
650+
"OSName/WindowsServer2012R2Standard",
651+
"OSVersion/6.3.9600",
652+
"Microsoft.Azure.Management.Monitor.Management.MonitorManagementClient/0.17.0.0"
653+
]
654+
},
655+
"ResponseBody": "{\r\n \"id\": \"/subscriptions/07c0b09d-9f69-4e6e-8d05-f59f67299cb2/resourceGroups/Default-ActivityLogAlerts/providers/microsoft.insights/activityLogAlerts/andy0307rule\",\r\n \"type\": \"Microsoft.Insights/ActivityLogAlerts\",\r\n \"name\": \"andy0307rule\",\r\n \"location\": \"Global\",\r\n \"kind\": null,\r\n \"tags\": {},\r\n \"properties\": {\r\n \"scopes\": [\r\n \"/subscriptions/07c0b09d-9f69-4e6e-8d05-f59f67299cb2\"\r\n ],\r\n \"condition\": {\r\n \"allOf\": [\r\n {\r\n \"field\": \"category\",\r\n \"equals\": \"Administrative\",\r\n \"containsAny\": null\r\n },\r\n {\r\n \"field\": \"resourceGroup\",\r\n \"equals\": \"andy0307\",\r\n \"containsAny\": null\r\n }\r\n ]\r\n },\r\n \"actions\": {\r\n \"actionGroups\": [\r\n {\r\n \"actionGroupId\": \"/subscriptions/07c0b09d-9f69-4e6e-8d05-f59f67299cb2/resourceGroups/Default-ActivityLogAlerts/providers/microsoft.insights/actionGroups/andygroup-donotuse\",\r\n \"webhookProperties\": {}\r\n }\r\n ]\r\n },\r\n \"enabled\": true,\r\n \"description\": null\r\n },\r\n \"identity\": null\r\n}",
656+
"ResponseHeaders": {
657+
"Content-Length": [
658+
"782"
659+
],
660+
"Content-Type": [
661+
"application/json; charset=utf-8"
662+
],
663+
"Expires": [
664+
"-1"
665+
],
666+
"Pragma": [
667+
"no-cache"
668+
],
669+
"Vary": [
670+
"Accept-Encoding"
671+
],
672+
"x-ms-request-id": [
673+
"eastus_f0215981a6b14510b440c68b0d849c51_636384224392643820"
674+
],
675+
"x-ms-ratelimit-remaining-subscription-reads": [
676+
"14981"
677+
],
678+
"x-ms-correlation-request-id": [
679+
"9b147585-e6f4-4075-bd23-24dc86349a87"
680+
],
681+
"x-ms-routing-request-id": [
682+
"WESTUS2:20170815T193359Z:9b147585-e6f4-4075-bd23-24dc86349a87"
683+
],
684+
"Strict-Transport-Security": [
685+
"max-age=31536000; includeSubDomains"
686+
],
687+
"Cache-Control": [
688+
"no-cache"
689+
],
690+
"Date": [
691+
"Tue, 15 Aug 2017 19:33:58 GMT"
692+
],
693+
"Server": [
694+
"Microsoft-IIS/8.5"
695+
]
696+
},
697+
"StatusCode": 200
698+
},
441699
{
442700
"RequestUri": "/subscriptions/07c0b09d-9f69-4e6e-8d05-f59f67299cb2/resourceGroups/Default-ActivityLogAlerts/providers/microsoft.insights/activityLogAlerts/andy0307rule?api-version=2017-04-01",
443701
"EncodedRequestUri": "L3N1YnNjcmlwdGlvbnMvMDdjMGIwOWQtOWY2OS00ZTZlLThkMDUtZjU5ZjY3Mjk5Y2IyL3Jlc291cmNlR3JvdXBzL0RlZmF1bHQtQWN0aXZpdHlMb2dBbGVydHMvcHJvdmlkZXJzL21pY3Jvc29mdC5pbnNpZ2h0cy9hY3Rpdml0eUxvZ0FsZXJ0cy9hbmR5MDMwN3J1bGU/YXBpLXZlcnNpb249MjAxNy0wNC0wMQ==",

src/ResourceManager/Insights/Commands.Insights/ActivityLogAlert/GetAzureRmActivityLogAlertCommand.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -26,23 +26,23 @@ namespace Microsoft.Azure.Commands.Insights.ActivityLogAlert
2626
[Cmdlet(VerbsCommon.Get, "AzureRmActivityLogAlert"), OutputType(typeof(List<PSActivityLogAlertResource>))]
2727
public class GetAzureRmActivityLogAlertCommand : ManagementCmdletBase
2828
{
29-
internal const string GetActivityLogAlertDeafultParamGroup = "Default parameters for get an activity log alert";
29+
internal const string GetActivityLogAlertDefaultParamGroup = "Default parameters for get an activity log alert";
3030
internal const string GetActivityLogAlertHelperParamGroup = "Parameters to make sure the resource group is given when the name is given";
3131

3232
#region Cmdlet parameters
3333

3434
/// <summary>
3535
/// Gets or sets the ResourceGroupName parameter of the cmdlet
3636
/// </summary>
37-
[Parameter(ParameterSetName = GetActivityLogAlertDeafultParamGroup, Position = 0, Mandatory = true, ValueFromPipelineByPropertyName = true, HelpMessage = "The resource group name")]
37+
[Parameter(ParameterSetName = GetActivityLogAlertDefaultParamGroup, Position = 0, Mandatory = true, ValueFromPipelineByPropertyName = true, HelpMessage = "The resource group name")]
3838
[Parameter(ParameterSetName = GetActivityLogAlertHelperParamGroup, Position = 0, Mandatory = false, ValueFromPipelineByPropertyName = true, HelpMessage = "The resource group name")]
3939
[ValidateNotNullOrEmpty]
4040
public string ResourceGroupName { get; set; }
4141

4242
/// <summary>
4343
/// Gets or sets the rule name parameter of the cmdlet
4444
/// </summary>
45-
[Parameter(ParameterSetName = GetActivityLogAlertDeafultParamGroup, Position = 1, Mandatory = true, ValueFromPipelineByPropertyName = true, HelpMessage = "The activity log alert name")]
45+
[Parameter(ParameterSetName = GetActivityLogAlertDefaultParamGroup, Position = 1, Mandatory = true, ValueFromPipelineByPropertyName = true, HelpMessage = "The activity log alert name")]
4646
[ValidateNotNullOrEmpty]
4747
public string Name { get; set; }
4848

0 commit comments

Comments
 (0)