Skip to content

Commit dfe1eaa

Browse files
committed
Fix PSOperation
1 parent 443f614 commit dfe1eaa

File tree

12 files changed

+37
-38
lines changed

12 files changed

+37
-38
lines changed

src/ResourceManager/Compute/Commands.Compute.Test/ScenarioTests/VirtualMachineTests.ps1

Lines changed: 14 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -144,11 +144,15 @@ function Test-VirtualMachine
144144

145145
# Availability Set
146146
$asetName = 'aset' + $rgname;
147-
New-AzureAvailabilitySet -ResourceGroupName $rgname -Name $asetName -Location $loc;
147+
$st = New-AzureAvailabilitySet -ResourceGroupName $rgname -Name $asetName -Location $loc;
148+
Assert-NotNull $st.RequestId;
149+
Assert-NotNull $st.StatusCode;
148150

149151
$asets = Get-AzureAvailabilitySet -ResourceGroupName $rgname;
150152
Assert-NotNull $asets;
151153
Assert-AreEqual $asetName $asets[0].Name;
154+
Assert-NotNull $asets[0].RequestId;
155+
Assert-NotNull $asets[0].StatusCode;
152156

153157
$aset = Get-AzureAvailabilitySet -ResourceGroupName $rgname -Name $asetName;
154158
Assert-NotNull $aset;
@@ -468,6 +472,8 @@ function Test-VirtualMachineSizeAndUsage
468472
# Test Sizes
469473
$s1 = Get-AzureVMSize -Location ($loc -replace ' ');
470474
Assert-NotNull $s1;
475+
Assert-NotNull $s1.RequestId;
476+
Assert-NotNull $s1.StatusCode;
471477
Validate-VirtualMachineSize $vmsize $s1;
472478

473479
$s2 = Get-AzureVMSize -ResourceGroupName $rgname -VMName $vmname;
@@ -526,6 +532,8 @@ function Validate-VirtualMachineUsage
526532
Assert-NotNull $item.Name.Value;
527533
Assert-NotNull $item.Name.LocalizedValue;
528534
Assert-True { $item.CurrentValue -le $item.Limit };
535+
Assert-NotNull $item.RequestId;
536+
Assert-NotNull $item.StatusCode;
529537
}
530538

531539
return $valid;
@@ -1069,8 +1077,12 @@ function Test-VirtualMachineTags
10691077

10701078
# Test Tags
10711079
$tags = @{Name = "test1"; Value = "testval1"}, @{ Name = "test2"; Value = "testval2" };
1072-
New-AzureVM -ResourceGroupName $rgname -Location $loc -Name $vmname -VM $p -Tags $tags;
1080+
$st = New-AzureVM -ResourceGroupName $rgname -Location $loc -Name $vmname -VM $p -Tags $tags;
1081+
Assert-NotNull $st.RequestId;
1082+
Assert-NotNull $st.StatusCode;
10731083
$vm = Get-AzureVM -ResourceGroupName $rgname -Name $vmname;
1084+
Assert-NotNull $vm.RequestId;
1085+
Assert-NotNull $vm.StatusCode;
10741086

10751087
# Assert
10761088
Assert-AreEqual $tags[0].Value $vm.Tags[$tags[0].Name];

src/ResourceManager/Compute/Commands.Compute/AvailabilitySets/GetAzureAvailabilitySetCommand.cs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,7 @@ public override void ExecuteCmdlet()
5353
foreach (var item in result.AvailabilitySets)
5454
{
5555
var psItem = Mapper.Map<PSAvailabilitySet>(item);
56+
psItem = Mapper.Map<AzureOperationResponse, PSAvailabilitySet>(result, psItem);
5657
psResultList.Add(psItem);
5758
}
5859

@@ -62,6 +63,7 @@ public override void ExecuteCmdlet()
6263
{
6364
var result = this.AvailabilitySetClient.Get(this.ResourceGroupName, this.Name);
6465
var psResult = Mapper.Map<PSAvailabilitySet>(result.AvailabilitySet);
66+
psResult = Mapper.Map<AzureOperationResponse, PSAvailabilitySet>(result, psResult);
6567
WriteObject(psResult);
6668
}
6769
}

src/ResourceManager/Compute/Commands.Compute/AvailabilitySets/NewAzureAvailabilitySetCommand.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -81,6 +81,7 @@ public override void ExecuteCmdlet()
8181
avSetParams);
8282

8383
var psResult = Mapper.Map<PSAvailabilitySet>(result.AvailabilitySet);
84+
psResult = Mapper.Map<AzureOperationResponse, PSAvailabilitySet>(result, psResult);
8485
WriteObject(psResult);
8586
}
8687
}

src/ResourceManager/Compute/Commands.Compute/AvailabilitySets/RemoveAzureAvailabilitySetCommand.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
namespace Microsoft.Azure.Commands.Compute
2222
{
2323
[Cmdlet(VerbsCommon.Remove, ProfileNouns.AvailabilitySet)]
24-
[OutputType(typeof(PSOperationResponse))]
24+
[OutputType(typeof(PSOperation))]
2525
public class RemoveAzureAvailabilitySetCommand : AvailabilitySetBaseCmdlet
2626
{
2727
[Parameter(
@@ -55,7 +55,7 @@ public override void ExecuteCmdlet()
5555
Properties.Resources.AvailabilitySetRemovalCaption))
5656
{
5757
AzureOperationResponse op = this.AvailabilitySetClient.Delete(this.ResourceGroupName, this.Name);
58-
var result = Mapper.Map<PSOperationResponse>(op);
58+
var result = Mapper.Map<PSOperation>(op);
5959
WriteObject(result);
6060
}
6161
}

src/ResourceManager/Compute/Commands.Compute/Commands.Compute.csproj

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -177,7 +177,6 @@
177177
<Compile Include="Images\GetAzureVMImageOfferCommand.cs" />
178178
<Compile Include="Images\GetAzureVMImageDetailCommand.cs" />
179179
<Compile Include="Images\VirtualMachineImageBaseCmdlet.cs" />
180-
<Compile Include="Models\PSOperationResponse.cs" />
181180
<Compile Include="Models\PSUsage.cs" />
182181
<Compile Include="Models\PSVirtualMachineExtensionImage.cs" />
183182
<Compile Include="Models\PSVirtualMachineImage.cs" />

src/ResourceManager/Compute/Commands.Compute/Common/ComputeAutoMapperProfile.cs

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -68,12 +68,20 @@ public static bool Initialize()
6868

6969
protected override void Configure()
7070
{
71+
Mapper.CreateMap<Microsoft.Azure.AzureOperationResponse, TO.PSOperation>();
72+
Mapper.CreateMap<FROM.ComputeLongRunningOperationResponse, TO.PSComputeLongRunningOperation>();
73+
7174
Mapper.CreateMap<FROM.AvailabilitySet, TO.PSAvailabilitySet>();
75+
Mapper.CreateMap<Microsoft.Azure.AzureOperationResponse, TO.PSAvailabilitySet>();
76+
7277
Mapper.CreateMap<FROM.VirtualMachine, TO.PSVirtualMachine>();
78+
Mapper.CreateMap<Microsoft.Azure.AzureOperationResponse, TO.PSVirtualMachine>();
79+
7380
Mapper.CreateMap<FROM.VirtualMachineSize, TO.PSVirtualMachineSize>();
81+
Mapper.CreateMap<Microsoft.Azure.AzureOperationResponse, TO.PSVirtualMachineSize>();
82+
7483
Mapper.CreateMap<FROM.Usage, TO.PSUsage>();
75-
Mapper.CreateMap<FROM.ComputeLongRunningOperationResponse, TO.PSComputeLongRunningOperation>();
76-
Mapper.CreateMap<Microsoft.Azure.AzureOperationResponse, TO.PSOperationResponse>();
84+
Mapper.CreateMap<Microsoft.Azure.AzureOperationResponse, TO.PSUsage>();
7785
}
7886
}
7987
}

src/ResourceManager/Compute/Commands.Compute/Microsoft.Azure.Commands.Compute.format.ps1xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -90,9 +90,9 @@
9090
</ListControl>
9191
</View>
9292
<View>
93-
<Name>Microsoft.Azure.Commands.Compute.Models.PSOperationResponse</Name>
93+
<Name>Microsoft.Azure.Commands.Compute.Models.PSOperation</Name>
9494
<ViewSelectedBy>
95-
<TypeName>Microsoft.Azure.Commands.Compute.Models.PSOperationResponse</TypeName>
95+
<TypeName>Microsoft.Azure.Commands.Compute.Models.PSOperation</TypeName>
9696
</ViewSelectedBy>
9797
<ListControl>
9898
<ListEntries>

src/ResourceManager/Compute/Commands.Compute/Models/PSOperation.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121

2222
using System.Net;
2323

24-
namespace Microsoft.Azure.Commands.Compute
24+
namespace Microsoft.Azure.Commands.Compute.Models
2525
{
2626
public class PSOperation
2727
{

src/ResourceManager/Compute/Commands.Compute/Models/PSOperationResponse.cs

Lines changed: 0 additions & 27 deletions
This file was deleted.

src/ResourceManager/Compute/Commands.Compute/Usage/GetAzureVMUsageCommand.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,7 @@ public override void ExecuteCmdlet()
4444
foreach (var item in result.Usages)
4545
{
4646
var psItem = Mapper.Map<PSUsage>(item);
47+
psItem = Mapper.Map<AzureOperationResponse, PSUsage>(result, psItem);
4748
psResultList.Add(psItem);
4849
}
4950

src/ResourceManager/Compute/Commands.Compute/VirtualMachine/Operation/GetAzureVMCommand.cs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -83,6 +83,7 @@ public override void ExecuteCmdlet()
8383
{
8484
var result = this.VirtualMachineClient.Get(this.ResourceGroupName, this.Name);
8585
var psResult = Mapper.Map<PSVirtualMachine>(result.VirtualMachine);
86+
psResult = Mapper.Map<AzureOperationResponse, PSVirtualMachine>(result, psResult);
8687
WriteObject(psResult);
8788
}
8889
}
@@ -108,6 +109,7 @@ public override void ExecuteCmdlet()
108109
foreach (var item in result.VirtualMachines)
109110
{
110111
var psItem = Mapper.Map<PSVirtualMachine>(item);
112+
psItem = Mapper.Map<AzureOperationResponse, PSVirtualMachine>(result, psItem);
111113
psResultList.Add(psItem);
112114
}
113115

src/ResourceManager/Compute/Commands.Compute/VirtualMachineSizes/GetAzureVMSizeCommand.cs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,8 @@ public override void ExecuteCmdlet()
9898
List<PSVirtualMachineSize> psResultList = new List<PSVirtualMachineSize>();
9999
foreach (var item in result.VirtualMachineSizes)
100100
{
101-
var psItem = Mapper.Map<PSVirtualMachineSize>(item);
101+
var psItem = Mapper.Map<VirtualMachineSize, PSVirtualMachineSize>(item);
102+
psItem = Mapper.Map<AzureOperationResponse, PSVirtualMachineSize>(result, psItem);
102103
psResultList.Add(psItem);
103104
}
104105

0 commit comments

Comments
 (0)