Merge pull request #684 from Azure/dev

huangpf PR: dev <- Azure:dev

Author: huangpf

.github/PULL_REQUEST_TEMPLATE.md

@@ -26,9 +26,9 @@ This checklist is used to make sure that common guidelines for a pull request ar
 
 ### [Cmdlet Signature Guidelines](https://github.com/Azure/azure-powershell/blob/dev/CONTRIBUTING.md#cmdlet-signature-guidelines)
 - [ ] New cmdlets that make changes or have side effects should implement `ShouldProcess` and have `SupportShouldProcess=true` specified in the cmdlet attribute. You can find more information on `ShouldProcess` [here](https://gist.github.com/markcowl/338e16fe5c8bbf195aff9f8af0db585d#what-is-the-change).
-- [ ] Cmdlet specifies `OutputType` attribute if any output is produced - if the cmdlet produces no output, it should implement a `PassThrough` parameter.
+- [ ] Cmdlet specifies `OutputType` attribute if any output is produced - if the cmdlet produces no output, it should implement a `PassThru` parameter.
 
 ### [Cmdlet Parameter Guidelines](https://github.com/Azure/azure-powershell/blob/dev/CONTRIBUTING.md#cmdlet-parameter-guidelines)
 - [ ] Parameter types should not expose types from the management library - complex parameter types should be defined in the module.
 - [ ] Complex parameter types are discouraged - a parameter type should be simple types as often as possible. If complex types are used, they should be shallow and easily creatable from a constructor or another cmdlet.
-- [ ] Cmdlet parameter sets should be mutually exclusive - each parameter set must have at least one mandatory parameter not in other parameter sets.
+- [ ] Cmdlet parameter sets should be mutually exclusive - each parameter set must have at least one mandatory parameter not in other parameter sets.

ChangeLog.md

@@ -1,4 +1,37 @@
-## 2016.12.14 - Version 3.3.0
+## 2017.01.18 - Version 3.4.0
+* Storage
+    * Fix Start-AzureStorageBlobCopy output might has wrong BlobType issue
+        - Start-AzureStorageBlobCopy
+    * Fix hang issue when running cmdlets from WPF/Winform context  
+        - Get-AzureStorageBlob
+        - Get-AzureStorageBlobContent
+        - Get-AzureStorageBlobCopyState
+        - Get-AzureStorageContainer
+        - Get-AzureStorageContainerStoredAccessPolicy
+        - New-AzureStorageContainer
+        - Remove-AzureStorageBlob
+        - Remove-AzureStorageContainer
+        - Set-AzureStorageBlobContent
+        - Set-AzureStorageContainerAcl
+        - Start-AzureStorageBlobCopy
+        - Stop-AzureStorageBlobCopy
+        - Get-AzureStorageFile
+        - Get-AzureStorageFileContent
+        - Get-AzureStorageFileCopyState
+        - Get-AzureStorageShare
+        - Get-AzureStorageShareStoredAccessPolicy
+        - New-AzureStorageDirectory
+        - New-AzureStorageShare
+        - Remove-AzureStorageDirectory
+        - Remove-AzureStorageFile
+        - Remove-AzureStorageShare
+        - Set-AzureStorageFileContent
+        - Start-AzureStorageFileCopy
+        - Stop-AzureStorageFileCopy
+        - Get-AzureStorageQueueStoredAccessPolicy
+        - Get-AzureStorageTableStoredAccessPolicy
+
+## 2016.12.14 - Version 3.3.0
 * ApiManagement
     * Added new cmdlets to manage external Identity Provider Configurations
         - New-AzureRmApiManagementIdentityProvider

README.md

@@ -36,7 +36,7 @@ This repository contains a set of PowerShell cmdlets for developers and administ
   * Scheduler
   * StorSimple
   * Redis Cache
- 
+
 * Windows Azure Pack
   * Web Site: CRUD web site, deployment, configure and get log, start/stop/restart/show web site
   * Service Bus: CRD namespace
@@ -46,7 +46,7 @@ This repository contains a set of PowerShell cmdlets for developers and administ
 * Windows Azure Stack
   * Azure Stack Administration
   * Storage Service Management
-  
+
 
 For detail descriptions and examples of the cmdlets, type
 * ```help azure``` to get all the cmdlets.
@@ -92,7 +92,7 @@ You can also find the standalone installers for all the versions at [Downloads](
 
 In general, follow these steps to start using Microsoft Azure PowerShell
 
-* Get yourself authenticated with Microsoft Azure. For details, please check out [this article](https://azure.microsoft.com/en-us/documentation/articles/install-configure-powershell/).
+* Get yourself authenticated with Microsoft Azure. For details, please check out [this article](https://docs.microsoft.com/powershell/azureps-cmdlets-docs/).
   * Option 1: Login with your Microsoft account or Organizational account directly from PowerShell. Microsoft Azure Active Directory authentication is used in this case. No management certificate is needed.
       * Starting from 1.0.0, you can use ```Add-AzureRmAccount -Credential``` to avoid the browser pop up for Organizational account.
       * To use RDFE cmdlets, use ```Add-AzureAccount```

src/ResourceManager/Compute/Commands.Compute/Generated/VirtualMachineScaleSet/VirtualMachineScaleSetDeleteInstancesMethod.cs

@@ -133,7 +133,7 @@ protected override void ProcessRecord()
             this.MethodName = "VirtualMachineScaleSetDeleteInstances";
             if (ShouldProcess(this.dynamicParameters["ResourceGroupName"].Value.ToString(), VerbsCommon.Remove))
             {
-                WriteWarning("Breaking change notice:'Force' parameter will be added in upcoming next release.");
+                WriteWarning("Breaking change notice:'Force' parameter will be added in upcoming release.");
                 base.ProcessRecord();
             }
         }

src/ResourceManager/Compute/Commands.Compute/VirtualMachine/Operation/GetAzureVMCommand.cs

@@ -79,7 +79,7 @@ public override void ExecuteCmdlet()
         {
             base.ExecuteCmdlet();
 
-            WriteWarning("Breaking change notice: In upcoming releaese, top level properties, DataDiskNames and NetworkInterfaceIDs, will be removed from VM object because they are also in StorageProfile and NetworkProfile, respectively.");
+            WriteWarning("Breaking change notice: In upcoming release, top level properties, DataDiskNames and NetworkInterfaceIDs, will be removed from VM object because they are also in StorageProfile and NetworkProfile, respectively.");
 
             ExecuteClientAction(() =>
             {

src/ResourceManager/OperationalInsights/ChangeLog.md

@@ -18,6 +18,7 @@
         - Additional information about change #1
 -->
 ## Current Release
+* Get-AzureRmOperationalInsightsSearchResults no longer requires the Top parameter to retrieve results
 
 ## Version 2.4.0
 

src/ResourceManager/OperationalInsights/Commands.OperationalInsights.Test/Commands.OperationalInsights.Test.csproj

@@ -222,7 +222,7 @@
     <None Include="SessionRecords\Microsoft.Azure.Commands.OperationalInsights.Test.SearchTests\TestSearchSetAndRemoveSavedSearches.json">
       <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
     </None>
-    <None Include="SessionRecords\Microsoft.Azure.Commands.OperationalInsights.Test.StorageInsightTests\TestStorageInsightCreateFailsWithoutWorkspace.json">
+    <None Include="SessionRecords\Microsoft.Azure.Commands.OperationalInsights.Test.StorageInsightTests\TestStorageInsightCreateFailsNoWs.json">
       <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
     </None>
     <None Include="SessionRecords\Microsoft.Azure.Commands.OperationalInsights.Test.StorageInsightTests\TestStorageInsightCreateUpdateDelete.json">
@@ -243,4 +243,4 @@
   </ItemGroup>
   <ItemGroup />
   <Import Project="$(MSBuildToolsPath)\Microsoft.CSharp.targets" />
-</Project>
+</Project>

src/ResourceManager/OperationalInsights/Commands.OperationalInsights.Test/ScenarioTests/StorageInsightTests.cs

@@ -35,9 +35,9 @@ public void TestStorageInsightCreateUpdateDelete()
 
         [Fact]
         [Trait(Category.AcceptanceType, Category.CheckIn)]
-        public void TestStorageInsightCreateFailsWithoutWorkspace()
+        public void TestStorageInsightCreateFailsNoWs()
         {
-            RunPowerShellTest("Test-StorageInsightCreateFailsWithoutWorkspace");
+            RunPowerShellTest("Test-StorageInsightCreateFailsNoWs");
         }
     }
 }

src/ResourceManager/OperationalInsights/Commands.OperationalInsights.Test/ScenarioTests/StorageInsightTests.ps1

@@ -99,7 +99,7 @@ function Test-StorageInsightCreateUpdateDelete
 .SYNOPSIS
 Validate that storage insight creation fails without a valid parent workspace
 #>
-function Test-StorageInsightCreateFailsWithoutWorkspace
+function Test-StorageInsightCreateFailsNoWs
 {
     $wsname = Get-ResourceName
     $siname = Get-ResourceName

src/ResourceManager/OperationalInsights/Commands.OperationalInsights.Test/SessionRecords/Microsoft.Azure.Commands.OperationalInsights.Test.StorageInsightTests/TestStorageInsightCreateFailsWithoutWorkspace.json renamed to src/ResourceManager/OperationalInsights/Commands.OperationalInsights.Test/SessionRecords/Microsoft.Azure.Commands.OperationalInsights.Test.StorageInsightTests/TestStorageInsightCreateFailsNoWs.json

@@ -362,7 +362,7 @@
     }
   ],
   "Names": {
-    "Test-StorageInsightCreateFailsWithoutWorkspace": [
+    "Test-StorageInsightCreateFailsNoWs": [
       "onesdk4327",
       "onesdk2618",
       "onesdk7042",

src/ResourceManager/OperationalInsights/Commands.OperationalInsights/Client/OperationalInsightsClient.Search.cs

@@ -62,16 +62,18 @@ public virtual PSSearchGetSchemaResponse GetSchema(string resourceGroupName, str
         public virtual PSSearchGetSearchResultsResponse GetSearchResults(string resourceGroupName, string workspaceName, PSSearchGetSearchResultsParameters psParameters)
         {
             SearchGetSearchResultsParameters parameters = new SearchGetSearchResultsParameters();
-            parameters.Top = psParameters.Top;
+            
             if (psParameters.Highlight != null)
             {
                 parameters.Highlight = new Highlight();
                 parameters.Highlight.Pre = psParameters.Highlight.Pre;
                 parameters.Highlight.Post = psParameters.Highlight.Post;
             }
+            
+            parameters.Top = psParameters.Top == 0 ? 10 : psParameters.Top;
             parameters.Query = psParameters.Query;
             parameters.Start = psParameters.Start;
-            parameters.End = psParameters.End;
+            parameters.End = psParameters.End.GetValueOrDefault(DateTime.UtcNow);
 
             SearchGetSearchResultsResponse response = OperationalInsightsManagementClient.Search.GetSearchResults(resourceGroupName, workspaceName, parameters);
             PSSearchGetSearchResultsResponse searchResponse = new PSSearchGetSearchResultsResponse(response);