Make HalpAnalyzer robust over empty dependent assemblies

markcowl · markcowl · commit e3a585864577 · 2017-09-14T20:04:23.000-07:00
diff --git a/tools/StaticAnalysis/HelpAnalyzer/HelpAnalyzer.cs b/tools/StaticAnalysis/HelpAnalyzer/HelpAnalyzer.cs
@@ -203,7 +203,7 @@ private void AnalyzeMarkdownHelp(
                     return;
                 }
 
-                var cmdletFiles = cmdletResult.Select(c => c.ToString().Substring(2));
+                var cmdletFiles = cmdletResult.Where(i => i != null && !string.IsNullOrWhiteSpace(i.ToString()) && i.ToString().Length > 2).Select(c => c.ToString().Substring(2));
                 if (cmdletFiles.Any())
                 {
                     List<CmdletHelpMetadata> allCmdlets = new List<CmdletHelpMetadata>();

Original file line number	Diff line number	Diff line change
`@@ -203,7 +203,7 @@ private void AnalyzeMarkdownHelp(`
`203`	`203`	`return;`
`204`	`204`	`}`
`205`	`205`
`206`		`- var cmdletFiles = cmdletResult.Select(c => c.ToString().Substring(2));`
	`206`	`+ var cmdletFiles = cmdletResult.Where(i => i != null && !string.IsNullOrWhiteSpace(i.ToString()) && i.ToString().Length > 2).Select(c => c.ToString().Substring(2));`
`207`	`207`	`if (cmdletFiles.Any())`
`208`	`208`	`{`
`209`	`209`	`List<CmdletHelpMetadata> allCmdlets = new List<CmdletHelpMetadata>();`