Fixed "KeyNotFoundException when running Add-AzureAccount with no RDFE subscriptions" Azure#1654

Author: Hovsep Mkrtchyan

src/ResourceManager/Profile/Commands.Profile.Test/ProfileCmdletTests.cs

@@ -23,6 +23,7 @@
 using Microsoft.WindowsAzure.Commands.Utilities.Common;
 using System;
 using System.Linq;
+using System.Management.Automation;
 using Xunit;
 using Xunit.Abstractions;
 
@@ -76,6 +77,21 @@ public void SelectAzureProfileNull()
             cmdlt.InvokeEndProcessing();
         }
 
+
+        [Fact]
+        [Trait(Category.AcceptanceType, Category.CheckIn)]
+        public void SelectAzureProfileBadPath()
+        {
+            SelectAzureRMProfileCommand cmdlt = new SelectAzureRMProfileCommand();
+            cmdlt.Path = "z:\non-existent-path\non-existent-file.ext";
+            // Setup
+            cmdlt.CommandRuntime = commandRuntimeMock;
+
+            // Act
+            cmdlt.InvokeBeginProcessing();
+            Assert.Throws<PSArgumentException>(() => cmdlt.ExecuteCmdlet());
+        }
+
         [Fact]
         [Trait(Category.AcceptanceType, Category.CheckIn)]
         public void SelectAzureProfileFromDisk()

src/ServiceManagement/Common/Commands.ServiceManagement.Common/ProfileClient.cs

@@ -322,6 +322,13 @@ public AzureAccount AddAccountAndLoadSubscriptions(AzureAccount account, AzureEn
                                             password,
                                             password == null ? ShowDialog.Always : ShowDialog.Never).ToList();
 
+            if (subscriptionsFromServer == null ||
+                subscriptionsFromServer.Count ==0 )
+            {
+                throw new ArgumentException("No subscriptions are associated with the logged in account in " + 
+                        "Azure Service Management (RDFE). This means that the logged in user is not an administrator " + 
+                        "or co-administrator for any account." + Environment.NewLine + "Did you mean to execute Login-AzureRmAccount?");
+            }
             // If account id is null the login failed
             if (account.Id != null)
             {

src/ServiceManagement/Services/Commands.Test/Profile/ProfileCmdltsTests.cs

@@ -979,6 +979,34 @@ public void CanAddAccountToCustomProfile()
             Assert.Equal(profile.Context.Subscription.Id, rdfeSubscription);
         }
 
+        [Fact]
+        [Trait(Category.AcceptanceType, Category.CheckIn)]
+        public void AddAzureAccountThrowsForEmptySubscriptions()
+        {
+            var cmdlet = new AddAzureAccount();
+            var csmSubscription = Guid.NewGuid();
+            var rdfeSubscription = Guid.NewGuid();
+            var credential = GenerateCredential("mySillyPassword");
+            var profile = new AzureSMProfile();
+            var client = new ProfileClient(profile);
+            cmdlet.Credential = credential;
+            cmdlet.Profile = profile;
+            cmdlet.SetParameterSet("User");
+
+            AzureSession.ClientFactory =
+            new MockClientFactory(
+               new List<object>
+                        {
+                            ProfileClientHelper.CreateRdfeSubscriptionClient(rdfeSubscription),
+                            ProfileClientHelper.CreateCsmSubscriptionClient(new List<string>(),
+                            new List<string>{csmSubscription.ToString(), rdfeSubscription.ToString()})
+                        }, true);
+            AzureSession.AuthenticationFactory = new MockTokenAuthenticationFactory(credential.UserName,
+                Guid.NewGuid().ToString());
+            cmdlet.CommandRuntime = commandRuntimeMock;
+            cmdlet.InvokeBeginProcessing();
+            Assert.Throws<ArgumentException>(() => cmdlet.ExecuteCmdlet());
+        }
         [Fact]
         [Trait(Category.AcceptanceType, Category.CheckIn)]
         public void CanCreateProfieWithSPAuth()