add RangeList tests

Author: coyotte508

packages/hub/src/utils/RangeList.spec.ts

@@ -0,0 +1,96 @@
+import { describe, it, expect } from "vitest";
+import { RangeList } from "./RangeList";
+
+describe("RangeList", () => {
+	it("should add a single range", () => {
+		const rangeList = new RangeList();
+		rangeList.add(1, 100);
+
+		const ranges = rangeList.getAllRanges();
+		expect(ranges).toHaveLength(1);
+		expect(ranges[0]).toEqual({
+			start: 1,
+			end: 100,
+			refCount: 1,
+			data: null,
+		});
+	});
+
+	it("should handle overlapping ranges", () => {
+		const rangeList = new RangeList();
+		rangeList.add(1, 100);
+		rangeList.add(30, 50);
+
+		const ranges = rangeList.getAllRanges();
+		expect(ranges).toHaveLength(3);
+		expect(ranges).toEqual([
+			{ start: 1, end: 30, refCount: 1, data: null },
+			{ start: 30, end: 50, refCount: 2, data: null },
+			{ start: 50, end: 100, refCount: 1, data: null },
+		]);
+	});
+
+	it("should remove a range at existing boundaries", () => {
+		const rangeList = new RangeList();
+		rangeList.add(1, 100);
+		rangeList.add(30, 50);
+		rangeList.remove(30, 50);
+
+		const ranges = rangeList.getAllRanges();
+		expect(ranges).toHaveLength(3);
+		expect(ranges).toEqual([
+			{ start: 1, end: 30, refCount: 1, data: null },
+			{ start: 30, end: 50, refCount: 1, data: null },
+			{ start: 50, end: 100, refCount: 1, data: null },
+		]);
+	});
+
+	it("should throw error when removing range at non-existing boundaries", () => {
+		const rangeList = new RangeList();
+		rangeList.add(1, 100);
+		rangeList.add(30, 50);
+
+		expect(() => rangeList.remove(2, 50)).toThrow("Range boundaries must match existing boundaries");
+	});
+
+	it("should get ranges within boundaries", () => {
+		const rangeList = new RangeList();
+		rangeList.add(1, 100);
+		rangeList.add(30, 50);
+
+		const ranges = rangeList.getRanges(30, 100);
+		expect(ranges).toHaveLength(2);
+		expect(ranges).toEqual([
+			{ start: 30, end: 50, refCount: 2, data: null },
+			{ start: 50, end: 100, refCount: 1, data: null },
+		]);
+	});
+
+	it("should throw error when end is less than or equal to start", () => {
+		const rangeList = new RangeList();
+
+		expect(() => rangeList.add(100, 1)).toThrow("End must be greater than start");
+		expect(() => rangeList.add(1, 1)).toThrow("End must be greater than start");
+		expect(() => rangeList.remove(100, 1)).toThrow("End must be greater than start");
+		expect(() => rangeList.remove(1, 1)).toThrow("End must be greater than start");
+		expect(() => rangeList.getRanges(100, 1)).toThrow("End must be greater than start");
+		expect(() => rangeList.getRanges(1, 1)).toThrow("End must be greater than start");
+	});
+
+	it("should handle multiple overlapping ranges", () => {
+		const rangeList = new RangeList();
+		rangeList.add(1, 100);
+		rangeList.add(30, 50);
+		rangeList.add(40, 60);
+
+		const ranges = rangeList.getAllRanges();
+		expect(ranges).toHaveLength(5);
+		expect(ranges).toEqual([
+			{ start: 1, end: 30, refCount: 1, data: null },
+			{ start: 30, end: 40, refCount: 2, data: null },
+			{ start: 40, end: 50, refCount: 3, data: null },
+			{ start: 50, end: 60, refCount: 2, data: null },
+			{ start: 60, end: 100, refCount: 1, data: null },
+		]);
+	});
+});

packages/hub/src/utils/RangeList.ts

@@ -16,7 +16,7 @@
  * I want to be able to associate data to each range. And I want to be able to get the ranges inside boundaries. For example , with [1, 30], [30, 50] * 2, [50, 100] configuration
  *
  * - getting [30, 100] => I receive [30, 50] * 2, [50, 100], and I can get / modify the data assocaited to each range by accessing their data prop. Note the "*2" is just the ref counter, there is onlly one range object for the interval returned
- * - getting [2, 50] => error because "2" is not a boundary
+ * - getting [2, 50] => I get [30, 50] * 2
  *
  * ----
  *
@@ -45,7 +45,7 @@ export class RangeList<T> {
 		const overlappingRanges: { index: number; range: Range<T> }[] = [];
 		for (let i = 0; i < this.ranges.length; i++) {
 			const range = this.ranges[i];
-			if (start <= range.end && end >= range.start) {
+			if (start < range.end && end > range.start) {
 				overlappingRanges.push({ index: i, range });
 			}
 			if (range.data !== null) {
@@ -134,7 +134,7 @@ export class RangeList<T> {
 		const affectedRanges: { index: number; range: Range<T> }[] = [];
 		for (let i = 0; i < this.ranges.length; i++) {
 			const range = this.ranges[i];
-			if (start <= range.end && end >= range.start) {
+			if (start < range.end && end > range.start) {
 				affectedRanges.push({ index: i, range });
 			}
 		}
@@ -167,15 +167,7 @@ export class RangeList<T> {
 			throw new TypeError("End must be greater than start");
 		}
 
-		// Find ranges that overlap with the requested boundaries
-		const result: Range<T>[] = [];
-		for (const range of this.ranges) {
-			if (start <= range.end && end >= range.start) {
-				result.push(range);
-			}
-		}
-
-		return result;
+		return this.ranges.filter((range) => start < range.end && end > range.start);
 	}
 
 	/**