lint & format

Author: ngxson

packages/gguf/src/gguf.spec.ts

@@ -37,8 +37,8 @@ describe("gguf", () => {
 			"llama.rope.dimension_count": 128,
 		});
 
-		expect(!!metadata["tokenizer.ggml.model"]);
-		if (!!metadata["tokenizer.ggml.model"]) {
+		expect(metadata["tokenizer.ggml.model"]);
+		if (metadata["tokenizer.ggml.model"]) {
 			const tokens = metadata["tokenizer.ggml.tokens"];
 			if (!Array.isArray(tokens)) {
 				throw new Error();

packages/gguf/src/types.spec.ts

@@ -1,42 +1,42 @@
 import { describe, it } from "vitest";
-import { GGUFStrictType, GGUFMetadata, GGUFNonStrictType } from "./types";
+import type { GGUFStrictType, GGUFMetadata, GGUFNonStrictType } from "./types";
 
 describe("gguf-types", () => {
-  it("GGUFNonStrictType should be correct (at compile time)", async () => {
+	it("GGUFNonStrictType should be correct (at compile time)", async () => {
+		// eslint-disable-next-line @typescript-eslint/no-explicit-any
 		const model: GGUFMetadata<GGUFNonStrictType> = null as any;
-    model.kv_count = 123n;
-    model.abc = 456; // PASS, because it can be anything
+		model.kv_count = 123n;
+		model.abc = 456; // PASS, because it can be anything
 	});
 
 	it("GGUFStrictType should be correct (at compile time)", async () => {
+		// eslint-disable-next-line @typescript-eslint/no-explicit-any
 		const model: GGUFMetadata<GGUFStrictType> = null as any;
 
 		if (model["general.architecture"] === "whisper") {
 			model["encoder.whisper.block_count"] = 0;
-			// @ts-expect-error
-			model["encoder.whisper.block_count"] = "abc"; // error, because it must be a number
+			// @ts-expect-error because it must be a number
+			model["encoder.whisper.block_count"] = "abc";
 		}
 
 		if (model["tokenizer.ggml.model"] === undefined) {
-			// @ts-expect-error
-			model["tokenizer.ggml.eos_token_id"] = 1; // error, because it's undefined
+			// @ts-expect-error because it's undefined
+			model["tokenizer.ggml.eos_token_id"] = 1;
 		}
 		if (model["tokenizer.ggml.model"] === "gpt2") {
-			// @ts-expect-error
-			model["tokenizer.ggml.eos_token_id"] = undefined; // error, because it must be a number
+			// @ts-expect-error because it must be a number
+			model["tokenizer.ggml.eos_token_id"] = undefined;
 			model["tokenizer.ggml.eos_token_id"] = 1;
 		}
 
 		if (model["general.architecture"] === "mamba") {
 			model["mamba.ssm.conv_kernel"] = 0;
-			// @ts-expect-error
-			model["mamba.ssm.conv_kernel"] = "abc"; // error, because it must be a number
+			// @ts-expect-error because it must be a number
+			model["mamba.ssm.conv_kernel"] = "abc";
 		}
 		if (model["general.architecture"] === "llama") {
-      // @ts-expect-error
+			// @ts-expect-error llama does not have ssm.* keys
 			model["mamba.ssm.conv_kernel"] = 0;
-      // @ts-expect-error
-			model["mamba.ssm.conv_kernel"] = "abc"; // PASS, because it can be anything
 		}
 	});
 });

packages/gguf/src/types.ts

@@ -58,9 +58,9 @@ export interface GGUFGeneralInfo<TArchitecture extends Architecture> {
 }
 
 type ModelMetadata = Whisper | RWKV | TransformerLLM;
-type NoModelMetadata = {
-	"general.architecture"?: undefined,
-};
+interface NoModelMetadata {
+	"general.architecture"?: undefined;
+}
 
 export type ModelBase<
 	TArchitecture extends
@@ -88,9 +88,9 @@ interface Tokenizer {
 	"tokenizer.ggml.add_bos_token": boolean;
 	"tokenizer.chat_template"?: string;
 }
-type NoTokenizer = {
-	"tokenizer.ggml.model"?: undefined,
-};
+interface NoTokenizer {
+	"tokenizer.ggml.model"?: undefined;
+}
 
 /// Models outside of llama.cpp: "rwkv" and "whisper"