[Conversational snippet] Fix, refactor, & add tests #1003
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mishig25
requested review from
SBrandeis,
gary149,
Wauplin,
julien-c and
pcuenca
as code owners
makes it look nicer for streaming text from inference api
mishig25
commented
Oct 31, 2024
| @@ -128,6 +128,7 @@ const modelInputSnippets: { | |||
| "tabular-classification": inputsTabularPrediction, | |||
| "text-classification": inputsTextClassification, | |||
| "text-generation": inputsTextGeneration, | |||
| "image-text-to-text": inputsTextGeneration, | |||
There was a problem hiding this comment.
this fix was needed, which caused an error on the hub. slack context.
I've created tests files for snippets that test the snippets for both LLMs & VLMs
mishig25
commented
Oct 31, 2024
| }); | ||
|
|
||
| return opts.start + messagesStringified.join(opts.sep) + opts.end; | ||
| export function stringifyMessages( |
There was a problem hiding this comment.
redo stringifyMessages function to be cleaner
julien-c
reviewed
Nov 1, 2024
julien-c
approved these changes
Nov 1, 2024
Wauplin
added a commit
that referenced
this pull request
Nov 14, 2024
Supersedes #994. This PR adds an `huggingface_hub` snippet for `text-to-image` inference in Python. I added a test as done in #1003. Once this one is approved and merged, I'll move on with all other tasks that the `InferenceClient` supports. --------- Co-authored-by: Mishig <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[Conversational snippet] Fix, refactor, & add tests
closes #1010