[safetensors] add named groups to RE_SAFETENSORS_SHARD_FILE regex #622
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coyotte508
reviewed
Apr 11, 2024
| @@ -14,7 +14,7 @@ export const SAFETENSORS_INDEX_FILE = "model.safetensors.index.json"; | |||
| /// but in some situations safetensors weights have different filenames. | |||
| export const RE_SAFETENSORS_FILE = /\.safetensors$/; | |||
| export const RE_SAFETENSORS_INDEX_FILE = /\.safetensors\.index\.json$/; | |||
| export const RE_SAFETENSORS_SHARD_FILE = /\d{5}-of-\d{5}\.safetensors$/; | |||
| export const RE_SAFETENSORS_SHARD_FILE = /(?<shard>\d{5})-of-(?<total>\d{5})\.safetensors$/; | |||
There was a problem hiding this comment.
Might as well add the "prefix" group? If you're planning on extracting it
There was a problem hiding this comment.
in that case add [_-] between the captured prefix and the shard number
(most models on the hub use a dash at this position (it's what's generated by transformers), but not bigscience/bloom)
julien-c
approved these changes
Apr 11, 2024
| @@ -14,7 +14,7 @@ export const SAFETENSORS_INDEX_FILE = "model.safetensors.index.json"; | |||
| /// but in some situations safetensors weights have different filenames. | |||
| export const RE_SAFETENSORS_FILE = /\.safetensors$/; | |||
| export const RE_SAFETENSORS_INDEX_FILE = /\.safetensors\.index\.json$/; | |||
| export const RE_SAFETENSORS_SHARD_FILE = /\d{5}-of-\d{5}\.safetensors$/; | |||
| export const RE_SAFETENSORS_SHARD_FILE = /(?<shard>\d{5})-of-(?<total>\d{5})\.safetensors$/; | |||
There was a problem hiding this comment.
in that case add [_-] between the captured prefix and the shard number
(most models on the hub use a dash at this position (it's what's generated by transformers), but not bigscience/bloom)
julien-c
reviewed
Apr 11, 2024
Co-authored-by: Eliott C. <[email protected]>
mishig25
pushed a commit
that referenced
this pull request
Apr 12, 2024
gguf equivalent for #622 (comment)
mishig25
pushed a commit
that referenced
this pull request
Apr 15, 2024
follow up to #622 (comment) > but that was my point, the -_ is not optional > we do want to enforce some level of convention
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add named groups to RE_SAFETENSORS_SHARD_FILE regex
safetensors equivalent of #621