[llama.cpp snippet] Present both options #737
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mishig25
force-pushed
the
llama_cpp_two_options
branch
3 times, most recently
from
4555dfe to
fd3d9cb
Compare
mishig25
force-pushed
the
llama_cpp_two_options
branch
from
fd3d9cb to
0abe683
Compare
mishig25
requested review from
osanseviero,
SBrandeis,
gary149,
Wauplin,
julien-c and
pcuenca
as code owners
gary149
reviewed
Jun 5, 2024
Co-authored-by: Victor Muštar <[email protected]>
This reverts commit e17e78e.
gary149
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow up to #720
just like we show two snippets for transformers (pipeline & automodel) (example here)
we should show the two options for llama.cpp clearly as well. The two options are: installing from brew and installing from source