Add recurrentgemma and gemma.cpp as libraries #748
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osanseviero
requested review from
SBrandeis,
gary149,
Wauplin,
julien-c and
pcuenca
as code owners
Vaibhavs10
approved these changes
Jun 10, 2024
There was a problem hiding this comment.
LGTM, confirmed by looking through all the repos here: https://huggingface.co/models?other=gemma.cpp
They all only seem to have *.sbs file format.
SBrandeis
approved these changes
Jun 10, 2024
julien-c
approved these changes
Jun 10, 2024
Wauplin
reviewed
Jun 10, 2024
Wauplin
approved these changes
Jun 10, 2024
gary149
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.