Skip to content

Run tasks-gen scripts automatically #964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Nov 18, 2024
Merged

Run tasks-gen scripts automatically #964

merged 17 commits into from
Nov 18, 2024

Conversation

Wauplin
Copy link
Contributor

@Wauplin Wauplin commented Oct 11, 2024

This PR adds a Github Action to automatically run the @huggingface/tasks-gen scripts and open a PR if anything has changed. The workflow is triggered once a day (3am) and can be triggered manually if needed.

Here is an example of auto-generated PR: #1030.


Note: lint issues seems unrelated. But it doesn't seem to happen on main (see here) so I don't know what's causing it 😕

@Wauplin Wauplin changed the title Tasks - Update specs - first draft Run tasks-gen scripts automatically Nov 15, 2024
@Wauplin Wauplin marked this pull request as ready for review November 15, 2024 14:41
Copy link
Contributor

@hanouticelina hanouticelina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

Copy link
Member

@pcuenca pcuenca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Comment on lines +35 to +37
# Check changes
- run: git status

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: is this necessary?

Copy link
Contributor Author

@Wauplin Wauplin Nov 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not necessary not but nice to have I think.
Since we are opening automated PRs, I'd not be surprised if at some point in the future the CI breaks for a reason. Having a git status in the logs doesn't cost much and might be helpful for quick investigations

@Wauplin
Copy link
Contributor Author

Wauplin commented Nov 18, 2024

Let's merge! Hope we won't regret it 😄

@Wauplin Wauplin merged commit f51b2e3 into main Nov 18, 2024
5 checks passed
@Wauplin Wauplin deleted the add-workflow-update-specs branch November 18, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants