Skip to content

Fix the weight name in GTEClassificationHead #606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 6, 2025

Conversation

kozistr
Copy link
Contributor

@kozistr kozistr commented May 3, 2025

What does this PR do?

Fixes #605

The pooler layer loads its weight using an incorrect key name, causing the classifier and reranker based on GTE to produce wrong outputs.

changelog

  • load the weight from new.pooler.dense.* or pooler.dense.*
  • add the tests
  • update the flash gte test

tests

I've checked that the outputs are aligned with the HF models.

  • WebOrganizer/FormatClassifier
  • Alibaba-NLP/gte-multilingual-reranker-base

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@Narsil @alvarobartt

Copy link
Collaborator

@Narsil Narsil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Narsil Narsil merged commit f21a638 into huggingface:main May 6, 2025
@WissamAntoun
Copy link
Contributor

Thank you!

@kozistr kozistr deleted the fix/gte-classification-head branch May 6, 2025 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong classification outputs with WebOrganizer/FormatClassifier model based on gte-base-en-v1.5
3 participants