Merge branch 'feature/updateApiVersion' of https://github.com/rileymckenna/azure-powershell into feature/updateApiVersion

Author: rileymckenna

build.proj

@@ -263,7 +263,7 @@
   </Target>
 
   <Target Name="TestFailureErrorMessage">
-    <Error Text="Test failures occured, check the files in artifacts/TestResults" />
+    <Error Text="Test failures occurred, check the files in artifacts/TestResults" />
   </Target>
 
   <Target Name="CodeSignBinaries" AfterTargets="Build" Condition="'$(CodeSign)' == 'true'">

documentation/announcing-az-module.md

@@ -25,11 +25,11 @@ Az is a new module, and reorganizing and simplifying cmdlet names involves break
 | Date | Feature |
 -------|----------
 | **August 2018** | Initial Release |
-| **November 2018** | Functional arity with AzureRM |
+| **November 2018** | Functional parity with AzureRM |
 | **December 2018** | Az 1.0 Release |
 | **January 2019** | New Authentication mechanisms for Windows PowerShell
 |  | - Username + password authentication
-|  | - Web broswer control authentication |
+|  | - Web browser control authentication |
 
 
 
@@ -139,7 +139,7 @@ For scripts that import modules directly, or use ```#Requires``` statements to s
 | AzureRM.Media | Az.Media |
 | AzureRM.Network | Az.Network |
 | AzureRM.NotificationHubs | Az.NotificationHubs |
-| AzureRM.OperationalInsights | Az.OperationalIsights |
+| AzureRM.OperationalInsights | Az.OperationalInsights |
 | AzureRM.PolicyInsights | Az.PolicyInsights |
 | AzureRM.PowerBIEmbedded | Az.PowerBIEmbedded* |
 | **AzureRM.Profile** | **Az.Accounts** |
@@ -187,7 +187,7 @@ If you need to have both modules installed:
   ```
 
 ##### Interactive Usage
-You cannot load Az and AzureRM modules in the same PowerShell session, but they can be used in seperate sessions as follows
+You cannot load Az and AzureRM modules in the same PowerShell session, but they can be used in separate sessions as follows
   - In AzureRM session:  ```Import-Module AzureRM```
   - In Az session:  Begin the session with ```Enable-AzureRmAlias```, which will prevent inadvertently loading AzureRM modules.  Alternately, you can use cmdlets with Az noun prefix, and avoid using cmdlets with Azure or AzureRm noun
 

documentation/breaking-changes/breaking-changes-attribute-help.md

@@ -1,6 +1,6 @@
 # Breaking Changes Attribute Help
 
-Below is description of the various types of Breaking Change Attributes (custom attributes) that can be used to decorate the cmdlet or its paramters to call out various [types of breaking changes](https://github.com/praries880/azure-powershell/blob/breakingchangeattribute/documentation/breaking-changes/breaking-changes-definition.md).
+Below is description of the various types of Breaking Change Attributes (custom attributes) that can be used to decorate the cmdlet or its parameters to call out various [types of breaking changes](https://github.com/praries880/azure-powershell/blob/breakingchangeattribute/documentation/breaking-changes/breaking-changes-definition.md).
 
 ## The different types of attributes
 
@@ -11,7 +11,7 @@ Below is description of the various types of Breaking Change Attributes (custom
 
 ## Common aspects and properties
 ### GenericBreakingChangeAttribute
-The base attibute which provides the core functionality is called "GenericBreakingChange" All the remaining attrbutes derive from it and provide functionality that makes sense for the scenarios they handle.
+The base attribute which provides the core functionality is called "GenericBreakingChange" All the remaining attributes derive from it and provide functionality that makes sense for the scenarios they handle.
 
 The generic attribute is the most free form of them all and can be used to call out breaking changes that do not fall into the more specialized categories.
 
@@ -23,20 +23,20 @@ All of the attributes have the following common traits:
 
 ### Common Properties
 #### Constructor arguments
-- Each attribute has two additional constructors thet take the following params in addition to the ones the attribute mentions:
+- Each attribute has two additional constructors that take the following params in addition to the ones the attribute mentions:
   - The "deprecatedByVersion" is the version number the breaking change is going to be done in.
-  - The "changeInEfectByDate" is the date the breaking change is goind to go in effet on. The string formati is "mm/dd/yyyy", as an example : "02/25/2018"
+  - The "changeInEffectByDate" is the date the breaking change is going to go in effect on. The string format is "mm/dd/yyyy", as an example : "02/25/2018"
 #### Properties by name
 - Each attribute accepts the following properties by name (all of them are optional) :
   - "ChangeDescription" : This is a free form text field that can be used to describe the breaking change.
-  - Usage changes (you cant have one or the other, you need to speciffy both for the usage message to be generated) :
+  - Usage changes (you cant have one or the other, you need to specify both for the usage message to be generated) :
     - "OldWay" : The way to call the cmdlet before the breaking change takes effect
     - "NewWay" : If there is a workaround to the breaking change, or if the same functionality can be achieved in another manner
 
-The properties "deprecatedByVersion" and "changeInEfectByDate" are infotmation only (for the end user) as of now.
+The properties "deprecatedByVersion" and "changeInEffectByDate" are information only (for the end user) as of now.
 
-#### Supress the breaking change messages at runtime
-- If the user desires to not see the warning messages generated by the attirbutes at runtime, they can set the env variable "SuppressAzurePowerShellBreakingChangeWarnings" to "true".
+#### Suppress the breaking change messages at runtime
+- If the user desires to not see the warning messages generated by the attributes at runtime, they can set the env variable "SuppressAzurePowerShellBreakingChangeWarnings" to "true".
 
 NOTE :
 - The only time you will see the output (at runtime) of an attribute applied to a parameter (property or field) is if the parameter is actually invoked on the cmdline. The breaking change attributes to all parameters that are not invoked are ignored.
@@ -79,7 +79,7 @@ Breaking changes in the cmdlet : Get-SomeObjectA
     The change is expected to take effect from the version : 5.0.0.0
 ```
 
-#### With "deprecatedByVersion" and "changeInEfectByDate"
+#### With "deprecatedByVersion" and "changeInEffectByDate"
 ```cs
     [GenericBreakingChange("Message2", "5.0.0.0", "02/13/2018")]
     [Cmdlet(VerbsCommon.Get, "SomeObjectB"), OutputType(typeof(Foo))]
@@ -202,10 +202,10 @@ The cmdlet is being deprecated. There will be no replacement for it.
 ```
 
 ## CmdletOutputBreakingChangeAttribute
-This attribute is used to call out the breakigng changes with the output of a cmdlet. A few examples are :
+This attribute is used to call out the breaking changes with the output of a cmdlet. A few examples are :
  - The type of the output is changing
  - The Output type is being deprecated
- - Some internal properties in the putput type are being deprecated
+ - Some internal properties in the output type are being deprecated
  - New properties are being introduced to the output type
 
 Note :
@@ -279,7 +279,7 @@ Breaking changes in the cmdlet : Get-SomeObjectB
     'Prop1' 'Prop2'
 ```
 
-#### A few new properties are bing added to the output type
+#### A few new properties are being added to the output type
 ```cs
 [CmdletOutputBreakingChange(typeof(Foo), NewOutputProperties = new String[] {"Prop1", "Prop2"})]
 [Cmdlet(VerbsCommon.Get, "SomeObjectC"), OutputType(typeof(Foo))]
@@ -330,7 +330,7 @@ Breaking changes in the cmdlet : Get-SomeObjectD
 ```
 
 ## CmdletParameterBreakingChangeAttribute
-This attribute is used to call out the breakigng changes relating to a parameter of a cmdlet. A few examples are :
+This attribute is used to call out the breaking changes relating to a parameter of a cmdlet. A few examples are :
  - A parameter is being deprecated
  - A parameter is being replaced
  - A parameter is becoming mandatory
@@ -470,7 +470,7 @@ Breaking changes in the cmdlet : Get-SomeObjectB
 [Cmdlet(VerbsCommon.Get, "SomeObjectA"), OutputType(typeof(Foo))]
 public class GetSomeObjectA : AzureRMCmdlet
 {
-        [CmdletParameterBreakingChange("Param1", IsBecomingMandatory=truec)]
+        [CmdletParameterBreakingChange("Param1", IsBecomingMandatory=true)]
         [Parameter(Mandatory = false)]
         public String Param1;
     protected override void BeginProcessing()

documentation/breaking-changes/breaking-changes-definition.md

@@ -6,9 +6,9 @@ Breaking changes in cmdlets are defined as follows:
 
 # Cmdlets
 - Removing a cmdlet
-  - Use the breaking change attribute ["CmdletDeprecationAttribute"](./breaking-changes-attribute-help.md#cmdletdeprecationattribute), more specificallly the ["cmdlet deprecation without replacement"](./breaking-changes-attribute-help.md#when-there-is-no-replacement-cmdlet) option
+  - Use the breaking change attribute ["CmdletDeprecationAttribute"](./breaking-changes-attribute-help.md#cmdletdeprecationattribute), more specifically the ["cmdlet deprecation without replacement"](./breaking-changes-attribute-help.md#when-there-is-no-replacement-cmdlet) option
 - Changing a cmdlet name without an alias to the original name
-  - Use the breaking change attribute ["CmdletDeprecationAttribute"](./breaking-changes-attribute-help.md#cmdletdeprecationattribute), more specificallly the ["cmdlet deprecation with replacement"](./breaking-changes-attribute-help.md#when-there-is-a-replacement-cmdlet) option
+  - Use the breaking change attribute ["CmdletDeprecationAttribute"](./breaking-changes-attribute-help.md#cmdletdeprecationattribute), more specifically the ["cmdlet deprecation with replacement"](./breaking-changes-attribute-help.md#when-there-is-a-replacement-cmdlet) option
 - Removing or changing a cmdlet alias
   - Use the generic breaking change attribute ["GenericBreakingChangeAttribute"](./breaking-changes-attribute-help.md#genericbreakingchangeattribute) with a [simple message](./breaking-changes-attribute-help.md#with-a-simple-message) calling out the alias that is being deprecated
 - Removing a cmdlet attribute option (`SupportShouldProcess`, `SupportsPaging`)
@@ -25,11 +25,11 @@ Breaking changes in cmdlets are defined as follows:
   - Use the parameter breaking change attribute ["CmdletParameterBreakingChangeAttribute"](./breaking-changes-attribute-help.md#cmdletparameterbreakingchangeattribute) as [described here](./breaking-changes-attribute-help.md#a-parameter-is-being-replaced) to call out a parameter name change.
 - Breaking change in parameter type
   - Use the parameter breaking change attribute ["CmdletParameterBreakingChangeAttribute"](./breaking-changes-attribute-help.md#cmdletparameterbreakingchangeattribute) as [described here](./breaking-changes-attribute-help.md#a-parameter-is-changing-its-type) to call out a parameter name change.
-- Adding a required parameter to an existing parametrer set (adding new parameter sets or adding additional optional parameters is not a breaking change)
-  - An existing parameter becomes mandatry :
+- Adding a required parameter to an existing parameter set (adding new parameter sets or adding additional optional parameters is not a breaking change)
+  - An existing parameter becomes mandatory :
     - Use the parameter breaking change attribute ["CmdletParameterBreakingChangeAttribute"](./breaking-changes-attribute-help.md#cmdletparameterbreakingchangeattribute) as [described here](./breaking-changes-attribute-help.md#a-parameter-is-becoming-mandatory) to call out a parameter becoming mandatory.
   - Adding a new mandatory parameter to a parameter set:
-      - Use the generic breaking change attribute ["GenericBreakingChangeAttribute"](./breaking-changes-attribute-help.md#genericbreakingchangeattribute) with a [custom message](./breaking-changes-attribute-help.md#with-a-simple-message) calling out the new mandatiry parameter that is going to be added to the parameter set.
+      - Use the generic breaking change attribute ["GenericBreakingChangeAttribute"](./breaking-changes-attribute-help.md#genericbreakingchangeattribute) with a [custom message](./breaking-changes-attribute-help.md#with-a-simple-message) calling out the new mandatory parameter that is going to be added to the parameter set.
 - Changing parameter order for parameter sets with ordered parameters
     - Use the generic breaking change attribute ["GenericBreakingChangeAttribute"](./breaking-changes-attribute-help.md#genericbreakingchangeattribute) with a [custom message](./breaking-changes-attribute-help.md#with-a-simple-message) calling out the new order in the parameter set.
 - Removing or changing a parameter alias
@@ -47,12 +47,12 @@ Breaking changes in cmdlets are defined as follows:
     - Use the parameter breaking change attribute ["CmdletParameterBreakingChangeAttribute"](./breaking-changes-attribute-help.md#cmdletparameterbreakingchangeattribute) as [described here](./breaking-changes-attribute-help.md#generic-change-in-a-parameter) to call out the change.
 - Removing properties
   - In the output type
-      - Use the cmdlet output type breaking change attribute ["CmdletOutputBreakingChangeAttribute"](./breaking-changes-attribute-help.md#cmdletoutputbreakingchangeattribute) [as follows](./breaking-changes-attribute-help.md#a-few-properties-in-the-output-type-are-being-deprecated) to call out derecated properties. 
+      - Use the cmdlet output type breaking change attribute ["CmdletOutputBreakingChangeAttribute"](./breaking-changes-attribute-help.md#cmdletoutputbreakingchangeattribute) [as follows](./breaking-changes-attribute-help.md#a-few-properties-in-the-output-type-are-being-deprecated) to call out deprecated properties. 
   - In a parameter
       - Use the parameter breaking change attribute ["CmdletParameterBreakingChangeAttribute"](./breaking-changes-attribute-help.md#cmdletparameterbreakingchangeattribute) as [described here](./breaking-changes-attribute-help.md#generic-change-in-a-parameter) to call out the change.
 - Adding additional required properties
   - In the output type
-      - Use the cmdlet output type breaking change attribute ["CmdletOutputBreakingChangeAttribute"](./breaking-changes-attribute-help.md#cmdletoutputbreakingchangeattribute) [as follows](./breaking-changes-attribute-help.md#a-few-new-properties-are-bing-added-to-the-output-type) to call out derecated properties. 
+      - Use the cmdlet output type breaking change attribute ["CmdletOutputBreakingChangeAttribute"](./breaking-changes-attribute-help.md#cmdletoutputbreakingchangeattribute) [as follows](./breaking-changes-attribute-help.md#a-few-new-properties-are-being-added-to-the-output-type) to call out deprecated properties. 
   - In a parameter
       - Use the parameter breaking change attribute ["CmdletParameterBreakingChangeAttribute"](./breaking-changes-attribute-help.md#cmdletparameterbreakingchangeattribute) as [described here](./breaking-changes-attribute-help.md#generic-change-in-a-parameter) to call out the change.
 - Adding required parameters, changing parameter names, or parameter types for methods or constructors

documentation/breaking-changes/breaking-changes-messages-help.md

@@ -12,7 +12,7 @@ To suppress these warning messages, set the environment variable 'SuppressAzureP
 Set-Item Env:\SuppressAzurePowerShellBreakingChangeWarnings "true"
 ```
 
-More details on breaking change message suppression can be found [here](https://github.com/Azure/azure-powershell/blob/preview/documentation/breaking-changes/breaking-changes-attribute-help.md#supress-the-breaking-change-messages-at-runtime).
+More details on breaking change message suppression can be found [here](https://github.com/Azure/azure-powershell/blob/preview/documentation/breaking-changes/breaking-changes-attribute-help.md#suppress-the-breaking-change-messages-at-runtime).
 
 ## Further reading
 

documentation/development-docs/azure-powershell-developer-guide.md

@@ -105,7 +105,7 @@ msbuild build.proj /t:GenerateHelp
 
 ## Running Static Analysis
 
-To keep consistency across our modules, we've implemented a static analysis system. This verifies various aspects (depdencies, breaking changes, etc.) for your module. Run this command to execute static analysis validation for the built modules:
+To keep consistency across our modules, we've implemented a static analysis system. This verifies various aspects (dependencies, breaking changes, etc.) for your module. Run this command to execute static analysis validation for the built modules:
 
 ```
 msbuild build.proj /t:StaticAnalysis
@@ -302,7 +302,7 @@ Once all of your cmdlets have been created and the appropriate tests have been a
 
 ## Change Log
 
-Whenver you make updates to a project, please make sure to update the corresponding service's `ChangeLog.md` file with a snippet of what you changed under the `Upcoming Release` header. This information is later used for the release notes that goes out with each module the next time they are released, and provides users with more information as to what has changed in the module from the previous release. For more information on updating change logs can be found in [`CONTRIBUTING.md`](../../CONTRIBUTING.md#updating-the-change-log)
+Whenever you make updates to a project, please make sure to update the corresponding service's `ChangeLog.md` file with a snippet of what you changed under the `Upcoming Release` header. This information is later used for the release notes that goes out with each module the next time they are released, and provides users with more information as to what has changed in the module from the previous release. For more information on updating change logs can be found in [`CONTRIBUTING.md`](../../CONTRIBUTING.md#updating-the-change-log)
 
 # Misc
 

documentation/development-docs/design-guidelines/cmdlet-best-practices.md

@@ -30,7 +30,7 @@ From the [_Strongly Encouraged Development Guidelines_](https://docs.microsoft.c
 
 If your cmdlet is performing a **PATCH** operation (_i.e._, a partial replacement on the server), then the cmdlet should use the verb `Update`.
 
-If your cmdlet is performing a **PUT** operation (_i.e._, a full replacement on the server), the the cmdlet should use the verb `Set`.
+If your cmdlet is performing a **PUT** operation (_i.e._, a full replacement on the server), the cmdlet should use the verb `Set`.
 
 #### Cmdlet Alias
 
@@ -136,7 +136,7 @@ To ensure that `-AsJob` is not broken in future changes, please add a test for t
 ````powershell
 $job = Get-AzSubscription -AsJob
 $job | Wait-Job
-$subcriptions = $job | Receive-Job
+$subscriptions = $job | Receive-Job
 ````
 
 To set a custom job name, please use [`SetBackgroupJobDescription`](https://github.com/Azure/azure-powershell-common/blob/master/src/Common/AzurePSCmdlet.cs#L810). The default job description is: "Long Running Operation for '{cmdlet name}' on resource '{resource name}'"

documentation/development-docs/design-guidelines/parameter-best-practices.md

@@ -142,7 +142,7 @@ For PowerShell to determine which parameter set a user is intending to use with
 
 #### Positional Parameters Limit
 
-It is possibile to call a PowerShell cmdlet without providing the parameter names, but just the values you would like to pass through. This is done by specifying the position at which the value of each parameter should be provided by using the `Position` property for a parameter.  However, when there are too many positional parameters in a single parameter set, it can be difficult for the user to remember the exact ordering in which the parameter values should be provided. From the remarks section of [_Parameter Attribute Declaration_](https://docs.microsoft.com/en-us/powershell/developer/cmdlet/parameter-attribute-declaration#remarks):
+It is possible to call a PowerShell cmdlet without providing the parameter names, but just the values you would like to pass through. This is done by specifying the position at which the value of each parameter should be provided by using the `Position` property for a parameter.  However, when there are too many positional parameters in a single parameter set, it can be difficult for the user to remember the exact ordering in which the parameter values should be provided. From the remarks section of [_Parameter Attribute Declaration_](https://docs.microsoft.com/en-us/powershell/developer/cmdlet/parameter-attribute-declaration#remarks):
 
 > _When you specify positional parameters, limit the number of positional parameters in a parameter set to less than five. And, positional parameters do not have to be contiguous. Positions 5, 100, and 250 work the same as positions 0, 1, and 2._