Fixed bug that PGSqlSwooleConnection::affectingStatement() can't work when the sql is wrong. (#5221)

* Return value must be of type int, bool returned

`TypeError: Hyperf\Database\PgSQL\PostgreSqlSwooleExtConnection::affectingStatement(): Return value must be of type int, bool returned`

The hyperf database method has type hint 'int' but Swoole\Coroutine\PostgreSQLStatement::affectedRows() can return bool https://github.com/swoole/swoole-src/blob/master/ext-src/swoole_postgresql_coro.cc#L1242

* Initial fix didn't solve the exception

Seems maybe the $this->run() method might also return bool which mismatches the function return type hint

Co-authored-by: 李铭昕 <[email protected]>

Author: kingIZZZY

src/PostgreSqlSwooleExtConnection.php

@@ -82,11 +82,14 @@ public function affectingStatement(string $query, array $bindings = []): int
             $statement = $this->prepare($query);
             $this->recordsHaveBeenModified();
 
-            $result = $statement->execute($this->prepareBindings($bindings));
+            $statement->execute($this->prepareBindings($bindings));
+
+            $count = $statement->affectedRows();
+            if ($count === false) {
+                throw new QueryException($query, $bindings, new Exception($statement->error, $statement->errCode));
+            }
 
-            $this->recordsHaveBeenModified(
-                ($count = $statement->affectedRows($result)) > 0
-            );
+            $this->recordsHaveBeenModified($count > 0);
 
             return $count;
         });

tests/Cases/PostgreSqlSwooleExtConnectionTest.php

@@ -69,4 +69,24 @@ public function testSelectMethodDuplicateKeyValueException()
         $this->assertIsNumeric($id);
         $this->assertIsNumeric($id2);
     }
+
+    public function testAffectingStatementWithWrongSql()
+    {
+        if (SWOOLE_MAJOR_VERSION < 5) {
+            $this->markTestSkipped('PostgreSql requires Swoole version >= 5.0.0');
+        }
+
+        $connection = $this->connectionFactory->make([
+            'driver' => 'pgsql-swoole',
+            'host' => '127.0.0.1',
+            'port' => 5432,
+            'database' => 'postgres',
+            'username' => 'postgres',
+            'password' => 'postgres',
+        ]);
+
+        $this->expectException(QueryException::class);
+
+        $connection->affectingStatement('UPDATE xx SET x = 1 WHERE id = 1');
+    }
 }