Take CookieJar by ref in from_cookie_jar

s-panferov · s-panferov · commit c53be8ca70d2 · 2014-12-03T00:13:57.000+03:00
diff --git a/src/header/common/cookie.rs b/src/header/common/cookie.rs
@@ -74,7 +74,7 @@ impl Cookies {
 
     /// Extracts all cookies from `CookieJar` and creates Cookie header. 
     /// Useful for clients.
-    pub fn from_cookie_jar(jar: CookieJar) -> Cookies {
+    pub fn from_cookie_jar(jar: &CookieJar) -> Cookies {
         Cookies(jar.iter().collect())
     }
 }
@@ -107,7 +107,7 @@ fn cookie_jar() {
     let cookie = Cookie::new("foo".to_string(), "bar".to_string());
     let cookies = Cookies(vec![cookie]);
     let jar = cookies.to_cookie_jar(&[]);
-    let new_cookies = Cookies::from_cookie_jar(jar);
+    let new_cookies = Cookies::from_cookie_jar(&jar);
 
     assert_eq!(cookies, new_cookies);
 }

Original file line number	Diff line number	Diff line change
`@@ -74,7 +74,7 @@ impl Cookies {`
`74`	`74`
`75`	`75`	/// Extracts all cookies from `CookieJar` and creates Cookie header.
`76`	`76`	`/// Useful for clients.`
`77`		`- pub fn from_cookie_jar(jar: CookieJar) -> Cookies {`
	`77`	`+ pub fn from_cookie_jar(jar: &CookieJar) -> Cookies {`
`78`	`78`	`Cookies(jar.iter().collect())`
`79`	`79`	`}`
`80`	`80`	`}`
`@@ -107,7 +107,7 @@ fn cookie_jar() {`
`107`	`107`	`let cookie = Cookie::new("foo".to_string(), "bar".to_string());`
`108`	`108`	`let cookies = Cookies(vec![cookie]);`
`109`	`109`	`let jar = cookies.to_cookie_jar(&[]);`
`110`		`- let new_cookies = Cookies::from_cookie_jar(jar);`
	`110`	`+ let new_cookies = Cookies::from_cookie_jar(&jar);`
`111`	`111`
`112`	`112`	`assert_eq!(cookies, new_cookies);`
`113`	`113`	`}`