Rustup #153
Merged
Rustup #153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| #[deriving(Clone)] | ||
| struct CaseInsensitive<S: Str>(S); | ||
| //#[deriving(Clone)] | ||
| struct CaseInsensitive(SendStr); |
There was a problem hiding this comment.
This is a good simplification. Using IntoCow here in the relevant places is much better.
There was a problem hiding this comment.
Actually it was only because Cow doesn't yet implement Clone. I've been meaning to pull this into a new crate, and when I do, I'll add the generics back in.
There was a problem hiding this comment.
In a separate crate it the generic makes a lot of sense.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #150
Closes #151
Closes #152