Skip to content

Commit 41cb686

Browse files
[CodeGen] Use range-based for loops (NFC)
1 parent 966d564 commit 41cb686

9 files changed

+14
-28
lines changed

llvm/lib/CodeGen/LiveRangeEdit.cpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -426,8 +426,7 @@ void LiveRangeEdit::eliminateDeadDef(MachineInstr *MI, ToShrinkSet &ToShrink) {
426426

427427
// Erase any virtregs that are now empty and unused. There may be <undef>
428428
// uses around. Keep the empty live range in that case.
429-
for (unsigned i = 0, e = RegsToErase.size(); i != e; ++i) {
430-
Register Reg = RegsToErase[i];
429+
for (Register Reg : RegsToErase) {
431430
if (LIS.hasInterval(Reg) && MRI.reg_nodbg_empty(Reg)) {
432431
ToShrink.remove(&LIS.getInterval(Reg));
433432
eraseVirtReg(Reg);

llvm/lib/CodeGen/MachineInstrBundle.cpp

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -208,8 +208,7 @@ void llvm::finalizeBundle(MachineBasicBlock &MBB,
208208
}
209209

210210
SmallSet<Register, 32> Added;
211-
for (unsigned i = 0, e = LocalDefs.size(); i != e; ++i) {
212-
Register Reg = LocalDefs[i];
211+
for (Register Reg : LocalDefs) {
213212
if (Added.insert(Reg).second) {
214213
// If it's not live beyond end of the bundle, mark it dead.
215214
bool isDead = DeadDefSet.count(Reg) || KilledDefSet.count(Reg);
@@ -218,8 +217,7 @@ void llvm::finalizeBundle(MachineBasicBlock &MBB,
218217
}
219218
}
220219

221-
for (unsigned i = 0, e = ExternUses.size(); i != e; ++i) {
222-
Register Reg = ExternUses[i];
220+
for (Register Reg : ExternUses) {
223221
bool isKill = KilledUseSet.count(Reg);
224222
bool isUndef = UndefUseSet.count(Reg);
225223
MIB.addReg(Reg, getKillRegState(isKill) | getUndefRegState(isUndef) |

llvm/lib/CodeGen/RegisterClassInfo.cpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -165,8 +165,7 @@ void RegisterClassInfo::compute(const TargetRegisterClass *RC) const {
165165
assert(RCI.NumRegs <= NumRegs && "Allocation order larger than regclass");
166166

167167
// CSR aliases go after the volatile registers, preserve the target's order.
168-
for (unsigned i = 0, e = CSRAlias.size(); i != e; ++i) {
169-
unsigned PhysReg = CSRAlias[i];
168+
for (unsigned PhysReg : CSRAlias) {
170169
uint8_t Cost = RegCosts[PhysReg];
171170
if (Cost != LastCost)
172171
LastCostChange = N;

llvm/lib/CodeGen/RegisterCoalescer.cpp

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1621,8 +1621,7 @@ bool RegisterCoalescer::reMaterializeTrivialDef(const CoalescerPair &CP,
16211621
NewMI.addOperand(MO);
16221622

16231623
SlotIndex NewMIIdx = LIS->getInstructionIndex(NewMI);
1624-
for (unsigned i = 0, e = NewMIImplDefs.size(); i != e; ++i) {
1625-
MCRegister Reg = NewMIImplDefs[i];
1624+
for (MCRegister Reg : NewMIImplDefs) {
16261625
for (MCRegUnit Unit : TRI->regunits(Reg))
16271626
if (LiveRange *LR = LIS->getCachedRegUnit(Unit))
16281627
LR->createDeadDef(NewMIIdx.getRegSlot(), LIS->getVNInfoAllocator());
@@ -4269,8 +4268,7 @@ bool RegisterCoalescer::runOnMachineFunction(MachineFunction &fn) {
42694268
InflateRegs.end());
42704269
LLVM_DEBUG(dbgs() << "Trying to inflate " << InflateRegs.size()
42714270
<< " regs.\n");
4272-
for (unsigned i = 0, e = InflateRegs.size(); i != e; ++i) {
4273-
Register Reg = InflateRegs[i];
4271+
for (Register Reg : InflateRegs) {
42744272
if (MRI->reg_nodbg_empty(Reg))
42754273
continue;
42764274
if (MRI->recomputeRegClass(Reg)) {

llvm/lib/CodeGen/SelectionDAG/FastISel.cpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1000,8 +1000,7 @@ bool FastISel::lowerCallTo(CallLoweringInfo &CLI) {
10001000
if (!CanLowerReturn)
10011001
return false;
10021002

1003-
for (unsigned I = 0, E = RetTys.size(); I != E; ++I) {
1004-
EVT VT = RetTys[I];
1003+
for (EVT VT : RetTys) {
10051004
MVT RegisterVT = TLI.getRegisterType(CLI.RetTy->getContext(), VT);
10061005
unsigned NumRegs = TLI.getNumRegisters(CLI.RetTy->getContext(), VT);
10071006
for (unsigned i = 0; i != NumRegs; ++i) {

llvm/lib/CodeGen/SelectionDAG/FunctionLoweringInfo.cpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -377,8 +377,7 @@ Register FunctionLoweringInfo::CreateRegs(Type *Ty, bool isDivergent) {
377377
ComputeValueVTs(*TLI, MF->getDataLayout(), Ty, ValueVTs);
378378

379379
Register FirstReg;
380-
for (unsigned Value = 0, e = ValueVTs.size(); Value != e; ++Value) {
381-
EVT ValueVT = ValueVTs[Value];
380+
for (EVT ValueVT : ValueVTs) {
382381
MVT RegisterVT = TLI->getRegisterType(Ty->getContext(), ValueVT);
383382

384383
unsigned NumRegs = TLI->getNumRegisters(Ty->getContext(), ValueVT);

llvm/lib/CodeGen/SelectionDAG/ScheduleDAGFast.cpp

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -296,28 +296,24 @@ SUnit *ScheduleDAGFast::CopyAndMoveSuccessors(SUnit *SU) {
296296
if (isNewLoad)
297297
AddPred(LoadSU, ChainPred);
298298
}
299-
for (unsigned i = 0, e = LoadPreds.size(); i != e; ++i) {
300-
const SDep &Pred = LoadPreds[i];
299+
for (const SDep &Pred : LoadPreds) {
301300
RemovePred(SU, Pred);
302301
if (isNewLoad) {
303302
AddPred(LoadSU, Pred);
304303
}
305304
}
306-
for (unsigned i = 0, e = NodePreds.size(); i != e; ++i) {
307-
const SDep &Pred = NodePreds[i];
305+
for (const SDep &Pred : NodePreds) {
308306
RemovePred(SU, Pred);
309307
AddPred(NewSU, Pred);
310308
}
311-
for (unsigned i = 0, e = NodeSuccs.size(); i != e; ++i) {
312-
SDep D = NodeSuccs[i];
309+
for (SDep D : NodeSuccs) {
313310
SUnit *SuccDep = D.getSUnit();
314311
D.setSUnit(SU);
315312
RemovePred(SuccDep, D);
316313
D.setSUnit(NewSU);
317314
AddPred(SuccDep, D);
318315
}
319-
for (unsigned i = 0, e = ChainSuccs.size(); i != e; ++i) {
320-
SDep D = ChainSuccs[i];
316+
for (SDep D : ChainSuccs) {
321317
SUnit *SuccDep = D.getSUnit();
322318
D.setSUnit(SU);
323319
RemovePred(SuccDep, D);

llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10627,8 +10627,7 @@ TargetLowering::LowerCallTo(TargetLowering::CallLoweringInfo &CLI) const {
1062710627
else if (CLI.RetZExt)
1062810628
AssertOp = ISD::AssertZext;
1062910629
unsigned CurReg = 0;
10630-
for (unsigned I = 0, E = RetTys.size(); I != E; ++I) {
10631-
EVT VT = RetTys[I];
10630+
for (EVT VT : RetTys) {
1063210631
MVT RegisterVT = getRegisterTypeForCallingConv(CLI.RetTy->getContext(),
1063310632
CLI.CallConv, VT);
1063410633
unsigned NumRegs = getNumRegistersForCallingConv(CLI.RetTy->getContext(),

llvm/lib/CodeGen/TwoAddressInstructionPass.cpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1124,8 +1124,7 @@ bool TwoAddressInstructionPass::rescheduleKillAboveMI(
11241124
}
11251125
}
11261126

1127-
for (unsigned i = 0, e = OtherDefs.size(); i != e; ++i) {
1128-
Register MOReg = OtherDefs[i];
1127+
for (Register MOReg : OtherDefs) {
11291128
if (regOverlapsSet(Uses, MOReg))
11301129
return false;
11311130
if (MOReg.isPhysical() && regOverlapsSet(LiveDefs, MOReg))

0 commit comments

Comments
 (0)