Skip to content

Commit 9714127

Browse files
authored
[lldb] Fix TestRealDefinition (swiftlang#7564)
For a while, tests were run with `target.prefer-dynamic-value` overridden to `no-dynamic-values` – but the override was removed in [D132382](https://reviews.llvm.org/D132382). At that time, tests that failed were individually opted in to `no-dynamic-values`. I don't recall specifics about `TestRealDefinition`, but it currently fails with `no-dynamic-values`, and that is correct behavior. This change removes the `no-dynamic-values` override.
1 parent 9cb2117 commit 9714127

File tree

1 file changed

+2
-6
lines changed

1 file changed

+2
-6
lines changed

lldb/test/API/lang/objc/real-definition/TestRealDefinition.py

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -27,13 +27,11 @@ def test_frame_var_after_stop_at_interface(self):
2727
# Run at stop at main
2828
lldbutil.check_breakpoint(self, bpno=1, expected_hit_count=1)
2929

30-
self.runCmd("settings set target.prefer-dynamic-value no-dynamic-values")
31-
3230
# This should display correctly.
3331
self.expect(
3432
"frame variable foo->_bar->_hidden_ivar",
3533
VARIABLES_DISPLAYED_CORRECTLY,
36-
substrs=["(NSString *)", "foo->_bar->_hidden_ivar = 0x"],
34+
substrs=["foo->_bar->_hidden_ivar = 0x"],
3735
)
3836

3937
def test_frame_var_after_stop_at_implementation(self):
@@ -54,11 +52,9 @@ def test_frame_var_after_stop_at_implementation(self):
5452
# Run at stop at main
5553
lldbutil.check_breakpoint(self, bpno=1, expected_hit_count=1)
5654

57-
self.runCmd("settings set target.prefer-dynamic-value no-dynamic-values")
58-
5955
# This should display correctly.
6056
self.expect(
6157
"frame variable foo->_bar->_hidden_ivar",
6258
VARIABLES_DISPLAYED_CORRECTLY,
63-
substrs=["(NSString *)", "foo->_bar->_hidden_ivar = 0x"],
59+
substrs=["foo->_bar->_hidden_ivar = 0x"],
6460
)

0 commit comments

Comments
 (0)