Fix leak in Zend/tests/bug64720.phpt

iluuu1994 · iluuu1994 · commit 4eddbc52eec9 · 2024-12-13T11:12:43.000+01:00
Don't rely on the cycle collector for objects released in destructor.
diff --git a/Zend/zend_objects_API.c b/Zend/zend_objects_API.c
@@ -55,7 +55,9 @@ ZEND_API void ZEND_FASTCALL zend_objects_store_call_destructors(zend_objects_sto
 							|| obj->ce->destructor) {
 						GC_ADDREF(obj);
 						obj->handlers->dtor_obj(obj);
-						GC_DELREF(obj);
+						if (UNEXPECTED(GC_DELREF(obj) == 0)) {
+							zend_objects_store_del(obj);
+						}
 					}
 				}
 			}

Original file line number	Diff line number	Diff line change
`@@ -55,7 +55,9 @@ ZEND_API void ZEND_FASTCALL zend_objects_store_call_destructors(zend_objects_sto`
`55`	`55`	`\|\| obj->ce->destructor) {`
`56`	`56`	`GC_ADDREF(obj);`
`57`	`57`	`obj->handlers->dtor_obj(obj);`
`58`		`- GC_DELREF(obj);`
	`58`	`+ if (UNEXPECTED(GC_DELREF(obj) == 0)) {`
	`59`	`+ zend_objects_store_del(obj);`
	`60`	`+ }`
`59`	`61`	`}`
`60`	`62`	`}`
`61`	`63`	`}`