Skip to content

Commit 10913e7

Browse files
committed
[resolvers] [*] [fix] restore node 6 compatibility
See 69fce5c and 8c155ba#r123814192
1 parent 69fce5c commit 10913e7

File tree

3 files changed

+32
-32
lines changed

3 files changed

+32
-32
lines changed

.eslintrc

Lines changed: 25 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -189,37 +189,17 @@
189189
"no-console": "off",
190190
},
191191
},
192-
{
193-
"files": "resolvers/**",
194-
"env": {
195-
"es6": false,
196-
},
197-
},
198-
{
199-
"files": "resolvers/webpack/**",
200-
"rules": {
201-
"no-console": 1,
202-
"prefer-template": 0,
203-
"prefer-object-spread": 0,
204-
"prefer-rest-params": 0,
205-
},
206-
"env": {
207-
"es6": true,
208-
},
209-
},
210192
{
211193
"files": [
212-
"resolvers/*/test/**/*",
194+
"resolvers/**",
195+
"utils/**",
213196
],
214197
"env": {
215-
"mocha": true,
216-
"es6": false
198+
"es6": false,
217199
},
218-
},
219-
{
220-
"files": "utils/**",
221200
"parserOptions": {
222-
"ecmaVersion": 6,
201+
"sourceType": "module",
202+
"ecmaVersion": 2016,
223203
},
224204
"rules": {
225205
"comma-dangle": ["error", {
@@ -229,11 +209,31 @@
229209
"exports": "always-multiline",
230210
"functions": "never"
231211
}],
212+
"prefer-destructuring": "warn",
232213
"prefer-object-spread": "off",
214+
"prefer-rest-params": "off",
215+
"prefer-spread": "warn",
233216
"prefer-template": "off",
217+
}
218+
},
219+
{
220+
"files": [
221+
"resolvers/webpack/**",
222+
"utils/**",
223+
],
224+
"rules": {
234225
"no-console": 1,
235226
},
236227
},
228+
{
229+
"files": [
230+
"resolvers/*/test/**/*",
231+
],
232+
"env": {
233+
"mocha": true,
234+
"es6": false
235+
},
236+
},
237237
{
238238
"files": "tests/**",
239239
"env": {

resolvers/node/index.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -29,14 +29,14 @@ exports.resolve = function (source, file, config) {
2929
};
3030

3131
function opts(file, config, packageFilter) {
32-
return { // more closely matches Node (#333)
32+
return Object.assign({ // more closely matches Node (#333)
3333
// plus 'mjs' for native modules! (#939)
3434
extensions: ['.mjs', '.js', '.json', '.node'],
35-
...config,
35+
}, config, {
3636
// path.resolve will handle paths relative to CWD
3737
basedir: path.dirname(path.resolve(file)),
3838
packageFilter,
39-
};
39+
});
4040
}
4141

4242
function identity(x) { return x; }

resolvers/webpack/index.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -270,18 +270,18 @@ function createWebpack1ResolveSync(webpackRequire, resolveConfig, plugins) {
270270
makeRootPlugin(ModulesInRootPlugin, 'module', resolveConfig.root),
271271
new ModulesInDirectoriesPlugin(
272272
'module',
273-
resolveConfig.modulesDirectories || resolveConfig.modules || ['web_modules', 'node_modules'],
273+
resolveConfig.modulesDirectories || resolveConfig.modules || ['web_modules', 'node_modules']
274274
),
275275
makeRootPlugin(ModulesInRootPlugin, 'module', resolveConfig.fallback),
276276
new ModuleAsFilePlugin('module'),
277277
new ModuleAsDirectoryPlugin('module'),
278278
new DirectoryDescriptionFilePlugin(
279279
'package.json',
280-
['module', 'jsnext:main'].concat(resolveConfig.packageMains || webpack1DefaultMains),
280+
['module', 'jsnext:main'].concat(resolveConfig.packageMains || webpack1DefaultMains)
281281
),
282282
new DirectoryDefaultFilePlugin(['index']),
283283
new FileAppendPlugin(resolveConfig.extensions || ['', '.webpack.js', '.web.js', '.js']),
284-
new ResultSymlinkPlugin(),
284+
new ResultSymlinkPlugin()
285285
);
286286

287287
const resolvePlugins = [];
@@ -419,7 +419,7 @@ function findConfigPath(configPath, packageDir) {
419419
}
420420

421421
const maybePath = path.resolve(
422-
path.join(packageDir, 'webpack.config' + maybeExtension),
422+
path.join(packageDir, 'webpack.config' + maybeExtension)
423423
);
424424
if (fs.existsSync(maybePath)) {
425425
configPath = maybePath;

0 commit comments

Comments
 (0)