Skip to content

Commit 14ef6c5

Browse files
[mlir][cmake] Enable -Wundef.
This is another follow-up of llvm#83004, which fixed a bug due to some macros not being defined in some situations. By raising warnings on undefined macros, this kind of bug is less likely to be introduced. Similar to llvm#83004, the fix is probably adding an include to `mlir-config.h` (and potentially defining the macro there).
1 parent ff66e9b commit 14ef6c5

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

mlir/CMakeLists.txt

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -70,6 +70,12 @@ endif()
7070
check_c_compiler_flag("-Werror=implicit-function-declaration" C_SUPPORTS_WERROR_IMPLICIT_FUNCTION_DECLARATION)
7171
append_if(C_SUPPORTS_WERROR_IMPLICIT_FUNCTION_DECLARATION "-Werror=implicit-function-declaration" CMAKE_C_FLAGS)
7272

73+
# Warn on undefined macros. This is often an indication that an include to
74+
# `mlir-config.h` or similar is missing.
75+
check_c_compiler_flag("-Wundef" C_SUPPORTS_WUNDEF)
76+
append_if(C_SUPPORTS_WUNDEF "-Wundef" CMAKE_C_FLAGS)
77+
append_if(C_SUPPORTS_WUNDEF "-Wundef" CMAKE_CXX_FLAGS)
78+
7379
# Forbid mismatch between declaration and definition for class vs struct. This is
7480
# harmless on Unix systems, but it'll be a ticking bomb for MSVC/Windows systems
7581
# where it creeps into the ABI.

0 commit comments

Comments
 (0)