Allowance interface tweaks #80
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Evalir
approved these changes
Feb 22, 2025
Comment on lines
+40
to
+44
| In order to maintain this relationship (that trevm MINOR == revm MAJOR) we will | ||
| sometimes make breaking changes in patch versions. This is technically semver | ||
| compliant pre-1.0, but will cause build breakage downstream for users of those | ||
| features. We will take care to document breaking changes in patch releases | ||
| via github release notes. |
There was a problem hiding this comment.
good note, this is fine and IMO helpful for users.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the allowance interface to make it usable when no TX is loaded, for any account.
This is a non-semver breaking change, and i have expanded on repo policy there in the readme.
includes drive-by cleanup of lints and compilation errors for no-default-features and all features