Skip to content

feat: traits for things that behave like State #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 27, 2025

Conversation

prestwich
Copy link
Member

@prestwich prestwich commented Feb 27, 2025

Add traits that abstracts over State and ConcurrentState so that we can simplify trevm impls and do cool things like have try_finish on Evm<Arc<ConcurrentState>>

Copy link
Member Author

prestwich commented Feb 27, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Feb 27, 2025
@prestwich prestwich force-pushed the prestwich/state-traits branch from 10e0366 to a49742c Compare February 27, 2025 17:28
@prestwich prestwich marked this pull request as ready for review February 27, 2025 17:28
@prestwich prestwich changed the base branch from prestwich/trim-commit-bounds to main February 27, 2025 18:20
@prestwich prestwich enabled auto-merge (squash) February 27, 2025 18:21
Copy link
Member

@Evalir Evalir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

doc: add note
@prestwich prestwich force-pushed the prestwich/state-traits branch from cafcb5d to 557fb6f Compare February 27, 2025 23:23
@prestwich prestwich merged commit 21f33a7 into main Feb 27, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants