Skip to content

Commit c7308ba

Browse files
nielsdosremicollet
authored andcommitted
Apache only generates REDIRECT_STATUS, so explicitly check for that if the server name is Apache, don't allow other variable names. Furthermore, redirect.so and Netscape no longer exist, so remove those entries as we can't check their server name anymore. We now also check for the configuration override *first* such that it always take precedence. This would allow for a mitigation path if something like this happens in the future. (cherry picked from commit 48808d98f4fc2a05193cdcc1aedd6c66816450f1) (cherry picked from commit 8aa748e)
1 parent 1158d06 commit c7308ba

File tree

1 file changed

+11
-12
lines changed

1 file changed

+11
-12
lines changed

sapi/cgi/cgi_main.c

Lines changed: 11 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1939,18 +1939,17 @@ int main(int argc, char *argv[])
19391939

19401940
/* check force_cgi after startup, so we have proper output */
19411941
if (cgi && CGIG(force_redirect)) {
1942-
/* Apache will generate REDIRECT_STATUS,
1943-
* Netscape and redirect.so will generate HTTP_REDIRECT_STATUS.
1944-
* redirect.so and installation instructions available from
1945-
* http://www.koehntopp.de/php.
1946-
1947-
*/
1948-
if (!getenv("REDIRECT_STATUS") &&
1949-
!getenv ("HTTP_REDIRECT_STATUS") &&
1950-
/* this is to allow a different env var to be configured
1951-
* in case some server does something different than above */
1952-
(!CGIG(redirect_status_env) || !getenv(CGIG(redirect_status_env)))
1953-
) {
1942+
/* This is to allow a different environment variable to be configured
1943+
* in case the we cannot auto-detect which environment variable to use.
1944+
* Checking this first to allow user overrides in case the environment
1945+
* variable can be set by an untrusted party. */
1946+
const char *redirect_status_env = CGIG(redirect_status_env);
1947+
if (!redirect_status_env) {
1948+
/* Apache will generate REDIRECT_STATUS. */
1949+
redirect_status_env = "REDIRECT_STATUS";
1950+
}
1951+
1952+
if (!getenv(redirect_status_env)) {
19541953
zend_try {
19551954
SG(sapi_headers).http_response_code = 400;
19561955
PUTS("<b>Security Alert!</b> The PHP CGI cannot be accessed directly.\n\n\

0 commit comments

Comments
 (0)