Skip to content
This repository was archived by the owner on Aug 1, 2023. It is now read-only.

[GH-208] Add node-ipc for wallet. #209

Merged
merged 7 commits into from
Aug 3, 2019
Merged

[GH-208] Add node-ipc for wallet. #209

merged 7 commits into from
Aug 3, 2019

Conversation

ksaric
Copy link
Contributor

@ksaric ksaric commented Jul 2, 2019 •
edited by CodiePP
Loading

#208

termed "DaedalusIPC"

@ksaric ksaric requested review from rvl, KtorZ, CodiePP and HirotoShioi July 2, 2019 11:21
@ksaric ksaric requested a review from erikd as a code owner July 2, 2019 11:21
rvl
rvl previously requested changes Jul 2, 2019
View reviewed changes
Copy link
Contributor

@rvl rvl left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed a few things that needed cleaning up in this code.

I will make a PR on this PR tomorrow.

@rvl rvl mentioned this pull request Jul 5, 2019
Merged
@CodiePP
Copy link
Contributor

CodiePP commented Jul 12, 2019

this PR is now rotting for almost two weeks! and it's getting complicated with the proposed changes by @rvl being in another PR against this one. Could this be sped up a bit, please!

@rvl
DaedalusIPC clean ups (#213)
c12e0b0 
* DaedalusIPC: Clean it up a bit

* Add a test program for DaedalusIPC
@rvl rvl mentioned this pull request Jul 13, 2019
Merged
@rvl rvl dismissed their stale review July 13, 2019 09:03

Fixed

@rvl
Copy link
Contributor

rvl commented Jul 14, 2019

I have merged in the clean ups from #213. The PR #221 adds a nodejs test case.

ksaric and others added 2 commits July 28, 2019 18:02
@ksaric
Merge branch 'master' into ksaric/GH-208
353f13b
@rvl
Add DaedalusIPC nodejs test (#221)
9d0e741 
* tests: Add DaedalusIPC spec

This uses nodejs to run daedalusIPC.

* nix: Update and regenerate
@rvl
Copy link
Contributor

rvl commented Aug 2, 2019

This is ready to merge. @ksaric @CodiePP
The Hydra failures are due to broken MacOS builders. The tests.ipc.x86_64-darwin job has already been failing on master, so the failure is not caused by this code change.

@ksaric ksaric merged commit ba4fb01 into master Aug 3, 2019
@ksaric ksaric deleted the ksaric/GH-208 branch August 3, 2019 13:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rvl rvl rvl left review comments

@KtorZ KtorZ Awaiting requested review from KtorZ

@CodiePP CodiePP Awaiting requested review from CodiePP

@HirotoShioi HirotoShioi Awaiting requested review from HirotoShioi

@erikd erikd Awaiting requested review from erikd erikd is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
NOD006 Maximum integration with walle...
Development

Successfully merging this pull request may close these issues.
3 participants
@ksaric @CodiePP @rvl