Skip to content

update-stackage: update submodules on fresh checkout #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 21, 2019

Conversation

jbgi
Copy link
Contributor

@jbgi jbgi commented Mar 21, 2019

otherwise we are missing out on new lts/nightlies.

Also:

  • skip re-generation for existing resolver
  • better lts ordering in ltss.nix

 otherwise we are missing out on new lts/nightlies.

 Also:
 - skip re-generation for existing resolver
 - better lts ordering in ltss.nix
@jbgi jbgi requested a review from rvl March 21, 2019 22:46
@jbgi
Copy link
Contributor Author

jbgi commented Mar 21, 2019

I am also wondering if we should use iohk nixpkgs fork rather than nixos channels for those update script, to make better use of caching? or use cachix?

@jbgi jbgi requested a review from angerman March 21, 2019 22:51
Copy link
Contributor

@rvl rvl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks. I'm running a test build here.

@rvl
Copy link
Contributor

rvl commented Mar 21, 2019

I am also wondering if we should use iohk nixpkgs fork rather than nixos channels for those update script, to make better use of caching? or use cachix?

Caching would be good (with IOHK cache), but we should not add a dependency on iohk nixpkgs in haskell.nix.

We now have a Hydra jobset in release.nix. Once we add pinning of nixpkgs, then caching will work.

Also, can you join #nix-tools on Freenode IRC?

@rvl rvl merged commit fedbc8e into master Mar 21, 2019
@rvl rvl deleted the update-stackage-fixes branch March 21, 2019 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants