Skip to content

Commit 31f430d

Browse files
committed
ETCM-167: Default derivation policy.
1 parent 2ee1901 commit 31f430d

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

src/main/scala/io/iohk/ethereum/network/discovery/codecs/RLPCodecs.scala

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,6 @@ import io.iohk.ethereum.rlp.RLPDecoder
2121
/** RLP codecs based on https://github.com/ethereum/devp2p/blob/master/discv4.md */
2222
object RLPCodecs {
2323

24-
implicit val policy: DerivationPolicy = DerivationPolicy(omitTrailingOptionals = true)
25-
2624
implicit val inetAddressRLPCodec: RLPCodec[InetAddress] =
2725
implicitly[RLPCodec[Array[Byte]]].xmap(InetAddress.getByAddress(_), _.getAddress)
2826

src/main/scala/io/iohk/ethereum/rlp/RLPImplicitDerivations.scala

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,9 @@ object RLPImplicitDerivations {
1414
// as opposed to a list of 0 or 1 items.
1515
omitTrailingOptionals: Boolean
1616
)
17+
object DerivationPolicy {
18+
val default = DerivationPolicy(omitTrailingOptionals = true)
19+
}
1720

1821
/** Support introspecting on what happened during encoding the tail. */
1922
case class FieldInfo(isOptional: Boolean)
@@ -70,7 +73,7 @@ object RLPImplicitDerivations {
7073
hEncoder: Lazy[RLPEncoder[H]],
7174
tEncoder: Lazy[RLPListEncoder[T]],
7275
ev: H <:< Option[_],
73-
policy: DerivationPolicy
76+
policy: DerivationPolicy = DerivationPolicy.default
7477
): RLPListEncoder[FieldType[K, H] :: T] = {
7578
val hInfo = FieldInfo(isOptional = true)
7679
// Create an encoder that takes a list of field values.
@@ -142,7 +145,7 @@ object RLPImplicitDerivations {
142145
// contextual error messages.
143146
witness: Witness.Aux[K],
144147
ev: Option[V] =:= H,
145-
policy: DerivationPolicy
148+
policy: DerivationPolicy = DerivationPolicy.default
146149
): RLPListDecoder[FieldType[K, H] :: T] = {
147150
val fieldName: String = witness.value.name
148151
val hInfo = FieldInfo(isOptional = true)

0 commit comments

Comments
 (0)