Skip to content

Commit 46260ae

Browse files
committed
[ETCM-921] Code review feedback changes
1 parent 9ec1402 commit 46260ae

File tree

2 files changed

+1
-8
lines changed

2 files changed

+1
-8
lines changed

src/main/scala/io/iohk/ethereum/network/p2p/messages/BaseETH6XMessages.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -254,7 +254,6 @@ object BaseETH6XMessages {
254254
implicit class SignedTransactionRlpEncodableDec(val rlpEncodeable: RLPEncodeable) extends AnyVal {
255255

256256
// scalastyle:off method.length
257-
258257
/** A signed transaction is either a RLPList representing a Legacy SignedTransaction
259258
* or a PrefixedRLPEncodable(transactionType, RLPList of typed transaction envelope)
260259
*
@@ -318,6 +317,7 @@ object BaseETH6XMessages {
318317
throw new RuntimeException("Cannot decode SignedTransaction")
319318
}
320319
}
320+
// scalastyle:on method.length
321321

322322
implicit class SignedTransactionDec(val bytes: Array[Byte]) extends AnyVal {
323323
def toSignedTransaction: SignedTransaction = {

src/test/scala/io/iohk/ethereum/domain/TransactionSpec.scala

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -132,11 +132,4 @@ class TransactionSpec
132132
x shouldBe expected
133133

134134
}
135-
it should "correctly serialize to EIP1598 rlp" in {}
136-
137-
// plan:
138-
// TODO ReceiptSpec
139-
// TODO decode string to case class
140-
// TODO adjust runVM in ledger
141-
// TODO align how geth and besu treat typed transactions when sent via rpc before magneto HF
142135
}

0 commit comments

Comments
 (0)