[ETCM-102] Break connection in case of decoding failure

KonradStaniec · KonradStaniec · commit 76dedc0faaad · 2020-09-21T14:05:29.000+02:00
diff --git a/src/main/scala/io/iohk/ethereum/network/rlpx/RLPxConnectionHandler.scala b/src/main/scala/io/iohk/ethereum/network/rlpx/RLPxConnectionHandler.scala
@@ -163,6 +163,8 @@ class RLPxConnectionHandler(
 
       case Failure(ex) =>
         log.debug(s"Cannot decode message from $peerId, because of ${ex.getMessage}")
+        // break connection in case of failed decoding, to avoid attack which would send us garbage
+        context stop self
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -163,6 +163,8 @@ class RLPxConnectionHandler(`
`163`	`163`
`164`	`164`	`case Failure(ex) =>`
`165`	`165`	`log.debug(s"Cannot decode message from $peerId, because of ${ex.getMessage}")`
	`166`	`+ // break connection in case of failed decoding, to avoid attack which would send us garbage`
	`167`	`+ context stop self`
`166`	`168`	`}`
`167`	`169`
`168`	`170`	`/**`