[FIX] Update last block when appending full new block to queue

Author: KonradStaniec

src/main/scala/io/iohk/ethereum/blockchain/sync/regular/BlockFetcherState.scala

@@ -92,6 +92,7 @@ case class BlockFetcherState(
   def appendNewBlock(block: Block, fromPeer: PeerId): BlockFetcherState =
     withPeerForBlocks(fromPeer, Seq(block.header.number))
       .withPossibleNewTopAt(block.number)
+      .withLastBlock(block.number)
       .copy(
         readyBlocks = readyBlocks.enqueue(block),
         waitingHeaders = waitingHeaders.filter(block.number != _.number)

src/test/scala/io/iohk/ethereum/blockchain/sync/regular/BlockFetcherStateSpec.scala

@@ -2,8 +2,10 @@ package io.iohk.ethereum.blockchain.sync.regular
 
 import akka.actor.ActorSystem
 import akka.testkit.{TestKit, TestProbe}
+import io.iohk.ethereum.domain.Block
 import org.scalatest.{Matchers, WordSpecLike}
-
+import io.iohk.ethereum.Fixtures.Blocks.ValidBlock
+import io.iohk.ethereum.network.PeerId
 
 class BlockFetcherStateSpec extends TestKit(ActorSystem()) with WordSpecLike with Matchers {
   "BlockFetcherState" when {
@@ -15,5 +17,21 @@ class BlockFetcherStateSpec extends TestKit(ActorSystem()) with WordSpecLike wit
         actual.lastBlock shouldBe 0
       }
     }
+
+    "appending last full block" should {
+      "update last block" in {
+        val importer = TestProbe().ref
+        val currentBestBlock = Block(ValidBlock.header, ValidBlock.body)
+        val newBestBlock = Block(ValidBlock.header.copy(number = ValidBlock.header.number + 1), ValidBlock.body)
+        val fakePeerId = PeerId("fake")
+
+        val currentState = BlockFetcherState.initial(importer, currentBestBlock.number)
+        val newState = currentState.appendNewBlock(newBestBlock, fakePeerId)
+        newState.lastBlock shouldEqual newBestBlock.number
+        newState.blockProviders(newBestBlock.number) shouldEqual fakePeerId
+        newState.knownTop shouldEqual newBestBlock.number
+      }
+    }
+
   }
 }