review fixes

rename putBestBlockData to putBestBlockInfo

avoid using magic number for block number in test

Author: Aurélien Richez

src/main/scala/io/iohk/ethereum/db/storage/AppStateStorage.scala

@@ -37,7 +37,7 @@ class AppStateStorage(val dataSource: DataSource) extends TransactionalKeyValueS
       getBigInt(Keys.BestBlockNumber)
     )
 
-  def putBestBlockData(b: BestBlockInfo): DataSourceBatchUpdate =
+  def putBestBlockInfo(b: BestBlockInfo): DataSourceBatchUpdate =
     put(Keys.BestBlockNumber, b.number.toString)
       .and(put(Keys.BestBlockHash, Hex.toHexString(b.hash.toArray)))
 

src/main/scala/io/iohk/ethereum/domain/Blockchain.scala

@@ -220,7 +220,7 @@ class BlockchainImpl(
      */
     val bestBlockNumberUpdates =
       if (appStateStorage.getBestBlockNumber() > potentialNewBestBlockNumber)
-        appStateStorage.putBestBlockData(BestBlockInfo(potentialNewBestBlockHash, potentialNewBestBlockNumber))
+        appStateStorage.putBestBlockInfo(BestBlockInfo(potentialNewBestBlockHash, potentialNewBestBlockNumber))
       else appStateStorage.emptyBatchUpdate
     val latestCheckpointNumberUpdates =
       if (appStateStorage.getLatestCheckpointBlockNumber() > newLatestCheckpointNumber)

src/main/scala/io/iohk/ethereum/domain/BlockchainWriter.scala

@@ -111,7 +111,7 @@ class BlockchainWriter(
     )
 
     appStateStorage
-      .putBestBlockData(currentBestBlockInfo)
+      .putBestBlockInfo(currentBestBlockInfo)
       .and(appStateStorage.putLatestCheckpointBlockNumber(currentBestCheckpointNumber))
       .commit()
   }

src/test/scala/io/iohk/ethereum/consensus/ConsensusSpec.scala

@@ -221,7 +221,7 @@ class ConsensusSpec extends AnyFlatSpec with Matchers with ScalaFutures {
 
     val ancestorForValidation: Block = getBlock(0, difficulty = 1)
     storagesInstance.storages.appStateStorage
-      .putBestBlockData(BestBlockInfo(ancestorForValidation.hash, ancestorForValidation.number))
+      .putBestBlockInfo(BestBlockInfo(ancestorForValidation.hash, ancestorForValidation.number))
       .commit()
     blockchainWriter.save(ancestorForValidation, Nil, ChainWeight.totalDifficultyOnly(1), saveAsBestBlock = false)
 

src/test/scala/io/iohk/ethereum/jsonrpc/JsonRpcControllerEthSpec.scala

@@ -416,7 +416,7 @@ class JsonRpcControllerEthSpec
     private val block: Block =
       Block(Fixtures.Blocks.Block3125369.header.copy(number = 42), Fixtures.Blocks.Block3125369.body)
     blockchainWriter.storeBlock(block).commit()
-    blockchain.saveBestKnownBlocks(block.hash, 42)
+    blockchain.saveBestKnownBlocks(block.hash, block.number)
 
     val request: JsonRpcRequest = newJsonRpcRequest("eth_gasPrice")