[ETCM-921] code review feedback

Author: strauss-m

src/main/scala/io/iohk/ethereum/network/p2p/messages/BaseETH6XMessages.scala

@@ -13,6 +13,7 @@ import io.iohk.ethereum.rlp.RLPImplicitConversions._
 import io.iohk.ethereum.rlp.RLPImplicits._
 import io.iohk.ethereum.rlp._
 import io.iohk.ethereum.utils.ByteStringUtils.ByteStringOps
+import io.iohk.ethereum.utils.Config
 
 object BaseETH6XMessages {
   object Status {
@@ -62,7 +63,7 @@ object BaseETH6XMessages {
         case r: RLPList if r.items.isEmpty => AccessListItem(null, List.empty)
 
         case RLPList(rlpAddress, rlpStorageKeys: RLPList) =>
-          val address = rlpAddress.decodeAs[Address]("address ")
+          val address = rlpAddress.decodeAs[Address]("address")
           val storageKeys = fromRlpList[BigInt](rlpStorageKeys).toList
           AccessListItem(address, storageKeys)
       }
@@ -154,7 +155,7 @@ object BaseETH6XMessages {
 
   object SignedTransactions {
 
-    lazy val chainId: Byte = 1.toByte //Config.blockchains.blockchainConfig.chainId
+    lazy val chainId: Byte = Config.blockchains.blockchainConfig.chainId
 
     implicit class SignedTransactionEnc(val signedTx: SignedTransaction) extends RLPSerializable {
 

src/test/scala/io/iohk/ethereum/domain/TransactionSpec.scala

@@ -37,6 +37,10 @@ class TransactionSpec
   }
 
   "Transaction type 01" should "be correctly serialized to rlp" in {
+
+    // binary values have be taken directly from core-geth own tests
+    // see https://github.com/ethereum/go-ethereum/blob/a580f7d6c54812ef47df94c6ffc974c9dbc48245/core/types/transaction_test.go#L71
+
     val toAddr: Address = Address.apply("b94f5374fce5edbc8e2a8697c15331677e6ebf0b")
     val tx: TransactionWithAccessList = TransactionWithAccessList(
       3,